[INFO] crate hyper-sync-rustls 0.3.0-rc.4 is already in cache [INFO] extracting crate hyper-sync-rustls 0.3.0-rc.4 into work/ex/clippy-test-run/sources/stable/reg/hyper-sync-rustls/0.3.0-rc.4 [INFO] extracting crate hyper-sync-rustls 0.3.0-rc.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-sync-rustls/0.3.0-rc.4 [INFO] validating manifest of hyper-sync-rustls-0.3.0-rc.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hyper-sync-rustls-0.3.0-rc.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hyper-sync-rustls-0.3.0-rc.4 [INFO] finished frobbing hyper-sync-rustls-0.3.0-rc.4 [INFO] frobbed toml for hyper-sync-rustls-0.3.0-rc.4 written to work/ex/clippy-test-run/sources/stable/reg/hyper-sync-rustls/0.3.0-rc.4/Cargo.toml [INFO] started frobbing hyper-sync-rustls-0.3.0-rc.4 [INFO] finished frobbing hyper-sync-rustls-0.3.0-rc.4 [INFO] frobbed toml for hyper-sync-rustls-0.3.0-rc.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-sync-rustls/0.3.0-rc.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hyper-sync-rustls-0.3.0-rc.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hyper-sync-rustls/0.3.0-rc.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69908f116830b996e6056814f8ca1d6f59b601cf0a0726d058457784c99265d7 [INFO] running `"docker" "start" "-a" "69908f116830b996e6056814f8ca1d6f59b601cf0a0726d058457784c99265d7"` [INFO] [stderr] Checking hyper-sync-rustls v0.3.0-rc.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:71:32 [INFO] [stderr] | [INFO] [stderr] 71 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 72 | | if let Err(err) = self.session.process_new_packets() { [INFO] [stderr] 73 | | // flush queued messages before returning an Err [INFO] [stderr] 74 | | // in order to send alerts instead of abruptly [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | } else if let Err(err) = self.session.process_new_packets() { [INFO] [stderr] 72 | // flush queued messages before returning an Err [INFO] [stderr] 73 | // in order to send alerts instead of abruptly [INFO] [stderr] 74 | // closing the socket [INFO] [stderr] 75 | if self.session.wants_write() { [INFO] [stderr] 76 | // ignore result to avoid masking original error [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TlsClient` [INFO] [stderr] --> src/lib.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / pub fn new() -> TlsClient { [INFO] [stderr] 181 | | let mut tls_config = rustls::ClientConfig::new(); [INFO] [stderr] 182 | | let cache = rustls::ClientSessionMemoryCache::new(64); [INFO] [stderr] 183 | | tls_config.set_persistence(cache); [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | impl Default for TlsClient { [INFO] [stderr] 180 | fn default() -> Self { [INFO] [stderr] 181 | Self::new() [INFO] [stderr] 182 | } [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:307:62 [INFO] [stderr] | [INFO] [stderr] 307 | let certfile = fs::File::open(path.as_ref()).map_err(|e| Error::Io(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:71:32 [INFO] [stderr] | [INFO] [stderr] 71 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 72 | | if let Err(err) = self.session.process_new_packets() { [INFO] [stderr] 73 | | // flush queued messages before returning an Err [INFO] [stderr] 74 | | // in order to send alerts instead of abruptly [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | } else if let Err(err) = self.session.process_new_packets() { [INFO] [stderr] 72 | // flush queued messages before returning an Err [INFO] [stderr] 73 | // in order to send alerts instead of abruptly [INFO] [stderr] 74 | // closing the socket [INFO] [stderr] 75 | if self.session.wants_write() { [INFO] [stderr] 76 | // ignore result to avoid masking original error [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TlsClient` [INFO] [stderr] --> src/lib.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / pub fn new() -> TlsClient { [INFO] [stderr] 181 | | let mut tls_config = rustls::ClientConfig::new(); [INFO] [stderr] 182 | | let cache = rustls::ClientSessionMemoryCache::new(64); [INFO] [stderr] 183 | | tls_config.set_persistence(cache); [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | impl Default for TlsClient { [INFO] [stderr] 180 | fn default() -> Self { [INFO] [stderr] 181 | Self::new() [INFO] [stderr] 182 | } [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:307:62 [INFO] [stderr] | [INFO] [stderr] 307 | let certfile = fs::File::open(path.as_ref()).map_err(|e| Error::Io(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::Io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/tests.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / cli.stdin [INFO] [stderr] 36 | | .as_mut() [INFO] [stderr] 37 | | .unwrap() [INFO] [stderr] 38 | | .write(b"GET / HTTP/1.0\r\n\r\n") [INFO] [stderr] 39 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hyper-sync-rustls`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "69908f116830b996e6056814f8ca1d6f59b601cf0a0726d058457784c99265d7"` [INFO] running `"docker" "rm" "-f" "69908f116830b996e6056814f8ca1d6f59b601cf0a0726d058457784c99265d7"` [INFO] [stdout] 69908f116830b996e6056814f8ca1d6f59b601cf0a0726d058457784c99265d7