[INFO] crate hyper-proxy 0.5.0 is already in cache [INFO] extracting crate hyper-proxy 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/hyper-proxy/0.5.0 [INFO] extracting crate hyper-proxy 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-proxy/0.5.0 [INFO] validating manifest of hyper-proxy-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hyper-proxy-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hyper-proxy-0.5.0 [INFO] finished frobbing hyper-proxy-0.5.0 [INFO] frobbed toml for hyper-proxy-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/hyper-proxy/0.5.0/Cargo.toml [INFO] started frobbing hyper-proxy-0.5.0 [INFO] finished frobbing hyper-proxy-0.5.0 [INFO] frobbed toml for hyper-proxy-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-proxy/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hyper-proxy-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hyper-proxy/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6dde302191f3da54e3693966cb8ed16c8213fe4188ce639cd1c09211bbaab78 [INFO] running `"docker" "start" "-a" "b6dde302191f3da54e3693966cb8ed16c8213fe4188ce639cd1c09211bbaab78"` [INFO] [stderr] Checking typed-headers v0.1.0 [INFO] [stderr] Checking hyper-proxy v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tunnel.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | write!(f, "{}: {}\r\n", key.as_str(), value_str)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tunnel.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tunnel.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | write!(f, "{}: {}\r\n", key.as_str(), value_str)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/tunnel.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | uri: uri, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uri` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:278:13 [INFO] [stderr] | [INFO] [stderr] 278 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'http::Uri::port': use `port_part` or `port_u16` instead [INFO] [stderr] --> src/lib.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | self.port() [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'http::Uri::port': use `port_part` or `port_u16` instead [INFO] [stderr] --> src/lib.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | self.port() [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'http::Uri::port': use `port_part` or `port_u16` instead [INFO] [stderr] --> src/lib.rs:424:24 [INFO] [stderr] | [INFO] [stderr] 424 | dst.set_port(proxy.port()); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'http::Uri::port': use `port_part` or `port_u16` instead [INFO] [stderr] --> src/lib.rs:424:24 [INFO] [stderr] | [INFO] [stderr] 424 | dst.set_port(proxy.port()); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | pub struct Custom(Arc, Option<&str>, Option) -> bool + Send + Sync>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:140:19 [INFO] [stderr] | [INFO] [stderr] 140 | pub struct Custom(Arc, Option<&str>, Option) -> bool + Send + Sync>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.14s [INFO] running `"docker" "inspect" "b6dde302191f3da54e3693966cb8ed16c8213fe4188ce639cd1c09211bbaab78"` [INFO] running `"docker" "rm" "-f" "b6dde302191f3da54e3693966cb8ed16c8213fe4188ce639cd1c09211bbaab78"` [INFO] [stdout] b6dde302191f3da54e3693966cb8ed16c8213fe4188ce639cd1c09211bbaab78