[INFO] crate hyper-json-server 0.1.0 is already in cache [INFO] extracting crate hyper-json-server 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/hyper-json-server/0.1.0 [INFO] extracting crate hyper-json-server 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-json-server/0.1.0 [INFO] validating manifest of hyper-json-server-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hyper-json-server-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hyper-json-server-0.1.0 [INFO] finished frobbing hyper-json-server-0.1.0 [INFO] frobbed toml for hyper-json-server-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/hyper-json-server/0.1.0/Cargo.toml [INFO] started frobbing hyper-json-server-0.1.0 [INFO] finished frobbing hyper-json-server-0.1.0 [INFO] frobbed toml for hyper-json-server-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-json-server/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hyper-json-server-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hyper-json-server/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97a05745a3942008518daf343c6f83a930ea025896a16431fbe722eceaf477c5 [INFO] running `"docker" "start" "-a" "97a05745a3942008518daf343c6f83a930ea025896a16431fbe722eceaf477c5"` [INFO] [stderr] Checking hyper-json-server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:123:28 [INFO] [stderr] | [INFO] [stderr] 123 | Ok(vec) => return Ok(vec), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | Err(e) => return Err(ErrorKind::BadRequest(e.to_string()).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ErrorKind::BadRequest(e.to_string()).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/server.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | let (status, body) = match error.kind() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 43 | | &ErrorKind::NotFound(_) => { [INFO] [stderr] 44 | | (StatusCode::NotFound, format!("{}", error)) [INFO] [stderr] 45 | | }, [INFO] [stderr] ... | [INFO] [stderr] 52 | | _ => (StatusCode::InternalServerError, format!("{}", error)) [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | let (status, body) = match *error.kind() { [INFO] [stderr] 43 | ErrorKind::NotFound(_) => { [INFO] [stderr] 44 | (StatusCode::NotFound, format!("{}", error)) [INFO] [stderr] 45 | }, [INFO] [stderr] 46 | ErrorKind::BadRequest(_) => { [INFO] [stderr] 47 | (StatusCode::BadRequest, format!("{}", error)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:110:59 [INFO] [stderr] | [INFO] [stderr] 110 | fn deserialize(&self, path: &str, method: &Method) -> Result Result<::Request>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:120:61 [INFO] [stderr] | [INFO] [stderr] 120 | fn deserialize(&self, _path: &str, _method: &Method) -> Result Result<::Request>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:123:28 [INFO] [stderr] | [INFO] [stderr] 123 | Ok(vec) => return Ok(vec), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | Err(e) => return Err(ErrorKind::BadRequest(e.to_string()).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ErrorKind::BadRequest(e.to_string()).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/server.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | let (status, body) = match error.kind() { [INFO] [stderr] | __________________________^ [INFO] [stderr] 43 | | &ErrorKind::NotFound(_) => { [INFO] [stderr] 44 | | (StatusCode::NotFound, format!("{}", error)) [INFO] [stderr] 45 | | }, [INFO] [stderr] ... | [INFO] [stderr] 52 | | _ => (StatusCode::InternalServerError, format!("{}", error)) [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | let (status, body) = match *error.kind() { [INFO] [stderr] 43 | ErrorKind::NotFound(_) => { [INFO] [stderr] 44 | (StatusCode::NotFound, format!("{}", error)) [INFO] [stderr] 45 | }, [INFO] [stderr] 46 | ErrorKind::BadRequest(_) => { [INFO] [stderr] 47 | (StatusCode::BadRequest, format!("{}", error)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:110:59 [INFO] [stderr] | [INFO] [stderr] 110 | fn deserialize(&self, path: &str, method: &Method) -> Result Result<::Request>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:120:61 [INFO] [stderr] | [INFO] [stderr] 120 | fn deserialize(&self, _path: &str, _method: &Method) -> Result Result<::Request>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.35s [INFO] running `"docker" "inspect" "97a05745a3942008518daf343c6f83a930ea025896a16431fbe722eceaf477c5"` [INFO] running `"docker" "rm" "-f" "97a05745a3942008518daf343c6f83a930ea025896a16431fbe722eceaf477c5"` [INFO] [stdout] 97a05745a3942008518daf343c6f83a930ea025896a16431fbe722eceaf477c5