[INFO] crate hyper-http-connector 0.1.0 is already in cache
[INFO] extracting crate hyper-http-connector 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/hyper-http-connector/0.1.0
[INFO] extracting crate hyper-http-connector 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-http-connector/0.1.0
[INFO] validating manifest of hyper-http-connector-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hyper-http-connector-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hyper-http-connector-0.1.0
[INFO] finished frobbing hyper-http-connector-0.1.0
[INFO] frobbed toml for hyper-http-connector-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/hyper-http-connector/0.1.0/Cargo.toml
[INFO] started frobbing hyper-http-connector-0.1.0
[INFO] finished frobbing hyper-http-connector-0.1.0
[INFO] frobbed toml for hyper-http-connector-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-http-connector/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hyper-http-connector-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hyper-http-connector/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 34e90a981c6656f0a93aa7b6794b290a44493b93adbe6a75e8827a73de35846c
[INFO] running `"docker" "start" "-a" "34e90a981c6656f0a93aa7b6794b290a44493b93adbe6a75e8827a73de35846c"`
[INFO] [stderr]    Compiling metadeps v1.1.2
[INFO] [stderr]     Checking c-types v2.0.2
[INFO] [stderr]    Compiling c-ares-sys v4.2.0
[INFO] [stderr]     Checking c-ares v5.0.4
[INFO] [stderr]     Checking c-ares-resolver v4.0.3
[INFO] [stderr]     Checking hyper-http-connector v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:344:28
[INFO] [stderr]     |
[INFO] [stderr] 344 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 345 | |                         if let Some(ip_addrs) = result_cache.read().get(host) {
[INFO] [stderr] 346 | |                             trace!("ResultCache - got cached ips!");
[INFO] [stderr] 347 | |                             let shift_index =
[INFO] [stderr] ...   |
[INFO] [stderr] 365 | |                         }
[INFO] [stderr] 366 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 344 |                     } else if let Some(ip_addrs) = result_cache.read().get(host) {
[INFO] [stderr] 345 |     trace!("ResultCache - got cached ips!");
[INFO] [stderr] 346 |     let shift_index =
[INFO] [stderr] 347 |         round_robin_map.lock().get_and_incr(Arc::clone(&host));
[INFO] [stderr] 348 |     State::Connecting(ConnectingTcp {
[INFO] [stderr] 349 |         addrs: dns::IpAddrs::new(port, ip_addrs.clone(), shift_index),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_reactor::Handle::current': semantics were sometimes surprising, use Handle::default()
[INFO] [stderr]   --> src/lib.rs:77:28
[INFO] [stderr]    |
[INFO] [stderr] 77 |         None => Cow::Owned(Handle::current()),
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:344:28
[INFO] [stderr]     |
[INFO] [stderr] 344 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 345 | |                         if let Some(ip_addrs) = result_cache.read().get(host) {
[INFO] [stderr] 346 | |                             trace!("ResultCache - got cached ips!");
[INFO] [stderr] 347 | |                             let shift_index =
[INFO] [stderr] ...   |
[INFO] [stderr] 365 | |                         }
[INFO] [stderr] 366 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 344 |                     } else if let Some(ip_addrs) = result_cache.read().get(host) {
[INFO] [stderr] 345 |     trace!("ResultCache - got cached ips!");
[INFO] [stderr] 346 |     let shift_index =
[INFO] [stderr] 347 |         round_robin_map.lock().get_and_incr(Arc::clone(&host));
[INFO] [stderr] 348 |     State::Connecting(ConnectingTcp {
[INFO] [stderr] 349 |         addrs: dns::IpAddrs::new(port, ip_addrs.clone(), shift_index),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/timed_cache.rs:26:16
[INFO] [stderr]    |
[INFO] [stderr] 26 |             if stored_at > &Instant::now() {
[INFO] [stderr]    |                ^^^^^^^^^^^^---------------
[INFO] [stderr]    |                            |
[INFO] [stderr]    |                            help: use the right value directly: `Instant::now()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:58:19
[INFO] [stderr]    |
[INFO] [stderr] 58 |       let builder = match addr {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 59 | |         &SocketAddr::V4(_) => TcpBuilder::new_v4()?,
[INFO] [stderr] 60 | |         &SocketAddr::V6(_) => TcpBuilder::new_v6()?,
[INFO] [stderr] 61 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let builder = match *addr {
[INFO] [stderr] 59 |         SocketAddr::V4(_) => TcpBuilder::new_v4()?,
[INFO] [stderr] 60 |         SocketAddr::V6(_) => TcpBuilder::new_v6()?,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:65:38
[INFO] [stderr]    |
[INFO] [stderr] 65 |         builder.bind(SocketAddr::new(local_addr.clone(), 0))?;
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*local_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:68:31
[INFO] [stderr]    |
[INFO] [stderr] 68 |           let any: SocketAddr = match addr {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 69 | |             &SocketAddr::V4(_) => ([0, 0, 0, 0], 0).into(),
[INFO] [stderr] 70 | |             &SocketAddr::V6(_) => ([0, 0, 0, 0, 0, 0, 0, 0], 0).into(),
[INFO] [stderr] 71 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let any: SocketAddr = match *addr {
[INFO] [stderr] 69 |             SocketAddr::V4(_) => ([0, 0, 0, 0], 0).into(),
[INFO] [stderr] 70 |             SocketAddr::V6(_) => ([0, 0, 0, 0, 0, 0, 0, 0], 0).into(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_reactor::Handle::current': semantics were sometimes surprising, use Handle::default()
[INFO] [stderr]   --> src/lib.rs:77:28
[INFO] [stderr]    |
[INFO] [stderr] 77 |         None => Cow::Owned(Handle::current()),
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/timed_cache.rs:26:16
[INFO] [stderr]    |
[INFO] [stderr] 26 |             if stored_at > &Instant::now() {
[INFO] [stderr]    |                ^^^^^^^^^^^^---------------
[INFO] [stderr]    |                            |
[INFO] [stderr]    |                            help: use the right value directly: `Instant::now()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:58:19
[INFO] [stderr]    |
[INFO] [stderr] 58 |       let builder = match addr {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 59 | |         &SocketAddr::V4(_) => TcpBuilder::new_v4()?,
[INFO] [stderr] 60 | |         &SocketAddr::V6(_) => TcpBuilder::new_v6()?,
[INFO] [stderr] 61 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let builder = match *addr {
[INFO] [stderr] 59 |         SocketAddr::V4(_) => TcpBuilder::new_v4()?,
[INFO] [stderr] 60 |         SocketAddr::V6(_) => TcpBuilder::new_v6()?,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:65:38
[INFO] [stderr]    |
[INFO] [stderr] 65 |         builder.bind(SocketAddr::new(local_addr.clone(), 0))?;
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*local_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:68:31
[INFO] [stderr]    |
[INFO] [stderr] 68 |           let any: SocketAddr = match addr {
[INFO] [stderr]    |  _______________________________^
[INFO] [stderr] 69 | |             &SocketAddr::V4(_) => ([0, 0, 0, 0], 0).into(),
[INFO] [stderr] 70 | |             &SocketAddr::V6(_) => ([0, 0, 0, 0, 0, 0, 0, 0], 0).into(),
[INFO] [stderr] 71 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let any: SocketAddr = match *addr {
[INFO] [stderr] 69 |             SocketAddr::V4(_) => ([0, 0, 0, 0], 0).into(),
[INFO] [stderr] 70 |             SocketAddr::V6(_) => ([0, 0, 0, 0, 0, 0, 0, 0], 0).into(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2m 12s
[INFO] running `"docker" "inspect" "34e90a981c6656f0a93aa7b6794b290a44493b93adbe6a75e8827a73de35846c"`
[INFO] running `"docker" "rm" "-f" "34e90a981c6656f0a93aa7b6794b290a44493b93adbe6a75e8827a73de35846c"`
[INFO] [stdout] 34e90a981c6656f0a93aa7b6794b290a44493b93adbe6a75e8827a73de35846c