[INFO] crate hyper-dns 0.3.0 is already in cache [INFO] extracting crate hyper-dns 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/hyper-dns/0.3.0 [INFO] extracting crate hyper-dns 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-dns/0.3.0 [INFO] validating manifest of hyper-dns-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hyper-dns-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hyper-dns-0.3.0 [INFO] finished frobbing hyper-dns-0.3.0 [INFO] frobbed toml for hyper-dns-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/hyper-dns/0.3.0/Cargo.toml [INFO] started frobbing hyper-dns-0.3.0 [INFO] finished frobbing hyper-dns-0.3.0 [INFO] frobbed toml for hyper-dns-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hyper-dns/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hyper-dns-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hyper-dns/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5280341186b5b8867b7ec9586d0d0db51bc0544b9001d82542ca7d226eac658 [INFO] running `"docker" "start" "-a" "f5280341186b5b8867b7ec9586d0d0db51bc0544b9001d82542ca7d226eac658"` [INFO] [stderr] Checking trust-dns-proto v0.4.3 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking trust-dns v0.14.0 [INFO] [stderr] Checking hyper-dns v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | record_type: record_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | dns_addr: dns_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dns_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | record_type: record_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | dns_addr: dns_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dns_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | / return future::err( [INFO] [stderr] 130 | | std::io::Error::new( [INFO] [stderr] 131 | | std::io::ErrorKind::Other, [INFO] [stderr] 132 | | "Failed to query DNS server", [INFO] [stderr] 133 | | ).into(), [INFO] [stderr] 134 | | ); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 129 | future::err( [INFO] [stderr] 130 | std::io::Error::new( [INFO] [stderr] 131 | std::io::ErrorKind::Other, [INFO] [stderr] 132 | "Failed to query DNS server", [INFO] [stderr] 133 | ).into(), [INFO] [stderr] 134 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | / return future::err( [INFO] [stderr] 130 | | std::io::Error::new( [INFO] [stderr] 131 | | std::io::ErrorKind::Other, [INFO] [stderr] 132 | | "Failed to query DNS server", [INFO] [stderr] 133 | | ).into(), [INFO] [stderr] 134 | | ); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 129 | future::err( [INFO] [stderr] 130 | std::io::Error::new( [INFO] [stderr] 131 | std::io::ErrorKind::Other, [INFO] [stderr] 132 | "Failed to query DNS server", [INFO] [stderr] 133 | ).into(), [INFO] [stderr] 134 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:92:28 [INFO] [stderr] | [INFO] [stderr] 92 | let port = uri.port().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `uri.port()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | / std::io::Error::new( [INFO] [stderr] 131 | | std::io::ErrorKind::Other, [INFO] [stderr] 132 | | "Failed to query DNS server", [INFO] [stderr] 133 | | ).into(), [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 130 | std::io::Error::new( [INFO] [stderr] 131 | std::io::ErrorKind::Other, [INFO] [stderr] 132 | "Failed to query DNS server", [INFO] [stderr] 133 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:141:33 [INFO] [stderr] | [INFO] [stderr] 141 | / std::io::Error::new( [INFO] [stderr] 142 | | std::io::ErrorKind::Other, [INFO] [stderr] 143 | | "No valid DNS answers", [INFO] [stderr] 144 | | ).into(), [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 141 | std::io::Error::new( [INFO] [stderr] 142 | std::io::ErrorKind::Other, [INFO] [stderr] 143 | "No valid DNS answers", [INFO] [stderr] 144 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:160:41 [INFO] [stderr] | [INFO] [stderr] 160 | / std::io::Error::new( [INFO] [stderr] 161 | | std::io::ErrorKind::Other, [INFO] [stderr] 162 | | "Unexpected DNS response", [INFO] [stderr] 163 | | ).into(), [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 160 | std::io::Error::new( [INFO] [stderr] 161 | std::io::ErrorKind::Other, [INFO] [stderr] 162 | "Unexpected DNS response", [INFO] [stderr] 163 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:182:41 [INFO] [stderr] | [INFO] [stderr] 182 | / std::io::Error::new( [INFO] [stderr] 183 | | std::io::ErrorKind::Other, [INFO] [stderr] 184 | | "Did not receive a valid record", [INFO] [stderr] 185 | | ).into(), [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 182 | std::io::Error::new( [INFO] [stderr] 183 | std::io::ErrorKind::Other, [INFO] [stderr] 184 | "Did not receive a valid record", [INFO] [stderr] 185 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | / std::io::Error::new( [INFO] [stderr] 194 | | std::io::ErrorKind::Other, [INFO] [stderr] 195 | | "Did not receive a valid record", [INFO] [stderr] 196 | | ).into(), [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 193 | std::io::Error::new( [INFO] [stderr] 194 | std::io::ErrorKind::Other, [INFO] [stderr] 195 | "Did not receive a valid record", [INFO] [stderr] 196 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:92:28 [INFO] [stderr] | [INFO] [stderr] 92 | let port = uri.port().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `uri.port()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | / std::io::Error::new( [INFO] [stderr] 131 | | std::io::ErrorKind::Other, [INFO] [stderr] 132 | | "Failed to query DNS server", [INFO] [stderr] 133 | | ).into(), [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 130 | std::io::Error::new( [INFO] [stderr] 131 | std::io::ErrorKind::Other, [INFO] [stderr] 132 | "Failed to query DNS server", [INFO] [stderr] 133 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:141:33 [INFO] [stderr] | [INFO] [stderr] 141 | / std::io::Error::new( [INFO] [stderr] 142 | | std::io::ErrorKind::Other, [INFO] [stderr] 143 | | "No valid DNS answers", [INFO] [stderr] 144 | | ).into(), [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 141 | std::io::Error::new( [INFO] [stderr] 142 | std::io::ErrorKind::Other, [INFO] [stderr] 143 | "No valid DNS answers", [INFO] [stderr] 144 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:160:41 [INFO] [stderr] | [INFO] [stderr] 160 | / std::io::Error::new( [INFO] [stderr] 161 | | std::io::ErrorKind::Other, [INFO] [stderr] 162 | | "Unexpected DNS response", [INFO] [stderr] 163 | | ).into(), [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 160 | std::io::Error::new( [INFO] [stderr] 161 | std::io::ErrorKind::Other, [INFO] [stderr] 162 | "Unexpected DNS response", [INFO] [stderr] 163 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:182:41 [INFO] [stderr] | [INFO] [stderr] 182 | / std::io::Error::new( [INFO] [stderr] 183 | | std::io::ErrorKind::Other, [INFO] [stderr] 184 | | "Did not receive a valid record", [INFO] [stderr] 185 | | ).into(), [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 182 | std::io::Error::new( [INFO] [stderr] 183 | std::io::ErrorKind::Other, [INFO] [stderr] 184 | "Did not receive a valid record", [INFO] [stderr] 185 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:193:33 [INFO] [stderr] | [INFO] [stderr] 193 | / std::io::Error::new( [INFO] [stderr] 194 | | std::io::ErrorKind::Other, [INFO] [stderr] 195 | | "Did not receive a valid record", [INFO] [stderr] 196 | | ).into(), [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 193 | std::io::Error::new( [INFO] [stderr] 194 | std::io::ErrorKind::Other, [INFO] [stderr] 195 | "Did not receive a valid record", [INFO] [stderr] 196 | ), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.50s [INFO] running `"docker" "inspect" "f5280341186b5b8867b7ec9586d0d0db51bc0544b9001d82542ca7d226eac658"` [INFO] running `"docker" "rm" "-f" "f5280341186b5b8867b7ec9586d0d0db51bc0544b9001d82542ca7d226eac658"` [INFO] [stdout] f5280341186b5b8867b7ec9586d0d0db51bc0544b9001d82542ca7d226eac658