[INFO] crate hydrogen 0.1.4 is already in cache
[INFO] extracting crate hydrogen 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/hydrogen/0.1.4
[INFO] extracting crate hydrogen 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hydrogen/0.1.4
[INFO] validating manifest of hydrogen-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hydrogen-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hydrogen-0.1.4
[INFO] finished frobbing hydrogen-0.1.4
[INFO] frobbed toml for hydrogen-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/hydrogen/0.1.4/Cargo.toml
[INFO] started frobbing hydrogen-0.1.4
[INFO] finished frobbing hydrogen-0.1.4
[INFO] frobbed toml for hydrogen-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hydrogen/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hydrogen-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hydrogen/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 414082ca677bc477a71962d1aec348b7dbc3b17404f6f50282b9c14bbd4d95a9
[INFO] running `"docker" "start" "-a" "414082ca677bc477a71962d1aec348b7dbc3b17404f6f50282b9c14bbd4d95a9"`
[INFO] [stderr]     Checking threadpool v1.0.2
[INFO] [stderr]     Checking simple-slab v0.2.3
[INFO] [stderr]     Checking errno v0.1.8
[INFO] [stderr]     Checking hydrogen v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:104:13
[INFO] [stderr]     |
[INFO] [stderr] 104 |             arc_connection: arc_connection,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arc_connection`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |             rearm_fn: rearm_fn
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `rearm_fn`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         fd: fd,
[INFO] [stderr]     |         ^^^^^^ help: replace it with: `fd`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server.rs:403:13
[INFO] [stderr]     |
[INFO] [stderr] 403 |             arc_connection: arc_connection
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arc_connection`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:104:13
[INFO] [stderr]     |
[INFO] [stderr] 104 |             arc_connection: arc_connection,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arc_connection`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |             rearm_fn: rearm_fn
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `rearm_fn`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         fd: fd,
[INFO] [stderr]     |         ^^^^^^ help: replace it with: `fd`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/server.rs:403:13
[INFO] [stderr]     |
[INFO] [stderr] 403 |             arc_connection: arc_connection
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arc_connection`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/server.rs:437:18
[INFO] [stderr]     |
[INFO] [stderr] 437 |     let _100ms = 1000000 * 100;
[INFO] [stderr]     |                  ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/server.rs:526:5
[INFO] [stderr]     |
[INFO] [stderr] 526 |     return -1i32;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `-1i32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/server.rs:575:5
[INFO] [stderr]     |
[INFO] [stderr] 575 |     return -1i32;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `-1i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/server.rs:437:18
[INFO] [stderr]     |
[INFO] [stderr] 437 |     let _100ms = 1000000 * 100;
[INFO] [stderr]     |                  ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/server.rs:526:5
[INFO] [stderr]     |
[INFO] [stderr] 526 |     return -1i32;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `-1i32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/server.rs:575:5
[INFO] [stderr]     |
[INFO] [stderr] 575 |     return -1i32;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `-1i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Stream`
[INFO] [stderr]   --> src/server.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 | use super::{Stream, Handler};
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Stream`
[INFO] [stderr]   --> src/server.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 | use super::{Stream, Handler};
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `epfd` should have an upper case name such as `EPFD`
[INFO] [stderr]   --> src/server.rs:45:1
[INFO] [stderr]    |
[INFO] [stderr] 45 | static mut epfd: RawFd = 0 as RawFd;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_upper_case_globals)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: unsafe vector initialization
[INFO] [stderr]    --> src/server.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 192 |     let mut event_buffer = Vec::<libc::epoll_event>::with_capacity(MAX_EVENTS as usize);
[INFO] [stderr]     |                            ------------------------------------------------------------ help: consider replace allocation with: `vec![0; MAX_EVENTS as usize]`
[INFO] [stderr] 193 |     event_buffer.set_len(MAX_EVENTS as usize);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unsafe_vector_initialization)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/server.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 |            err_state.map(|e| {
[INFO] [stderr]     |   _________^
[INFO] [stderr]     |  |_________|
[INFO] [stderr]     | ||
[INFO] [stderr] 238 | ||             trace!("Found stale connection");
[INFO] [stderr] 239 | ||
[INFO] [stderr] 240 | ||             let arc_connection = (*slab_ptr).remove(x as usize);
[INFO] [stderr] ...   ||
[INFO] [stderr] 249 | ||             x -= 1;
[INFO] [stderr] 250 | ||         });
[INFO] [stderr]     | ||__________^- help: try this: `if let Some(e) = err_state { ... }`
[INFO] [stderr]     | |___________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference
[INFO] [stderr]    --> src/server.rs:277:27
[INFO] [stderr]     |
[INFO] [stderr] 277 |     let num_connections = (&mut *new_slab).len();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/server.rs:424:9
[INFO] [stderr]     |
[INFO] [stderr] 424 |     for ref arc_connection in (*slab_ptr).iter() {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^    ------------------ help: try: `let arc_connection = &(*slab_ptr).iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/server.rs:454:12
[INFO] [stderr]     |
[INFO] [stderr] 454 |         if io_queue.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!io_queue.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/server.rs:458:9
[INFO] [stderr]     |
[INFO] [stderr] 458 |     for ref io_pair in io_queue.iter() {
[INFO] [stderr]     |         ^^^^^^^^^^^    --------------- help: try: `let io_pair = &io_queue.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `epfd` should have an upper case name such as `EPFD`
[INFO] [stderr]   --> src/server.rs:45:1
[INFO] [stderr]    |
[INFO] [stderr] 45 | static mut epfd: RawFd = 0 as RawFd;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_upper_case_globals)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `hydrogen`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: unsafe vector initialization
[INFO] [stderr]    --> src/server.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 192 |     let mut event_buffer = Vec::<libc::epoll_event>::with_capacity(MAX_EVENTS as usize);
[INFO] [stderr]     |                            ------------------------------------------------------------ help: consider replace allocation with: `vec![0; MAX_EVENTS as usize]`
[INFO] [stderr] 193 |     event_buffer.set_len(MAX_EVENTS as usize);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unsafe_vector_initialization)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/server.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 |            err_state.map(|e| {
[INFO] [stderr]     |   _________^
[INFO] [stderr]     |  |_________|
[INFO] [stderr]     | ||
[INFO] [stderr] 238 | ||             trace!("Found stale connection");
[INFO] [stderr] 239 | ||
[INFO] [stderr] 240 | ||             let arc_connection = (*slab_ptr).remove(x as usize);
[INFO] [stderr] ...   ||
[INFO] [stderr] 249 | ||             x -= 1;
[INFO] [stderr] 250 | ||         });
[INFO] [stderr]     | ||__________^- help: try this: `if let Some(e) = err_state { ... }`
[INFO] [stderr]     | |___________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference
[INFO] [stderr]    --> src/server.rs:277:27
[INFO] [stderr]     |
[INFO] [stderr] 277 |     let num_connections = (&mut *new_slab).len();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/server.rs:424:9
[INFO] [stderr]     |
[INFO] [stderr] 424 |     for ref arc_connection in (*slab_ptr).iter() {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^    ------------------ help: try: `let arc_connection = &(*slab_ptr).iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/server.rs:454:12
[INFO] [stderr]     |
[INFO] [stderr] 454 |         if io_queue.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!io_queue.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/server.rs:458:9
[INFO] [stderr]     |
[INFO] [stderr] 458 |     for ref io_pair in io_queue.iter() {
[INFO] [stderr]     |         ^^^^^^^^^^^    --------------- help: try: `let io_pair = &io_queue.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `hydrogen`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "414082ca677bc477a71962d1aec348b7dbc3b17404f6f50282b9c14bbd4d95a9"`
[INFO] running `"docker" "rm" "-f" "414082ca677bc477a71962d1aec348b7dbc3b17404f6f50282b9c14bbd4d95a9"`
[INFO] [stdout] 414082ca677bc477a71962d1aec348b7dbc3b17404f6f50282b9c14bbd4d95a9