[INFO] crate hwloc 0.5.0 is already in cache [INFO] extracting crate hwloc 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/hwloc/0.5.0 [INFO] extracting crate hwloc 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hwloc/0.5.0 [INFO] validating manifest of hwloc-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hwloc-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hwloc-0.5.0 [INFO] finished frobbing hwloc-0.5.0 [INFO] frobbed toml for hwloc-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/hwloc/0.5.0/Cargo.toml [INFO] started frobbing hwloc-0.5.0 [INFO] finished frobbing hwloc-0.5.0 [INFO] frobbed toml for hwloc-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hwloc/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hwloc-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hwloc/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be0ea934b87797c03121a55242a11ff4c869600e31ae07930fd770bb52f22a8b [INFO] running `"docker" "start" "-a" "be0ea934b87797c03121a55242a11ff4c869600e31ae07930fd770bb52f22a8b"` [INFO] [stderr] Compiling hwloc v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | manage: manage, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `manage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | topo: topo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `topo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | support: support, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `support` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | topo: topo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `topo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | support: support, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `support` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | manage: manage, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `manage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | topo: topo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `topo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | support: support, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `support` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | topo: topo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `topo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | support: support, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `support` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/topology_object.rs:229:33 [INFO] [stderr] | [INFO] [stderr] 229 | fn deref_topology(&self, p: &*mut TopologyObject) -> Option<&TopologyObject> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `*mut TopologyObject` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:366:9 [INFO] [stderr] | [INFO] [stderr] 366 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectCacheAttributes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:370:9 [INFO] [stderr] | [INFO] [stderr] 370 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectGroupAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:374:9 [INFO] [stderr] | [INFO] [stderr] 374 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectPCIDevAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectBridgeAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectOSDevAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bitmap.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | !(result == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `result != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bitmap.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | !(result == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `result != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:587:33 [INFO] [stderr] | [INFO] [stderr] 587 | const CPUBIND_PROCESS = (1<<0), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/ffi.rs:419:17 [INFO] [stderr] | [INFO] [stderr] 419 | assert!(ObjectType::Machine == ObjectType::Machine); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/ffi.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | assert!(ObjectType::PU == ObjectType::PU); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/topology_object.rs:229:33 [INFO] [stderr] | [INFO] [stderr] 229 | fn deref_topology(&self, p: &*mut TopologyObject) -> Option<&TopologyObject> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `*mut TopologyObject` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:366:9 [INFO] [stderr] | [INFO] [stderr] 366 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectCacheAttributes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:370:9 [INFO] [stderr] | [INFO] [stderr] 370 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectGroupAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:374:9 [INFO] [stderr] | [INFO] [stderr] 374 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectPCIDevAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectBridgeAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/topology_object.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | ::std::mem::transmute(raw.offset(0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `raw.offset(0) as *mut topology_object::TopologyObjectOSDevAttributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bitmap.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | !(result == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `result != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/bitmap.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | !(result == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `result != 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:587:33 [INFO] [stderr] | [INFO] [stderr] 587 | const CPUBIND_PROCESS = (1<<0), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `hwloc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "be0ea934b87797c03121a55242a11ff4c869600e31ae07930fd770bb52f22a8b"` [INFO] running `"docker" "rm" "-f" "be0ea934b87797c03121a55242a11ff4c869600e31ae07930fd770bb52f22a8b"` [INFO] [stdout] be0ea934b87797c03121a55242a11ff4c869600e31ae07930fd770bb52f22a8b