[INFO] crate hungarian 1.1.0 is already in cache [INFO] extracting crate hungarian 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/hungarian/1.1.0 [INFO] extracting crate hungarian 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hungarian/1.1.0 [INFO] validating manifest of hungarian-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hungarian-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hungarian-1.1.0 [INFO] finished frobbing hungarian-1.1.0 [INFO] frobbed toml for hungarian-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/hungarian/1.1.0/Cargo.toml [INFO] started frobbing hungarian-1.1.0 [INFO] finished frobbing hungarian-1.1.0 [INFO] frobbed toml for hungarian-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hungarian/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hungarian-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hungarian/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89b8fec6f3e7da371b69488b24ca8fff826e6fbbe58c6dbb3cad45ff6c40d277 [INFO] running `"docker" "start" "-a" "89b8fec6f3e7da371b69488b24ca8fff826e6fbbe58c6dbb3cad45ff6c40d277"` [INFO] [stderr] Checking hungarian v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:324:17 [INFO] [stderr] | [INFO] [stderr] 324 | let (i, j) = uncovered.unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:324:17 [INFO] [stderr] | [INFO] [stderr] 324 | let (i, j) = uncovered.unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:149:1 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn minimize(matrix: &[N], height: usize, width: usize) -> Vec> { [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | // No possible assignment [INFO] [stderr] 152 | | if height == 0 || width == 0 { return Vec::new() } [INFO] [stderr] ... | [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:199:19 [INFO] [stderr] | [INFO] [stderr] 199 | let min = row.iter().min().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*row.iter().min().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:261:39 [INFO] [stderr] | [INFO] [stderr] 261 | return assign.map(|j| Some(j)).collect() [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:288:16 [INFO] [stderr] | [INFO] [stderr] 288 | if let None = uncovered { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 289 | | [INFO] [stderr] 290 | | //********************************************// [INFO] [stderr] 291 | | // // [INFO] [stderr] ... | [INFO] [stderr] 321 | | continue [INFO] [stderr] 322 | | } [INFO] [stderr] | |_________- help: try this: `if uncovered.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:351:20 [INFO] [stderr] | [INFO] [stderr] 351 | if let None = next_star { break } [INFO] [stderr] | -------^^^^---------------------- help: try this: `if next_star.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:149:1 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn minimize(matrix: &[N], height: usize, width: usize) -> Vec> { [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | // No possible assignment [INFO] [stderr] 152 | | if height == 0 || width == 0 { return Vec::new() } [INFO] [stderr] ... | [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:199:19 [INFO] [stderr] | [INFO] [stderr] 199 | let min = row.iter().min().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*row.iter().min().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:261:39 [INFO] [stderr] | [INFO] [stderr] 261 | return assign.map(|j| Some(j)).collect() [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:288:16 [INFO] [stderr] | [INFO] [stderr] 288 | if let None = uncovered { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 289 | | [INFO] [stderr] 290 | | //********************************************// [INFO] [stderr] 291 | | // // [INFO] [stderr] ... | [INFO] [stderr] 321 | | continue [INFO] [stderr] 322 | | } [INFO] [stderr] | |_________- help: try this: `if uncovered.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:351:20 [INFO] [stderr] | [INFO] [stderr] 351 | if let None = next_star { break } [INFO] [stderr] | -------^^^^---------------------- help: try this: `if next_star.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:790:41 [INFO] [stderr] | [INFO] [stderr] 790 | let expected = (0..max).map(|i| Some(i)).rev().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:806:41 [INFO] [stderr] | [INFO] [stderr] 806 | let expected = (0..max).map(|i| Some(i)).rev().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:824:37 [INFO] [stderr] | [INFO] [stderr] 824 | let expected = (0..max).map(|i| Some(i)).rev().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.41s [INFO] running `"docker" "inspect" "89b8fec6f3e7da371b69488b24ca8fff826e6fbbe58c6dbb3cad45ff6c40d277"` [INFO] running `"docker" "rm" "-f" "89b8fec6f3e7da371b69488b24ca8fff826e6fbbe58c6dbb3cad45ff6c40d277"` [INFO] [stdout] 89b8fec6f3e7da371b69488b24ca8fff826e6fbbe58c6dbb3cad45ff6c40d277