[INFO] crate humansize 1.1.0 is already in cache [INFO] extracting crate humansize 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/humansize/1.1.0 [INFO] extracting crate humansize 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/humansize/1.1.0 [INFO] validating manifest of humansize-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of humansize-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing humansize-1.1.0 [INFO] finished frobbing humansize-1.1.0 [INFO] frobbed toml for humansize-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/humansize/1.1.0/Cargo.toml [INFO] started frobbing humansize-1.1.0 [INFO] finished frobbing humansize-1.1.0 [INFO] frobbed toml for humansize-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/humansize/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting humansize-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/humansize/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0854ef4d78661bfb6d611afdf277cabc583e305ec350fc7b9c56e35ab3fd5fb [INFO] running `"docker" "start" "-a" "b0854ef4d78661bfb6d611afdf277cabc583e305ec350fc7b9c56e35ab3fd5fb"` [INFO] [stderr] Checking humansize v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | 16584975.file_size(semi_custom_options5).unwrap(), [INFO] [stderr] | ^^^^^^^^ help: consider: `16_584_975` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | 15284975.file_size(semi_custom_options6).unwrap(), [INFO] [stderr] | ^^^^^^^^ help: consider: `15_284_975` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | val @ _ => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:218:30 [INFO] [stderr] | [INFO] [stderr] 218 | if opts.long_units && size.trunc() == 1.0 { scale = &scale[0 .. scale.len()-1];} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(size.trunc() - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:218:30 [INFO] [stderr] | [INFO] [stderr] 218 | if opts.long_units && size.trunc() == 1.0 { scale = &scale[0 .. scale.len()-1];} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | let space = match opts.space { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 227 | | true => " ", [INFO] [stderr] 228 | | false => "" [INFO] [stderr] 229 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if opts.space { impl_file_size_u!(for usize u8 u16 u32 u64); } else { impl_file_size_u!(for usize u8 u16 u32 u64); }` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | let mut size: f64 = *self as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | val @ _ => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:218:30 [INFO] [stderr] | [INFO] [stderr] 218 | if opts.long_units && size.trunc() == 1.0 { scale = &scale[0 .. scale.len()-1];} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(size.trunc() - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:218:30 [INFO] [stderr] | [INFO] [stderr] 218 | if opts.long_units && size.trunc() == 1.0 { scale = &scale[0 .. scale.len()-1];} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | let space = match opts.space { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 227 | | true => " ", [INFO] [stderr] 228 | | false => "" [INFO] [stderr] 229 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if opts.space { impl_file_size_u!(for usize u8 u16 u32 u64); } else { impl_file_size_u!(for usize u8 u16 u32 u64); }` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | let mut size: f64 = *self as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | let mut size: f64 = *self as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `humansize`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | val @ _ => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:218:30 [INFO] [stderr] | [INFO] [stderr] 218 | if opts.long_units && size.trunc() == 1.0 { scale = &scale[0 .. scale.len()-1];} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(size.trunc() - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:218:30 [INFO] [stderr] | [INFO] [stderr] 218 | if opts.long_units && size.trunc() == 1.0 { scale = &scale[0 .. scale.len()-1];} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | let space = match opts.space { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 227 | | true => " ", [INFO] [stderr] 228 | | false => "" [INFO] [stderr] 229 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if opts.space { impl_file_size_u!(for usize u8 u16 u32 u64); } else { impl_file_size_u!(for usize u8 u16 u32 u64); }` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | let mut size: f64 = *self as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/lib.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | val @ _ => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:218:30 [INFO] [stderr] | [INFO] [stderr] 218 | if opts.long_units && size.trunc() == 1.0 { scale = &scale[0 .. scale.len()-1];} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(size.trunc() - 1.0).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:218:30 [INFO] [stderr] | [INFO] [stderr] 218 | if opts.long_units && size.trunc() == 1.0 { scale = &scale[0 .. scale.len()-1];} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | let space = match opts.space { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 227 | | true => " ", [INFO] [stderr] 228 | | false => "" [INFO] [stderr] 229 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if opts.space { impl_file_size_u!(for usize u8 u16 u32 u64); } else { impl_file_size_u!(for usize u8 u16 u32 u64); }` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | let mut size: f64 = *self as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | let mut size: f64 = *self as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 259 | impl_file_size_u!(for usize u8 u16 u32 u64); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `humansize`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b0854ef4d78661bfb6d611afdf277cabc583e305ec350fc7b9c56e35ab3fd5fb"` [INFO] running `"docker" "rm" "-f" "b0854ef4d78661bfb6d611afdf277cabc583e305ec350fc7b9c56e35ab3fd5fb"` [INFO] [stdout] b0854ef4d78661bfb6d611afdf277cabc583e305ec350fc7b9c56e35ab3fd5fb