[INFO] crate huffman-rust 0.1.1 is already in cache
[INFO] extracting crate huffman-rust 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/huffman-rust/0.1.1
[INFO] extracting crate huffman-rust 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/huffman-rust/0.1.1
[INFO] validating manifest of huffman-rust-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of huffman-rust-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing huffman-rust-0.1.1
[INFO] finished frobbing huffman-rust-0.1.1
[INFO] frobbed toml for huffman-rust-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/huffman-rust/0.1.1/Cargo.toml
[INFO] started frobbing huffman-rust-0.1.1
[INFO] finished frobbing huffman-rust-0.1.1
[INFO] frobbed toml for huffman-rust-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/huffman-rust/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting huffman-rust-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/huffman-rust/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0596b7e040a8be30102f32bd9aa6b5aa63f6ed35cc4b506f503b26ce2ec1eec6
[INFO] running `"docker" "start" "-a" "0596b7e040a8be30102f32bd9aa6b5aa63f6ed35cc4b506f503b26ce2ec1eec6"`
[INFO] [stderr]     Checking huffman-rust v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/canonical.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |             mask = 1 << entry.length as u64 - 1;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (entry.length as u64 - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/canonical.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |             mask = 1 << entry.length as u64 - 1;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (entry.length as u64 - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/bitstream.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 | /             match self.read_next_byte()? {
[INFO] [stderr] 26 | |                 None => return Ok(None),
[INFO] [stderr] 27 | |                 _ => (),
[INFO] [stderr] 28 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let None = self.read_next_byte()? { return Ok(None) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/bitstream.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         self.write.write(&self.buf)?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/bitstream.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 | /             match self.read_next_byte()? {
[INFO] [stderr] 26 | |                 None => return Ok(None),
[INFO] [stderr] 27 | |                 _ => (),
[INFO] [stderr] 28 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let None = self.read_next_byte()? { return Ok(None) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/bitstream.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         self.write.write(&self.buf)?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/huffman.rs:109:12
[INFO] [stderr]     |
[INFO] [stderr] 109 |         if priority_queue.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `priority_queue.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/canonical.rs:79:18
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 .ok_or(format!("Symbol {} not found in code book", byte))?;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Symbol {} not found in code book", byte))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/canonical.rs:123:13
[INFO] [stderr]     |
[INFO] [stderr] 123 |             write.write(&buf)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/canonical.rs:133:23
[INFO] [stderr]     |
[INFO] [stderr] 133 |             offset -= entry.length as u64;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.length)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/canonical.rs:134:25
[INFO] [stderr]     |
[INFO] [stderr] 134 |             mask = 1 << entry.length as u64 - 1;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/canonical.rs:164:25
[INFO] [stderr]     |
[INFO] [stderr] 164 |     let mut mask = 1 << ((length - 1) as u64);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(length - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/canonical.rs:166:17
[INFO] [stderr]     |
[INFO] [stderr] 166 |     for _ in 0..(length as u64) {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try: `u64::from(length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/canonical.rs:182:14
[INFO] [stderr]     |
[INFO] [stderr] 182 |             .or_insert(Vec::new());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/canonical.rs:199:19
[INFO] [stderr]     |
[INFO] [stderr] 199 |     for (&length, &ref vec) in map.iter() {
[INFO] [stderr]     |                   ^^^^^^^^ help: try removing the `&ref` part and just keep: `vec`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_borrowed_reference)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/canonical.rs:203:14
[INFO] [stderr]     |
[INFO] [stderr] 203 |             .expect(&format!("No codes for length {}", length));
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No codes for length {}", length))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `code_buf`
[INFO] [stderr]   --> src/lib.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0..code_buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for (i, <item>) in code_buf.iter_mut().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/lib.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     write.write(&code_buf)?;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/huffman.rs:109:12
[INFO] [stderr]     |
[INFO] [stderr] 109 |         if priority_queue.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `priority_queue.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/canonical.rs:79:18
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 .ok_or(format!("Symbol {} not found in code book", byte))?;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Symbol {} not found in code book", byte))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `huffman-rust`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/canonical.rs:123:13
[INFO] [stderr]     |
[INFO] [stderr] 123 |             write.write(&buf)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/canonical.rs:133:23
[INFO] [stderr]     |
[INFO] [stderr] 133 |             offset -= entry.length as u64;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.length)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/canonical.rs:134:25
[INFO] [stderr]     |
[INFO] [stderr] 134 |             mask = 1 << entry.length as u64 - 1;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/canonical.rs:164:25
[INFO] [stderr]     |
[INFO] [stderr] 164 |     let mut mask = 1 << ((length - 1) as u64);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(length - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/canonical.rs:166:17
[INFO] [stderr]     |
[INFO] [stderr] 166 |     for _ in 0..(length as u64) {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try: `u64::from(length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/canonical.rs:182:14
[INFO] [stderr]     |
[INFO] [stderr] 182 |             .or_insert(Vec::new());
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]    --> src/canonical.rs:199:19
[INFO] [stderr]     |
[INFO] [stderr] 199 |     for (&length, &ref vec) in map.iter() {
[INFO] [stderr]     |                   ^^^^^^^^ help: try removing the `&ref` part and just keep: `vec`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_borrowed_reference)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/canonical.rs:203:14
[INFO] [stderr]     |
[INFO] [stderr] 203 |             .expect(&format!("No codes for length {}", length));
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No codes for length {}", length))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `code_buf`
[INFO] [stderr]   --> src/lib.rs:38:14
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for i in 0..code_buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for (i, <item>) in code_buf.iter_mut().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/lib.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     write.write(&code_buf)?;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `huffman-rust`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "0596b7e040a8be30102f32bd9aa6b5aa63f6ed35cc4b506f503b26ce2ec1eec6"`
[INFO] running `"docker" "rm" "-f" "0596b7e040a8be30102f32bd9aa6b5aa63f6ed35cc4b506f503b26ce2ec1eec6"`
[INFO] [stdout] 0596b7e040a8be30102f32bd9aa6b5aa63f6ed35cc4b506f503b26ce2ec1eec6