[INFO] crate httpcodec 0.2.2 is already in cache [INFO] extracting crate httpcodec 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/httpcodec/0.2.2 [INFO] extracting crate httpcodec 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/httpcodec/0.2.2 [INFO] validating manifest of httpcodec-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of httpcodec-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing httpcodec-0.2.2 [INFO] finished frobbing httpcodec-0.2.2 [INFO] frobbed toml for httpcodec-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/httpcodec/0.2.2/Cargo.toml [INFO] started frobbing httpcodec-0.2.2 [INFO] finished frobbing httpcodec-0.2.2 [INFO] frobbed toml for httpcodec-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/httpcodec/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting httpcodec-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/httpcodec/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0fcc26b3a1fbd4d9620d4a72dbbda93c5878b3ccfd482566103c61e2730ef37b [INFO] running `"docker" "start" "-a" "0fcc26b3a1fbd4d9620d4a72dbbda93c5878b3ccfd482566103c61e2730ef37b"` [INFO] [stderr] Checking bytecodec v0.4.11 [INFO] [stderr] Checking httpcodec v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/status.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn as_u16(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/status.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | pub(crate) fn as_bytes(&self) -> [u8; 3] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/version.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/chunked_body.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | / fn chunked_body_encoder_works() { [INFO] [stderr] 266 | | let mut body = U8Encoder::new().repeat(); [INFO] [stderr] 267 | | track_try_unwrap!(body.start_encoding((0..(1024 * 1024)).map(|_| b'a'))); [INFO] [stderr] 268 | | [INFO] [stderr] ... | [INFO] [stderr] 308 | | assert!(buf.iter().skip(6).all(|&b| b == b'a')); [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/status.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn as_u16(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/status.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | pub(crate) fn as_bytes(&self) -> [u8; 3] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/version.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.33s [INFO] running `"docker" "inspect" "0fcc26b3a1fbd4d9620d4a72dbbda93c5878b3ccfd482566103c61e2730ef37b"` [INFO] running `"docker" "rm" "-f" "0fcc26b3a1fbd4d9620d4a72dbbda93c5878b3ccfd482566103c61e2730ef37b"` [INFO] [stdout] 0fcc26b3a1fbd4d9620d4a72dbbda93c5878b3ccfd482566103c61e2730ef37b