[INFO] crate httpbox 0.1.0 is already in cache [INFO] extracting crate httpbox 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/httpbox/0.1.0 [INFO] extracting crate httpbox 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/httpbox/0.1.0 [INFO] validating manifest of httpbox-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of httpbox-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing httpbox-0.1.0 [INFO] finished frobbing httpbox-0.1.0 [INFO] frobbed toml for httpbox-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/httpbox/0.1.0/Cargo.toml [INFO] started frobbing httpbox-0.1.0 [INFO] finished frobbing httpbox-0.1.0 [INFO] frobbed toml for httpbox-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/httpbox/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting httpbox-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/httpbox/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d12cebffc0810e544118064c6bc61548fa6438593d4a1d5ce3b0f21a4347b744 [INFO] running `"docker" "start" "-a" "d12cebffc0810e544118064c6bc61548fa6438593d4a1d5ce3b0f21a4347b744"` [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking httpbox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | pub const ARG_URL: &'static str = "URL"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | pub const ARG_METHOD: &'static str = "method"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | pub const ARG_OUTPUT: &'static str = "output"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | pub const ARG_OUTPUT_DEFAULT: &'static str = "-"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | pub const ARG_VERBOSE: &'static str = "verbose"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | pub const ARG_QUIET: &'static str = "quiet"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return instance; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `instance` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return method; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return url; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return log_level_filter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `log_level_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | pub const ARG_URL: &'static str = "URL"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | pub const ARG_METHOD: &'static str = "method"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | pub const ARG_OUTPUT: &'static str = "output"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | pub const ARG_OUTPUT_DEFAULT: &'static str = "-"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | pub const ARG_VERBOSE: &'static str = "verbose"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | pub const ARG_QUIET: &'static str = "quiet"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return instance; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `instance` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return method; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return url; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return log_level_filter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `log_level_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/core.rs:12:49 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn borrow_mut_output_writer(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut Write` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cli::CLI<'a>` [INFO] [stderr] --> src/cli.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> CLI<'a> { [INFO] [stderr] 30 | | let instance = CLI { [INFO] [stderr] 31 | | arg_matches: build_arg_matches_from(&mut env::args_os()).unwrap_or_else(|clap_err| { [INFO] [stderr] 32 | | clap_err.exit() [INFO] [stderr] ... | [INFO] [stderr] 37 | | return instance; [INFO] [stderr] 38 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/core.rs:12:49 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn borrow_mut_output_writer(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut Write` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cli::CLI<'a>` [INFO] [stderr] --> src/cli.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> CLI<'a> { [INFO] [stderr] 30 | | let instance = CLI { [INFO] [stderr] 31 | | arg_matches: build_arg_matches_from(&mut env::args_os()).unwrap_or_else(|clap_err| { [INFO] [stderr] 32 | | clap_err.exit() [INFO] [stderr] ... | [INFO] [stderr] 37 | | return instance; [INFO] [stderr] 38 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.12s [INFO] running `"docker" "inspect" "d12cebffc0810e544118064c6bc61548fa6438593d4a1d5ce3b0f21a4347b744"` [INFO] running `"docker" "rm" "-f" "d12cebffc0810e544118064c6bc61548fa6438593d4a1d5ce3b0f21a4347b744"` [INFO] [stdout] d12cebffc0810e544118064c6bc61548fa6438593d4a1d5ce3b0f21a4347b744