[INFO] crate http_router 0.1.0 is already in cache [INFO] extracting crate http_router 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/http_router/0.1.0 [INFO] extracting crate http_router 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http_router/0.1.0 [INFO] validating manifest of http_router-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of http_router-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing http_router-0.1.0 [INFO] finished frobbing http_router-0.1.0 [INFO] frobbed toml for http_router-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/http_router/0.1.0/Cargo.toml [INFO] started frobbing http_router-0.1.0 [INFO] finished frobbing http_router-0.1.0 [INFO] frobbed toml for http_router-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http_router/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting http_router-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/http_router/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6a0655acce04ce31375e45965e618c34d7a8d64c0a5cde0d0027f79d636b63f [INFO] running `"docker" "start" "-a" "e6a0655acce04ce31375e45965e618c34d7a8d64c0a5cde0d0027f79d636b63f"` [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking http_router v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Closure called just once immediately after it was declared [INFO] [stderr] --> src/lib.rs:324:21 [INFO] [stderr] | [INFO] [stderr] 324 | result = closure(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 364 | let router = router!( [INFO] [stderr] | ______________________- [INFO] [stderr] 365 | | GET / => get_users, [INFO] [stderr] 366 | | GET /users => get_users, [INFO] [stderr] 367 | | POST /users => post_users, [INFO] [stderr] ... | [INFO] [stderr] 374 | | _ => fallback, [INFO] [stderr] 375 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Closure called just once immediately after it was declared [INFO] [stderr] --> src/lib.rs:324:21 [INFO] [stderr] | [INFO] [stderr] 324 | result = closure(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 364 | let router = router!( [INFO] [stderr] | ______________________- [INFO] [stderr] 365 | | GET / => get_users, [INFO] [stderr] 366 | | GET /users => get_users, [INFO] [stderr] 367 | | POST /users => post_users, [INFO] [stderr] ... | [INFO] [stderr] 374 | | _ => fallback, [INFO] [stderr] 375 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Closure called just once immediately after it was declared [INFO] [stderr] --> src/lib.rs:324:21 [INFO] [stderr] | [INFO] [stderr] 324 | result = closure(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 446 | let router = router!( [INFO] [stderr] | ______________________- [INFO] [stderr] 447 | | GET / => home, [INFO] [stderr] 448 | | POST /users => users, [INFO] [stderr] 449 | | _ => fallback [INFO] [stderr] 450 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Closure called just once immediately after it was declared [INFO] [stderr] --> src/lib.rs:304:21 [INFO] [stderr] | [INFO] [stderr] 304 | result = closure(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 470 | let router = router!( [INFO] [stderr] | ______________________- [INFO] [stderr] 471 | | GET /users => get_test, [INFO] [stderr] 472 | | POST /users => post_test, [INFO] [stderr] 473 | | PUT /users => put_test, [INFO] [stderr] ... | [INFO] [stderr] 480 | | _ => panic_test [INFO] [stderr] 481 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Closure called just once immediately after it was declared [INFO] [stderr] --> src/lib.rs:304:21 [INFO] [stderr] | [INFO] [stderr] 304 | result = closure(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 520 | let router = router!( [INFO] [stderr] | ______________________- [INFO] [stderr] 521 | | GET /users => zero, [INFO] [stderr] 522 | | GET /users/{p1: String} => one, [INFO] [stderr] 523 | | GET /users/{p1: String}/users2/{p2: String} => two, [INFO] [stderr] ... | [INFO] [stderr] 529 | | _ => unreachable, [INFO] [stderr] 530 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:407:37 [INFO] [stderr] | [INFO] [stderr] 407 | for test_case in test_cases.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:408:44 [INFO] [stderr] | [INFO] [stderr] 408 | let (method, path, expected) = test_case.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*test_case` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:409:35 [INFO] [stderr] | [INFO] [stderr] 409 | assert_eq!(router((), method.clone(), path), expected.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:419:43 [INFO] [stderr] | [INFO] [stderr] 419 | assert_eq!(router((), method.clone(), path), expected.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:497:40 [INFO] [stderr] | [INFO] [stderr] 497 | let one = |_: &(), p1: String| format!("{}", &p1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&p1.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `http_router`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e6a0655acce04ce31375e45965e618c34d7a8d64c0a5cde0d0027f79d636b63f"` [INFO] running `"docker" "rm" "-f" "e6a0655acce04ce31375e45965e618c34d7a8d64c0a5cde0d0027f79d636b63f"` [INFO] [stdout] e6a0655acce04ce31375e45965e618c34d7a8d64c0a5cde0d0027f79d636b63f