[INFO] crate http_parser 0.0.2 is already in cache [INFO] extracting crate http_parser 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/http_parser/0.0.2 [INFO] extracting crate http_parser 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http_parser/0.0.2 [INFO] validating manifest of http_parser-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of http_parser-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing http_parser-0.0.2 [INFO] finished frobbing http_parser-0.0.2 [INFO] frobbed toml for http_parser-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/http_parser/0.0.2/Cargo.toml [INFO] started frobbing http_parser-0.0.2 [INFO] finished frobbing http_parser-0.0.2 [INFO] frobbed toml for http_parser-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http_parser/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting http_parser-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/http_parser/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c788d795ef0ae714da92743b5a4b2dbd0e49ef381d818753df4875caa63bef22 [INFO] running `"docker" "start" "-a" "c788d795ef0ae714da92743b5a4b2dbd0e49ef381d818753df4875caa63bef22"` [INFO] [stderr] Checking http_parser v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | tp: tp, [INFO] [stderr] | ^^^^^^ help: replace it with: `tp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | tp: tp, [INFO] [stderr] | ^^^^^^ help: replace it with: `tp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | const PROXY_CONNECTION: &'static str = "proxy-connection"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | const CONNECTION: &'static str = "connection"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | const CONTENT_LENGTH: &'static str = "content-length"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:123:27 [INFO] [stderr] | [INFO] [stderr] 123 | const TRANSFER_ENCODING: &'static str = "transfer-encoding"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | const UPGRADE: &'static str = "upgrade"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | const CHUNKED: &'static str = "chunked"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | const KEEP_ALIVE: &'static str = "keep-alive"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:127:15 [INFO] [stderr] | [INFO] [stderr] 127 | const CLOSE: &'static str = "close"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:1165:32 [INFO] [stderr] | [INFO] [stderr] 1165 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 1166 | | if self.content_length == 0 { [INFO] [stderr] 1167 | | // Content-Length header given but zero: Content-Length: 0\r\n [INFO] [stderr] 1168 | | self.new_message(); [INFO] [stderr] ... | [INFO] [stderr] 1185 | | } [INFO] [stderr] 1186 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1165 | } else if self.content_length == 0 { [INFO] [stderr] 1166 | // Content-Length header given but zero: Content-Length: 0\r\n [INFO] [stderr] 1167 | self.new_message(); [INFO] [stderr] 1168 | callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1169 | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] 1170 | } else if self.content_length != ULLONG_MAX { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:1174:36 [INFO] [stderr] | [INFO] [stderr] 1174 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 1175 | | if self.tp == HttpParserType::Request || [INFO] [stderr] 1176 | | !self.http_message_needs_eof() { [INFO] [stderr] 1177 | | // Assume content-length 0 - read the next [INFO] [stderr] ... | [INFO] [stderr] 1184 | | } [INFO] [stderr] 1185 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1174 | } else if self.tp == HttpParserType::Request || [INFO] [stderr] 1175 | !self.http_message_needs_eof() { [INFO] [stderr] 1176 | // Assume content-length 0 - read the next [INFO] [stderr] 1177 | self.new_message(); [INFO] [stderr] 1178 | callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1179 | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:1502:9 [INFO] [stderr] | [INFO] [stderr] 1502 | return State::Dead; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `State::Dead` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | const PROXY_CONNECTION: &'static str = "proxy-connection"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | const CONNECTION: &'static str = "connection"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | const CONTENT_LENGTH: &'static str = "content-length"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:123:27 [INFO] [stderr] | [INFO] [stderr] 123 | const TRANSFER_ENCODING: &'static str = "transfer-encoding"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | const UPGRADE: &'static str = "upgrade"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | const CHUNKED: &'static str = "chunked"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | const KEEP_ALIVE: &'static str = "keep-alive"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:127:15 [INFO] [stderr] | [INFO] [stderr] 127 | const CLOSE: &'static str = "close"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:1165:32 [INFO] [stderr] | [INFO] [stderr] 1165 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 1166 | | if self.content_length == 0 { [INFO] [stderr] 1167 | | // Content-Length header given but zero: Content-Length: 0\r\n [INFO] [stderr] 1168 | | self.new_message(); [INFO] [stderr] ... | [INFO] [stderr] 1185 | | } [INFO] [stderr] 1186 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1165 | } else if self.content_length == 0 { [INFO] [stderr] 1166 | // Content-Length header given but zero: Content-Length: 0\r\n [INFO] [stderr] 1167 | self.new_message(); [INFO] [stderr] 1168 | callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1169 | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] 1170 | } else if self.content_length != ULLONG_MAX { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:1174:36 [INFO] [stderr] | [INFO] [stderr] 1174 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 1175 | | if self.tp == HttpParserType::Request || [INFO] [stderr] 1176 | | !self.http_message_needs_eof() { [INFO] [stderr] 1177 | | // Assume content-length 0 - read the next [INFO] [stderr] ... | [INFO] [stderr] 1184 | | } [INFO] [stderr] 1185 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1174 | } else if self.tp == HttpParserType::Request || [INFO] [stderr] 1175 | !self.http_message_needs_eof() { [INFO] [stderr] 1176 | // Assume content-length 0 - read the next [INFO] [stderr] 1177 | self.new_message(); [INFO] [stderr] 1178 | callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1179 | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:1502:9 [INFO] [stderr] | [INFO] [stderr] 1502 | return State::Dead; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `State::Dead` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:155:22 [INFO] [stderr] | [INFO] [stderr] 155 | Option::Some((ch - b'0') as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | Option::Some((10 + ch - b'a') as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(10 + ch - b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | Option::Some((10 + ch - b'A') as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(10 + ch - b'A')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 225 [INFO] [stderr] --> src/parser.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | / pub fn execute(&mut self, cb: &mut T, data: &[u8]) -> usize { [INFO] [stderr] 247 | | let len: usize = data.len(); [INFO] [stderr] 248 | | let mut index: usize = 0; [INFO] [stderr] 249 | | let mut header_field_mark: Option = Option::None; [INFO] [stderr] ... | [INFO] [stderr] 1361 | | len [INFO] [stderr] 1362 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 262 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 263 | | HttpErrno::CBMessageComplete, index); [INFO] [stderr] | |___________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ help: try this: `if let Err(..) = cb.on_message_begin(self) { callback!(self, cb.on_message_begin(self), HttpErrno::CBMessageBegin, index+1); }` [INFO] [stderr] ... [INFO] [stderr] 342 | callback!(self, cb.on_message_begin(self), HttpErrno::CBMessageBegin, index+1); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ help: try this: `if let Err(..) = cb.on_message_begin(self) { callback!(self, cb.on_message_begin(self), HttpErrno::CBMessageBegin, index+1); }` [INFO] [stderr] ... [INFO] [stderr] 379 | callback!(self, cb.on_message_begin(self), HttpErrno::CBMessageBegin, index+1); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:458:61 [INFO] [stderr] | [INFO] [stderr] 458 | self.status_code = Option::Some((ch - b'0') as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:476:44 [INFO] [stderr] | [INFO] [stderr] 476 | status_code += (ch - b'0') as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 500 | / callback!(self, [INFO] [stderr] 501 | | cb.on_status(self, &data[status_mark.unwrap() .. index]), [INFO] [stderr] 502 | | HttpErrno::CBStatus, index+1); [INFO] [stderr] | |__________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_status(self, &data[status_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_status(self, &data[status_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBStatus, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 543 | / callback!(self, cb.on_message_begin(self), [INFO] [stderr] 544 | | HttpErrno::CBMessageBegin, index+1); [INFO] [stderr] | |__________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_begin(self) { callback!(self, cb.on_message_begin(self), [INFO] [stderr] 85 | HttpErrno::CBMessageBegin, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 667 | / callback!(self, [INFO] [stderr] 668 | | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 669 | | HttpErrno::CBUrl, index+1); [INFO] [stderr] | |___________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_url(self, &data[url_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBUrl, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 682 | / callback!(self, [INFO] [stderr] 683 | | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 684 | | HttpErrno::CBUrl, index+1); [INFO] [stderr] | |___________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_url(self, &data[url_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBUrl, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 913 | / callback!(self, [INFO] [stderr] 914 | | cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]), [INFO] [stderr] 915 | | HttpErrno::CBHeaderField, index+1); [INFO] [stderr] | |_______________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderField, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:961:55 [INFO] [stderr] | [INFO] [stderr] 961 | self.content_length = (ch - b'0') as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 981 | / callback!(self, [INFO] [stderr] 982 | | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 983 | | HttpErrno::CBHeaderValue, index+1); [INFO] [stderr] | |_______________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderValue, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 989 | / callback!(self, [INFO] [stderr] 990 | | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 991 | | HttpErrno::CBHeaderValue, index); [INFO] [stderr] | |_____________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderValue, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:1019:46 [INFO] [stderr] | [INFO] [stderr] 1019 | t += (ch - b'0') as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1107 | / callback!(self, [INFO] [stderr] 1108 | | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 1109 | | HttpErrno::CBHeaderValue, index); [INFO] [stderr] | |_____________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderValue, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1121 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1122 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_____________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1153 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1154 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_____________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1160 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1161 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_____________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1169 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1170 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1179 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1180 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_____________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1203 | / callback!(self, [INFO] [stderr] 1204 | | cb.on_body(self, &data[body_mark.unwrap() .. (index + 1)]), [INFO] [stderr] 1205 | | HttpErrno::CBBody, index); [INFO] [stderr] | |______________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_body(self, &data[body_mark.unwrap() .. (index + 1)]) { callback!(self, [INFO] [stderr] 85 | cb.on_body(self, &data[body_mark.unwrap() .. (index + 1)]), [INFO] [stderr] 86 | HttpErrno::CBBody, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser.rs:1204:60 [INFO] [stderr] | [INFO] [stderr] 1204 | cb.on_body(self, &data[body_mark.unwrap() .. (index + 1)]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `body_mark.unwrap()..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1218 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1219 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1305 | / callback!(self, [INFO] [stderr] 1306 | | cb.on_body(self, &data[body_mark.unwrap() .. index]), [INFO] [stderr] 1307 | | HttpErrno::CBBody, index+1); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_body(self, &data[body_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_body(self, &data[body_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBBody, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1337 | / callback!(self, [INFO] [stderr] 1338 | | cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]), [INFO] [stderr] 1339 | | HttpErrno::CBHeaderField, index); [INFO] [stderr] | |_________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderField, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1342 | / callback!(self, [INFO] [stderr] 1343 | | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 1344 | | HttpErrno::CBHeaderValue, index); [INFO] [stderr] | |_________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderValue, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1347 | / callback!(self, [INFO] [stderr] 1348 | | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 1349 | | HttpErrno::CBUrl, index); [INFO] [stderr] | |_________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_url(self, &data[url_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBUrl, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1352 | / callback!(self, [INFO] [stderr] 1353 | | cb.on_body(self, &data[body_mark.unwrap() .. index]), [INFO] [stderr] 1354 | | HttpErrno::CBBody, index); [INFO] [stderr] | |__________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_body(self, &data[body_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_body(self, &data[body_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBBody, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1357 | / callback!(self, [INFO] [stderr] 1358 | | cb.on_status(self, &data[status_mark.unwrap() .. index]), [INFO] [stderr] 1359 | | HttpErrno::CBStatus, index); [INFO] [stderr] | |____________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_status(self, &data[status_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_status(self, &data[status_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBStatus, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1isize` [INFO] [stderr] --> src/flags.rs:2:31 [INFO] [stderr] | [INFO] [stderr] 2 | Chunked = 1isize << 0, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/flags.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn as_u8(self) -> u8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:155:22 [INFO] [stderr] | [INFO] [stderr] 155 | Option::Some((ch - b'0') as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | Option::Some((10 + ch - b'a') as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(10 + ch - b'a')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | Option::Some((10 + ch - b'A') as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(10 + ch - b'A')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 225 [INFO] [stderr] --> src/parser.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | / pub fn execute(&mut self, cb: &mut T, data: &[u8]) -> usize { [INFO] [stderr] 247 | | let len: usize = data.len(); [INFO] [stderr] 248 | | let mut index: usize = 0; [INFO] [stderr] 249 | | let mut header_field_mark: Option = Option::None; [INFO] [stderr] ... | [INFO] [stderr] 1361 | | len [INFO] [stderr] 1362 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 262 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 263 | | HttpErrno::CBMessageComplete, index); [INFO] [stderr] | |___________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ help: try this: `if let Err(..) = cb.on_message_begin(self) { callback!(self, cb.on_message_begin(self), HttpErrno::CBMessageBegin, index+1); }` [INFO] [stderr] ... [INFO] [stderr] 342 | callback!(self, cb.on_message_begin(self), HttpErrno::CBMessageBegin, index+1); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ help: try this: `if let Err(..) = cb.on_message_begin(self) { callback!(self, cb.on_message_begin(self), HttpErrno::CBMessageBegin, index+1); }` [INFO] [stderr] ... [INFO] [stderr] 379 | callback!(self, cb.on_message_begin(self), HttpErrno::CBMessageBegin, index+1); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:458:61 [INFO] [stderr] | [INFO] [stderr] 458 | self.status_code = Option::Some((ch - b'0') as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:476:44 [INFO] [stderr] | [INFO] [stderr] 476 | status_code += (ch - b'0') as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 500 | / callback!(self, [INFO] [stderr] 501 | | cb.on_status(self, &data[status_mark.unwrap() .. index]), [INFO] [stderr] 502 | | HttpErrno::CBStatus, index+1); [INFO] [stderr] | |__________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_status(self, &data[status_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_status(self, &data[status_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBStatus, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 543 | / callback!(self, cb.on_message_begin(self), [INFO] [stderr] 544 | | HttpErrno::CBMessageBegin, index+1); [INFO] [stderr] | |__________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_begin(self) { callback!(self, cb.on_message_begin(self), [INFO] [stderr] 85 | HttpErrno::CBMessageBegin, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 667 | / callback!(self, [INFO] [stderr] 668 | | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 669 | | HttpErrno::CBUrl, index+1); [INFO] [stderr] | |___________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_url(self, &data[url_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBUrl, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 682 | / callback!(self, [INFO] [stderr] 683 | | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 684 | | HttpErrno::CBUrl, index+1); [INFO] [stderr] | |___________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_url(self, &data[url_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBUrl, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 913 | / callback!(self, [INFO] [stderr] 914 | | cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]), [INFO] [stderr] 915 | | HttpErrno::CBHeaderField, index+1); [INFO] [stderr] | |_______________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderField, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:961:55 [INFO] [stderr] | [INFO] [stderr] 961 | self.content_length = (ch - b'0') as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 981 | / callback!(self, [INFO] [stderr] 982 | | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 983 | | HttpErrno::CBHeaderValue, index+1); [INFO] [stderr] | |_______________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderValue, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 989 | / callback!(self, [INFO] [stderr] 990 | | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 991 | | HttpErrno::CBHeaderValue, index); [INFO] [stderr] | |_____________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderValue, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:1019:46 [INFO] [stderr] | [INFO] [stderr] 1019 | t += (ch - b'0') as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1107 | / callback!(self, [INFO] [stderr] 1108 | | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 1109 | | HttpErrno::CBHeaderValue, index); [INFO] [stderr] | |_____________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderValue, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1121 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1122 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_____________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1153 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1154 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_____________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1160 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1161 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_____________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1169 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1170 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1179 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1180 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_____________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1203 | / callback!(self, [INFO] [stderr] 1204 | | cb.on_body(self, &data[body_mark.unwrap() .. (index + 1)]), [INFO] [stderr] 1205 | | HttpErrno::CBBody, index); [INFO] [stderr] | |______________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_body(self, &data[body_mark.unwrap() .. (index + 1)]) { callback!(self, [INFO] [stderr] 85 | cb.on_body(self, &data[body_mark.unwrap() .. (index + 1)]), [INFO] [stderr] 86 | HttpErrno::CBBody, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser.rs:1204:60 [INFO] [stderr] | [INFO] [stderr] 1204 | cb.on_body(self, &data[body_mark.unwrap() .. (index + 1)]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `body_mark.unwrap()..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1218 | / callback!(self, cb.on_message_complete(self), [INFO] [stderr] 1219 | | HttpErrno::CBMessageComplete, index+1); [INFO] [stderr] | |_________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_message_complete(self) { callback!(self, cb.on_message_complete(self), [INFO] [stderr] 85 | HttpErrno::CBMessageComplete, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1305 | / callback!(self, [INFO] [stderr] 1306 | | cb.on_body(self, &data[body_mark.unwrap() .. index]), [INFO] [stderr] 1307 | | HttpErrno::CBBody, index+1); [INFO] [stderr] | |____________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_body(self, &data[body_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_body(self, &data[body_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBBody, index+1); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1337 | / callback!(self, [INFO] [stderr] 1338 | | cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]), [INFO] [stderr] 1339 | | HttpErrno::CBHeaderField, index); [INFO] [stderr] | |_________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_field(self, &data[header_field_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderField, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1342 | / callback!(self, [INFO] [stderr] 1343 | | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 1344 | | HttpErrno::CBHeaderValue, index); [INFO] [stderr] | |_________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_header_value(self, &data[header_value_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBHeaderValue, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1347 | / callback!(self, [INFO] [stderr] 1348 | | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 1349 | | HttpErrno::CBUrl, index); [INFO] [stderr] | |_________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_url(self, &data[url_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_url(self, &data[url_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBUrl, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1352 | / callback!(self, [INFO] [stderr] 1353 | | cb.on_body(self, &data[body_mark.unwrap() .. index]), [INFO] [stderr] 1354 | | HttpErrno::CBBody, index); [INFO] [stderr] | |__________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_body(self, &data[body_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_body(self, &data[body_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBBody, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | / match $cb { [INFO] [stderr] 85 | | Err(..) => $parser.errno = Option::Some($err), [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | } [INFO] [stderr] | |________^ [INFO] [stderr] ... [INFO] [stderr] 1357 | / callback!(self, [INFO] [stderr] 1358 | | cb.on_status(self, &data[status_mark.unwrap() .. index]), [INFO] [stderr] 1359 | | HttpErrno::CBStatus, index); [INFO] [stderr] | |____________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Err(..) = cb.on_status(self, &data[status_mark.unwrap() .. index]) { callback!(self, [INFO] [stderr] 85 | cb.on_status(self, &data[status_mark.unwrap() .. index]), [INFO] [stderr] 86 | HttpErrno::CBStatus, index); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1isize` [INFO] [stderr] --> src/flags.rs:2:31 [INFO] [stderr] | [INFO] [stderr] 2 | Chunked = 1isize << 0, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/flags.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn as_u8(self) -> u8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> tests/helper.rs:844:5 [INFO] [stderr] | [INFO] [stderr] 844 | print!("i={} j={}\n", i, j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> tests/helper.rs:844:5 [INFO] [stderr] | [INFO] [stderr] 844 | print!("i={} j={}\n", i, j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> tests/helper.rs:844:5 [INFO] [stderr] | [INFO] [stderr] 844 | print!("i={} j={}\n", i, j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> tests/helper.rs:844:5 [INFO] [stderr] | [INFO] [stderr] 844 | print!("i={} j={}\n", i, j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> tests/helper.rs:844:5 [INFO] [stderr] | [INFO] [stderr] 844 | print!("i={} j={}\n", i, j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> tests/helper.rs:844:5 [INFO] [stderr] | [INFO] [stderr] 844 | print!("i={} j={}\n", i, j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> tests/helper.rs:844:5 [INFO] [stderr] | [INFO] [stderr] 844 | print!("i={} j={}\n", i, j); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:607:14 [INFO] [stderr] | [INFO] [stderr] 607 | for _ in (0..error_location_line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:644:14 [INFO] [stderr] | [INFO] [stderr] 644 | for i in (0..actual.headers.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:655:14 [INFO] [stderr] | [INFO] [stderr] 655 | for i in (0..raw_len) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:864:18 [INFO] [stderr] | [INFO] [stderr] 864 | for j in (2..total_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | for i in (1..j) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:882:24 [INFO] [stderr] | [INFO] [stderr] 882 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 883 | | if read != buf1.len() { [INFO] [stderr] 884 | | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 885 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 886 | | } [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 882 | } else if read != buf1.len() { [INFO] [stderr] 883 | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 884 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 885 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:894:28 [INFO] [stderr] | [INFO] [stderr] 894 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 895 | | if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 896 | | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 897 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 894 | } else if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 895 | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 896 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 897 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:907:28 [INFO] [stderr] | [INFO] [stderr] 907 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 908 | | if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 909 | | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 910 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 911 | | } [INFO] [stderr] 912 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 907 | } else if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 908 | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 909 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 910 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:607:14 [INFO] [stderr] | [INFO] [stderr] 607 | for _ in (0..error_location_line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:644:14 [INFO] [stderr] | [INFO] [stderr] 644 | for i in (0..actual.headers.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:655:14 [INFO] [stderr] | [INFO] [stderr] 655 | for i in (0..raw_len) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:864:18 [INFO] [stderr] | [INFO] [stderr] 864 | for j in (2..total_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | for i in (1..j) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:882:24 [INFO] [stderr] | [INFO] [stderr] 882 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 883 | | if read != buf1.len() { [INFO] [stderr] 884 | | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 885 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 886 | | } [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 882 | } else if read != buf1.len() { [INFO] [stderr] 883 | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 884 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 885 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:894:28 [INFO] [stderr] | [INFO] [stderr] 894 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 895 | | if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 896 | | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 897 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 894 | } else if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 895 | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 896 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 897 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:907:28 [INFO] [stderr] | [INFO] [stderr] 907 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 908 | | if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 909 | | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 910 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 911 | | } [INFO] [stderr] 912 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 907 | } else if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 908 | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 909 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 910 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_long_body.rs:10:57 [INFO] [stderr] | [INFO] [stderr] 10 | test_no_overflow_long_body(HttpParserType::Request, 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/test_long_body.rs:16:58 [INFO] [stderr] | [INFO] [stderr] 16 | test_no_overflow_long_body(HttpParserType::Response, 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/test_long_body.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | for _ in (0..length) { [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:607:14 [INFO] [stderr] | [INFO] [stderr] 607 | for _ in (0..error_location_line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:644:14 [INFO] [stderr] | [INFO] [stderr] 644 | for i in (0..actual.headers.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:655:14 [INFO] [stderr] | [INFO] [stderr] 655 | for i in (0..raw_len) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:864:18 [INFO] [stderr] | [INFO] [stderr] 864 | for j in (2..total_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | for i in (1..j) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:882:24 [INFO] [stderr] | [INFO] [stderr] 882 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 883 | | if read != buf1.len() { [INFO] [stderr] 884 | | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 885 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 886 | | } [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 882 | } else if read != buf1.len() { [INFO] [stderr] 883 | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 884 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 885 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:894:28 [INFO] [stderr] | [INFO] [stderr] 894 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 895 | | if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 896 | | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 897 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 894 | } else if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 895 | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 896 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 897 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:907:28 [INFO] [stderr] | [INFO] [stderr] 907 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 908 | | if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 909 | | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 910 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 911 | | } [INFO] [stderr] 912 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 907 | } else if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 908 | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 909 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 910 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:607:14 [INFO] [stderr] | [INFO] [stderr] 607 | for _ in (0..error_location_line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:644:14 [INFO] [stderr] | [INFO] [stderr] 644 | for i in (0..actual.headers.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:655:14 [INFO] [stderr] | [INFO] [stderr] 655 | for i in (0..raw_len) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:864:18 [INFO] [stderr] | [INFO] [stderr] 864 | for j in (2..total_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | for i in (1..j) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:882:24 [INFO] [stderr] | [INFO] [stderr] 882 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 883 | | if read != buf1.len() { [INFO] [stderr] 884 | | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 885 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 886 | | } [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 882 | } else if read != buf1.len() { [INFO] [stderr] 883 | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 884 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 885 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:894:28 [INFO] [stderr] | [INFO] [stderr] 894 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 895 | | if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 896 | | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 897 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 894 | } else if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 895 | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 896 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 897 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:907:28 [INFO] [stderr] | [INFO] [stderr] 907 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 908 | | if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 909 | | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 910 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 911 | | } [INFO] [stderr] 912 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 907 | } else if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 908 | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 909 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 910 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/test_header.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | const HEADER_LINE : &'static str = "header-key: header-value\r\n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw` [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in raw.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/helper.rs:716:11 [INFO] [stderr] | [INFO] [stderr] 716 | while raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:607:14 [INFO] [stderr] | [INFO] [stderr] 607 | for _ in (0..error_location_line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:644:14 [INFO] [stderr] | [INFO] [stderr] 644 | for i in (0..actual.headers.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:655:14 [INFO] [stderr] | [INFO] [stderr] 655 | for i in (0..raw_len) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:864:18 [INFO] [stderr] | [INFO] [stderr] 864 | for j in (2..total_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | for i in (1..j) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:882:24 [INFO] [stderr] | [INFO] [stderr] 882 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 883 | | if read != buf1.len() { [INFO] [stderr] 884 | | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 885 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 886 | | } [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 882 | } else if read != buf1.len() { [INFO] [stderr] 883 | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 884 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 885 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:894:28 [INFO] [stderr] | [INFO] [stderr] 894 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 895 | | if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 896 | | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 897 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 894 | } else if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 895 | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 896 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 897 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:907:28 [INFO] [stderr] | [INFO] [stderr] 907 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 908 | | if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 909 | | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 910 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 911 | | } [INFO] [stderr] 912 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 907 | } else if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 908 | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 909 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 910 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:607:14 [INFO] [stderr] | [INFO] [stderr] 607 | for _ in (0..error_location_line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:644:14 [INFO] [stderr] | [INFO] [stderr] 644 | for i in (0..actual.headers.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:655:14 [INFO] [stderr] | [INFO] [stderr] 655 | for i in (0..raw_len) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:864:18 [INFO] [stderr] | [INFO] [stderr] 864 | for j in (2..total_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | for i in (1..j) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:882:24 [INFO] [stderr] | [INFO] [stderr] 882 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 883 | | if read != buf1.len() { [INFO] [stderr] 884 | | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 885 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 886 | | } [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 882 | } else if read != buf1.len() { [INFO] [stderr] 883 | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 884 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 885 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:894:28 [INFO] [stderr] | [INFO] [stderr] 894 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 895 | | if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 896 | | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 897 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 894 | } else if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 895 | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 896 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 897 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:907:28 [INFO] [stderr] | [INFO] [stderr] 907 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 908 | | if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 909 | | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 910 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 911 | | } [INFO] [stderr] 912 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 907 | } else if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 908 | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 909 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 910 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/test_responses.rs:777:14 [INFO] [stderr] | [INFO] [stderr] 777 | for _ in (0..body_size_in_kb) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/test_responses.rs:779:18 [INFO] [stderr] | [INFO] [stderr] 779 | for _ in (0u32..1024u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:607:14 [INFO] [stderr] | [INFO] [stderr] 607 | for _ in (0..error_location_line) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:644:14 [INFO] [stderr] | [INFO] [stderr] 644 | for i in (0..actual.headers.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:655:14 [INFO] [stderr] | [INFO] [stderr] 655 | for i in (0..raw_len) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw` [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in raw.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:864:18 [INFO] [stderr] | [INFO] [stderr] 864 | for j in (2..total_len) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> tests/helper.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | for i in (1..j) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:882:24 [INFO] [stderr] | [INFO] [stderr] 882 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 883 | | if read != buf1.len() { [INFO] [stderr] 884 | | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 885 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 886 | | } [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 882 | } else if read != buf1.len() { [INFO] [stderr] 883 | print_error(hp.errno.unwrap(), buf1, read); [INFO] [stderr] 884 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 885 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:894:28 [INFO] [stderr] | [INFO] [stderr] 894 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 895 | | if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 896 | | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 897 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 898 | | } [INFO] [stderr] 899 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 894 | } else if read != (buf1.len() + buf2.len()) { [INFO] [stderr] 895 | print_error(hp.errno.unwrap(), buf2, read); [INFO] [stderr] 896 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 897 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> tests/helper.rs:907:28 [INFO] [stderr] | [INFO] [stderr] 907 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 908 | | if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 909 | | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 910 | | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 911 | | } [INFO] [stderr] 912 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 907 | } else if read != (buf1.len() + buf2.len() + buf3.len()) { [INFO] [stderr] 908 | print_error(hp.errno.unwrap(), buf3, read); [INFO] [stderr] 909 | print_test_scan_error(i, j, buf1, buf2, buf3); [INFO] [stderr] 910 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw` [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in raw.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/helper.rs:716:11 [INFO] [stderr] | [INFO] [stderr] 716 | while raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw` [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in raw.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/helper.rs:716:11 [INFO] [stderr] | [INFO] [stderr] 716 | while raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/helper.rs:716:11 [INFO] [stderr] | [INFO] [stderr] 716 | while raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> tests/test_requests.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / fn test_requests() { [INFO] [stderr] 11 | | test_simple("GET / HTP/1.1\r\n\r\n", Option::Some(HttpErrno::InvalidVersion)); [INFO] [stderr] 12 | | [INFO] [stderr] 13 | | // Well-formed but incomplete [INFO] [stderr] ... | [INFO] [stderr] 1148 | | &requests[CONNECT_REQUEST]); [INFO] [stderr] 1149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | for b in "/test".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/test"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:173:26 [INFO] [stderr] | [INFO] [stderr] 173 | for b in "/favicon.ico".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/favicon.ico"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | for b in "/dumbfuck".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/dumbfuck"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:231:26 [INFO] [stderr] | [INFO] [stderr] 231 | for b in "/forums/1/topics/2375?page=1#posts-17408".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/forums/1/topics/2375?page=1#posts-17408"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:253:26 [INFO] [stderr] | [INFO] [stderr] 253 | for b in "/get_no_headers_no_body/world".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/get_no_headers_no_body/world"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:276:26 [INFO] [stderr] | [INFO] [stderr] 276 | for b in "/get_one_header_no_body/world".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/get_one_header_no_body/world"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:303:26 [INFO] [stderr] | [INFO] [stderr] 303 | for b in "/get_funky_content_length_body_hello".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/get_funky_content_length_body_hello"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:332:26 [INFO] [stderr] | [INFO] [stderr] 332 | for b in "/post_chunked_all_your_base".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/post_chunked_all_your_base"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:362:26 [INFO] [stderr] | [INFO] [stderr] 362 | for b in "/two_chunks_mult_zero_end".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/two_chunks_mult_zero_end"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:394:26 [INFO] [stderr] | [INFO] [stderr] 394 | for b in "/chunked_w_trailing_headers".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/chunked_w_trailing_headers"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:426:26 [INFO] [stderr] | [INFO] [stderr] 426 | for b in "/chunked_w_bullshit_after_length".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/chunked_w_bullshit_after_length"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:476:26 [INFO] [stderr] | [INFO] [stderr] 476 | for b in "/test".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:503:26 [INFO] [stderr] | [INFO] [stderr] 503 | for b in "/test.cgi?foo=bar?baz".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/test.cgi?foo=bar?baz"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:525:26 [INFO] [stderr] | [INFO] [stderr] 525 | for b in "/test".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:555:26 [INFO] [stderr] | [INFO] [stderr] 555 | for b in "/demo".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/demo"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:591:26 [INFO] [stderr] | [INFO] [stderr] 591 | for b in "0-home0.netscape.com:443".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0-home0.netscape.com:443"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:618:26 [INFO] [stderr] | [INFO] [stderr] 618 | for b in "/test".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:720:26 [INFO] [stderr] | [INFO] [stderr] 720 | for b in "http://hypnotoad.org?hail=all".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"http://hypnotoad.org?hail=all"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:743:26 [INFO] [stderr] | [INFO] [stderr] 743 | for b in "http://hypnotoad.org:1234?hail=all".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"http://hypnotoad.org:1234?hail=all"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:767:26 [INFO] [stderr] | [INFO] [stderr] 767 | for b in "http://hypnotoad.org:1234".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"http://hypnotoad.org:1234"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:796:26 [INFO] [stderr] | [INFO] [stderr] 796 | for b in "/file.txt".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/file.txt"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:826:26 [INFO] [stderr] | [INFO] [stderr] 826 | for b in "HOME0.NETSCAPE.COM:443".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"HOME0.NETSCAPE.COM:443"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:883:26 [INFO] [stderr] | [INFO] [stderr] 883 | for b in "home_0.netscape.com:443".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"home_0.netscape.com:443"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:969:26 [INFO] [stderr] | [INFO] [stderr] 969 | for b in "/file.txt".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/file.txt"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:1018:26 [INFO] [stderr] | [INFO] [stderr] 1018 | for b in "http://a%12:b!&*$@hypnotoad.org:1234/toto".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"http://a%12:b!&*$@hypnotoad.org:1234/toto"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_requests.rs:1083:26 [INFO] [stderr] | [INFO] [stderr] 1083 | for b in "/demo".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/demo"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw` [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in raw.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/helper.rs:716:11 [INFO] [stderr] | [INFO] [stderr] 716 | while raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw` [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in raw.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/helper.rs:716:11 [INFO] [stderr] | [INFO] [stderr] 716 | while raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw` [INFO] [stderr] --> tests/helper.rs:577:14 [INFO] [stderr] | [INFO] [stderr] 577 | for i in (0..len ) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in raw.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/helper.rs:716:11 [INFO] [stderr] | [INFO] [stderr] 716 | while raw.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!raw.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> tests/test_responses.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / fn test_responses() { [INFO] [stderr] 11 | | // RESPONSES [INFO] [stderr] 12 | | let responses: [helper::Message; 22] = [ [INFO] [stderr] 13 | | helper::Message { [INFO] [stderr] ... | [INFO] [stderr] 738 | | &responses[NO_CARRIAGE_RET]); [INFO] [stderr] 739 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | for b in "Moved Permanently".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Moved Permanently"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:118:30 [INFO] [stderr] | [INFO] [stderr] 118 | for b in "Not Found".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Not Found"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:139:30 [INFO] [stderr] | [INFO] [stderr] 139 | for b in "".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:169:30 [INFO] [stderr] | [INFO] [stderr] 169 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:197:30 [INFO] [stderr] | [INFO] [stderr] 197 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:225:30 [INFO] [stderr] | [INFO] [stderr] 225 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:253:30 [INFO] [stderr] | [INFO] [stderr] 253 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:287:30 [INFO] [stderr] | [INFO] [stderr] 287 | for b in "Moved Permanently".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Moved Permanently"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:329:30 [INFO] [stderr] | [INFO] [stderr] 329 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:388:26 [INFO] [stderr] | [INFO] [stderr] 388 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:411:26 [INFO] [stderr] | [INFO] [stderr] 411 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:434:26 [INFO] [stderr] | [INFO] [stderr] 434 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:458:26 [INFO] [stderr] | [INFO] [stderr] 458 | for b in "No content".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"No content"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:481:26 [INFO] [stderr] | [INFO] [stderr] 481 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:503:26 [INFO] [stderr] | [INFO] [stderr] 503 | for b in "No content".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"No content"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:526:26 [INFO] [stderr] | [INFO] [stderr] 526 | for b in "No content".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"No content"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:552:26 [INFO] [stderr] | [INFO] [stderr] 552 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:584:26 [INFO] [stderr] | [INFO] [stderr] 584 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:626:26 [INFO] [stderr] | [INFO] [stderr] 626 | for b in "MovedPermanently".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"MovedPermanently"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:657:26 [INFO] [stderr] | [INFO] [stderr] 657 | for b in "".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/test_responses.rs:715:30 [INFO] [stderr] | [INFO] [stderr] 715 | for b in "OK".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"OK"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.63s [INFO] running `"docker" "inspect" "c788d795ef0ae714da92743b5a4b2dbd0e49ef381d818753df4875caa63bef22"` [INFO] running `"docker" "rm" "-f" "c788d795ef0ae714da92743b5a4b2dbd0e49ef381d818753df4875caa63bef22"` [INFO] [stdout] c788d795ef0ae714da92743b5a4b2dbd0e49ef381d818753df4875caa63bef22