[INFO] crate http-file-headers 0.1.8 is already in cache
[INFO] extracting crate http-file-headers 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/http-file-headers/0.1.8
[INFO] extracting crate http-file-headers 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http-file-headers/0.1.8
[INFO] validating manifest of http-file-headers-0.1.8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of http-file-headers-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing http-file-headers-0.1.8
[INFO] finished frobbing http-file-headers-0.1.8
[INFO] frobbed toml for http-file-headers-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/http-file-headers/0.1.8/Cargo.toml
[INFO] started frobbing http-file-headers-0.1.8
[INFO] finished frobbing http-file-headers-0.1.8
[INFO] frobbed toml for http-file-headers-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/http-file-headers/0.1.8/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting http-file-headers-0.1.8 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/http-file-headers/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4e3ec9096d471b840f223eb6990de64783833225633ee9ac25fb0b6842318896
[INFO] running `"docker" "start" "-a" "4e3ec9096d471b840f223eb6990de64783833225633ee9ac25fb0b6842318896"`
[INFO] [stderr]     Checking digest-writer v0.3.1
[INFO] [stderr]     Checking tk-sendfile v0.4.0
[INFO] [stderr]     Checking tk-listen v0.1.1
[INFO] [stderr]     Checking http-file-headers v0.1.8 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/input.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             mode: mode,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `mode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/input.rs:108:13
[INFO] [stderr]     |
[INFO] [stderr] 108 |             range: range,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:197:21
[INFO] [stderr]     |
[INFO] [stderr] 197 |                     encoding: encoding,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:201:21
[INFO] [stderr]     |
[INFO] [stderr] 201 |                     etag: etag,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `etag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:210:21
[INFO] [stderr]     |
[INFO] [stderr] 210 |                     encoding: encoding,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:214:21
[INFO] [stderr]     |
[INFO] [stderr] 214 |                     etag: etag,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `etag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:223:13
[INFO] [stderr]     |
[INFO] [stderr] 223 |             encoding: encoding,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:231:13
[INFO] [stderr]     |
[INFO] [stderr] 231 |             etag: etag,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `etag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |             range: range,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:266:13
[INFO] [stderr]     |
[INFO] [stderr] 266 |             head: head,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `head`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:267:13
[INFO] [stderr]     |
[INFO] [stderr] 267 |             file: file,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:368:17
[INFO] [stderr]     |
[INFO] [stderr] 368 |                 start: start,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:378:21
[INFO] [stderr]     |
[INFO] [stderr] 378 |                     start: start,
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:448:13
[INFO] [stderr]     |
[INFO] [stderr] 448 |             start: start,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:449:13
[INFO] [stderr]     |
[INFO] [stderr] 449 |             end: end,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `end`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/etag.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 |         return Etag(value);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Etag(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/etag.rs:66:19
[INFO] [stderr]    |
[INFO] [stderr] 66 |     const CHARS: &'static[u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZ\
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/input.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return val.starts_with("text/") || val == "application/javascript"
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val.starts_with("text/") || val == "application/javascript"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/input.rs:136:17
[INFO] [stderr]     |
[INFO] [stderr] 136 |                 return Ok(Output::NotFound);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Output::NotFound)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/input.rs:138:23
[INFO] [stderr]     |
[INFO] [stderr] 138 |             Err(e) => return Err(e),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/input.rs:164:13
[INFO] [stderr]     |
[INFO] [stderr] 164 |             return self.try_encodings(base_path, ctype);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.try_encodings(base_path, ctype)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/input.rs:166:13
[INFO] [stderr]     |
[INFO] [stderr] 166 |             return self.try_path(base_path, Encoding::Identity, ctype);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.try_path(base_path, Encoding::Identity, ctype)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/output.rs:23:23
[INFO] [stderr]    |
[INFO] [stderr] 23 | const MIN_DATE: u64 = 631152000;
[INFO] [stderr]    |                       ^^^^^^^^^ help: consider: `631_152_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/output.rs:391:5
[INFO] [stderr]     |
[INFO] [stderr] 391 |     return Ok((range, clen));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((range, clen))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/accept_encoding.rs:181:9
[INFO] [stderr]     |
[INFO] [stderr] 181 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Digest`
[INFO] [stderr]  --> src/etag.rs:7:23
[INFO] [stderr]   |
[INFO] [stderr] 7 | use blake2::{Blake2b, Digest, digest::VariableOutput};
[INFO] [stderr]   |                       ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/conditionals.rs:54:15
[INFO] [stderr]    |
[INFO] [stderr] 54 |         while chunk.len() > 0 && chunk[0] == b' ' {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chunk.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config`
[INFO] [stderr]   --> src/config.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     pub fn new() -> Config {
[INFO] [stderr] 33 | |         Config {
[INFO] [stderr] 34 | |             text_charset: Some(String::from("utf-8")),
[INFO] [stderr] 35 | |             index_files: Vec::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 | impl Default for config::Config {
[INFO] [stderr] 23 |     fn default() -> Self {
[INFO] [stderr] 24 |         Self::new()
[INFO] [stderr] 25 |     }
[INFO] [stderr] 26 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/etag.rs:23:14
[INFO] [stderr]    |
[INFO] [stderr] 23 |             .unwrap_or(Duration::new(0, 0));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(0, 0))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/etag.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |             .unwrap_or(Duration::new(0, 0));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(0, 0))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/etag.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         digest.variable_result(&mut value[..]);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n`
[INFO] [stderr]   --> src/etag.rs:77:21
[INFO] [stderr]    |
[INFO] [stderr] 77 |     dest[3] = CHARS[(n >>  0) & 63];
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/etag.rs:100:14
[INFO] [stderr]     |
[INFO] [stderr] 100 |     let n = ((c1 as u32) << 18) |
[INFO] [stderr]     |              ^^^^^^^^^^^ help: try: `u32::from(c1)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/etag.rs:101:14
[INFO] [stderr]     |
[INFO] [stderr] 101 |             ((c2 as u32) << 12) |
[INFO] [stderr]     |              ^^^^^^^^^^^ help: try: `u32::from(c2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/etag.rs:102:14
[INFO] [stderr]     |
[INFO] [stderr] 102 |             ((c3 as u32) <<  6) |
[INFO] [stderr]     |              ^^^^^^^^^^^ help: try: `u32::from(c3)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/etag.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |             (c4 as u32);
[INFO] [stderr]     |             ^^^^^^^^^^^ help: try: `u32::from(c4)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n`
[INFO] [stderr]    --> src/etag.rs:106:16
[INFO] [stderr]     |
[INFO] [stderr] 106 |     dest[2] = ((n >>  0) & 0xFF) as u8;
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/output.rs:193:12
[INFO] [stderr]     |
[INFO] [stderr] 193 |         if inp.if_none.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inp.if_none.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/range.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let mut pair = slc.splitn(2, "-");
[INFO] [stderr]    |                                  ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/range.rs:100:40
[INFO] [stderr]     |
[INFO] [stderr] 100 |     let mut slices = header[6..].split(",");
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/accept_encoding.rs:49:19
[INFO] [stderr]    |
[INFO] [stderr] 49 |     pub fn suffix(&self) -> &'static str {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/accept_encoding.rs:115:44
[INFO] [stderr]     |
[INFO] [stderr] 115 |                                     val += (x - b'0') as u16 * 10u16.pow((2-i) as u32);
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^ help: try: `u16::from(x - b'0')`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Checking tk-http v0.3.9
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/input.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             mode: mode,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `mode`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/input.rs:108:13
[INFO] [stderr]     |
[INFO] [stderr] 108 |             range: range,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:197:21
[INFO] [stderr]     |
[INFO] [stderr] 197 |                     encoding: encoding,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:201:21
[INFO] [stderr]     |
[INFO] [stderr] 201 |                     etag: etag,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `etag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:210:21
[INFO] [stderr]     |
[INFO] [stderr] 210 |                     encoding: encoding,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:214:21
[INFO] [stderr]     |
[INFO] [stderr] 214 |                     etag: etag,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `etag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:223:13
[INFO] [stderr]     |
[INFO] [stderr] 223 |             encoding: encoding,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:231:13
[INFO] [stderr]     |
[INFO] [stderr] 231 |             etag: etag,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `etag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |             range: range,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:266:13
[INFO] [stderr]     |
[INFO] [stderr] 266 |             head: head,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `head`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:267:13
[INFO] [stderr]     |
[INFO] [stderr] 267 |             file: file,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:368:17
[INFO] [stderr]     |
[INFO] [stderr] 368 |                 start: start,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:378:21
[INFO] [stderr]     |
[INFO] [stderr] 378 |                     start: start,
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:448:13
[INFO] [stderr]     |
[INFO] [stderr] 448 |             start: start,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/output.rs:449:13
[INFO] [stderr]     |
[INFO] [stderr] 449 |             end: end,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `end`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/conditionals.rs:126:45
[INFO] [stderr]     |
[INFO] [stderr] 126 |             Some(UNIX_EPOCH + Duration::new(1503434833, 0)));
[INFO] [stderr]     |                                             ^^^^^^^^^^ help: consider: `1_503_434_833`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/etag.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 |         return Etag(value);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Etag(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/etag.rs:66:19
[INFO] [stderr]    |
[INFO] [stderr] 66 |     const CHARS: &'static[u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZ\
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/input.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return val.starts_with("text/") || val == "application/javascript"
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val.starts_with("text/") || val == "application/javascript"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/input.rs:136:17
[INFO] [stderr]     |
[INFO] [stderr] 136 |                 return Ok(Output::NotFound);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Output::NotFound)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/input.rs:138:23
[INFO] [stderr]     |
[INFO] [stderr] 138 |             Err(e) => return Err(e),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/input.rs:164:13
[INFO] [stderr]     |
[INFO] [stderr] 164 |             return self.try_encodings(base_path, ctype);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.try_encodings(base_path, ctype)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/input.rs:166:13
[INFO] [stderr]     |
[INFO] [stderr] 166 |             return self.try_path(base_path, Encoding::Identity, ctype);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.try_path(base_path, Encoding::Identity, ctype)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/output.rs:23:23
[INFO] [stderr]    |
[INFO] [stderr] 23 | const MIN_DATE: u64 = 631152000;
[INFO] [stderr]    |                       ^^^^^^^^^ help: consider: `631_152_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/output.rs:391:5
[INFO] [stderr]     |
[INFO] [stderr] 391 |     return Ok((range, clen));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((range, clen))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/accept_encoding.rs:181:9
[INFO] [stderr]     |
[INFO] [stderr] 181 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Digest`
[INFO] [stderr]  --> src/etag.rs:7:23
[INFO] [stderr]   |
[INFO] [stderr] 7 | use blake2::{Blake2b, Digest, digest::VariableOutput};
[INFO] [stderr]   |                       ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/conditionals.rs:54:15
[INFO] [stderr]    |
[INFO] [stderr] 54 |         while chunk.len() > 0 && chunk[0] == b' ' {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chunk.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config`
[INFO] [stderr]   --> src/config.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 | /     pub fn new() -> Config {
[INFO] [stderr] 33 | |         Config {
[INFO] [stderr] 34 | |             text_charset: Some(String::from("utf-8")),
[INFO] [stderr] 35 | |             index_files: Vec::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 | impl Default for config::Config {
[INFO] [stderr] 23 |     fn default() -> Self {
[INFO] [stderr] 24 |         Self::new()
[INFO] [stderr] 25 |     }
[INFO] [stderr] 26 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/etag.rs:23:14
[INFO] [stderr]    |
[INFO] [stderr] 23 |             .unwrap_or(Duration::new(0, 0));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(0, 0))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/etag.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |             .unwrap_or(Duration::new(0, 0));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Duration::new(0, 0))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/etag.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         digest.variable_result(&mut value[..]);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n`
[INFO] [stderr]   --> src/etag.rs:77:21
[INFO] [stderr]    |
[INFO] [stderr] 77 |     dest[3] = CHARS[(n >>  0) & 63];
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/etag.rs:100:14
[INFO] [stderr]     |
[INFO] [stderr] 100 |     let n = ((c1 as u32) << 18) |
[INFO] [stderr]     |              ^^^^^^^^^^^ help: try: `u32::from(c1)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/etag.rs:101:14
[INFO] [stderr]     |
[INFO] [stderr] 101 |             ((c2 as u32) << 12) |
[INFO] [stderr]     |              ^^^^^^^^^^^ help: try: `u32::from(c2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/etag.rs:102:14
[INFO] [stderr]     |
[INFO] [stderr] 102 |             ((c3 as u32) <<  6) |
[INFO] [stderr]     |              ^^^^^^^^^^^ help: try: `u32::from(c3)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/etag.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |             (c4 as u32);
[INFO] [stderr]     |             ^^^^^^^^^^^ help: try: `u32::from(c4)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `n`
[INFO] [stderr]    --> src/etag.rs:106:16
[INFO] [stderr]     |
[INFO] [stderr] 106 |     dest[2] = ((n >>  0) & 0xFF) as u8;
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/output.rs:193:12
[INFO] [stderr]     |
[INFO] [stderr] 193 |         if inp.if_none.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!inp.if_none.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/range.rs:28:34
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let mut pair = slc.splitn(2, "-");
[INFO] [stderr]    |                                  ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/range.rs:100:40
[INFO] [stderr]     |
[INFO] [stderr] 100 |     let mut slices = header[6..].split(",");
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/accept_encoding.rs:49:19
[INFO] [stderr]    |
[INFO] [stderr] 49 |     pub fn suffix(&self) -> &'static str {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/accept_encoding.rs:115:44
[INFO] [stderr]     |
[INFO] [stderr] 115 |                                     val += (x - b'0') as u16 * 10u16.pow((2-i) as u32);
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^ help: try: `u16::from(x - b'0')`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> examples/serve_dir.rs:72:30
[INFO] [stderr]    |
[INFO] [stderr] 72 |         debug_assert!(end && data.len() == 0);
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> examples/serve_dir.rs:105:40
[INFO] [stderr]     |
[INFO] [stderr] 105 |                             }).map_err(|e| server::Error::custom(e))
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `server::Error::custom`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 17.45s
[INFO] running `"docker" "inspect" "4e3ec9096d471b840f223eb6990de64783833225633ee9ac25fb0b6842318896"`
[INFO] running `"docker" "rm" "-f" "4e3ec9096d471b840f223eb6990de64783833225633ee9ac25fb0b6842318896"`
[INFO] [stdout] 4e3ec9096d471b840f223eb6990de64783833225633ee9ac25fb0b6842318896