[INFO] crate htmlstream 0.1.3 is already in cache [INFO] extracting crate htmlstream 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/htmlstream/0.1.3 [INFO] extracting crate htmlstream 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/htmlstream/0.1.3 [INFO] validating manifest of htmlstream-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of htmlstream-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing htmlstream-0.1.3 [INFO] finished frobbing htmlstream-0.1.3 [INFO] frobbed toml for htmlstream-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/htmlstream/0.1.3/Cargo.toml [INFO] started frobbing htmlstream-0.1.3 [INFO] finished frobbing htmlstream-0.1.3 [INFO] frobbed toml for htmlstream-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/htmlstream/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting htmlstream-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/htmlstream/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be04949fe859e7aa7f8cf81674f141152e7d79f8eaf94ca0dbee3739fdef99b4 [INFO] running `"docker" "start" "-a" "be04949fe859e7aa7f8cf81674f141152e7d79f8eaf94ca0dbee3739fdef99b4"` [INFO] [stderr] Checking htmlstream v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | html: html, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `html` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | html: html, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `html` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | html: html, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `html` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/attribute.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | html: html, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `html` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tag.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tag.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 131 | | [INFO] [stderr] 132 | | if b'<' == c { [INFO] [stderr] 133 | | let last_index = self.last_index; [INFO] [stderr] ... | [INFO] [stderr] 153 | | [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if b'<' == c { [INFO] [stderr] 131 | let last_index = self.last_index; [INFO] [stderr] 132 | self.is_tag_start = true; [INFO] [stderr] 133 | self.is_get_tag_name = false; [INFO] [stderr] 134 | self.is_closing_tag = false; [INFO] [stderr] 135 | self.is_quote_start = false; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tag.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 60 | | if c <= b' ' || b'/' == c || b'>' == c || b'<' == c { [INFO] [stderr] 61 | | if self.is_closing_tag { [INFO] [stderr] 62 | | self.current_tag_name = &self.html[(self.last_index + 2)..(self.current_index - 1)]; [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | } else if c <= b' ' || b'/' == c || b'>' == c || b'<' == c { [INFO] [stderr] 60 | if self.is_closing_tag { [INFO] [stderr] 61 | self.current_tag_name = &self.html[(self.last_index + 2)..(self.current_index - 1)]; [INFO] [stderr] 62 | } else { [INFO] [stderr] 63 | self.current_tag_name = &self.html[(self.last_index + 1)..(self.current_index - 1)]; [INFO] [stderr] 64 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/attribute.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tag.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tag.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 131 | | [INFO] [stderr] 132 | | if b'<' == c { [INFO] [stderr] 133 | | let last_index = self.last_index; [INFO] [stderr] ... | [INFO] [stderr] 153 | | [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | } else if b'<' == c { [INFO] [stderr] 131 | let last_index = self.last_index; [INFO] [stderr] 132 | self.is_tag_start = true; [INFO] [stderr] 133 | self.is_get_tag_name = false; [INFO] [stderr] 134 | self.is_closing_tag = false; [INFO] [stderr] 135 | self.is_quote_start = false; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tag.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 60 | | if c <= b' ' || b'/' == c || b'>' == c || b'<' == c { [INFO] [stderr] 61 | | if self.is_closing_tag { [INFO] [stderr] 62 | | self.current_tag_name = &self.html[(self.last_index + 2)..(self.current_index - 1)]; [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | } else if c <= b' ' || b'/' == c || b'>' == c || b'<' == c { [INFO] [stderr] 60 | if self.is_closing_tag { [INFO] [stderr] 61 | self.current_tag_name = &self.html[(self.last_index + 2)..(self.current_index - 1)]; [INFO] [stderr] 62 | } else { [INFO] [stderr] 63 | self.current_tag_name = &self.html[(self.last_index + 1)..(self.current_index - 1)]; [INFO] [stderr] 64 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/attribute.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.83s [INFO] running `"docker" "inspect" "be04949fe859e7aa7f8cf81674f141152e7d79f8eaf94ca0dbee3739fdef99b4"` [INFO] running `"docker" "rm" "-f" "be04949fe859e7aa7f8cf81674f141152e7d79f8eaf94ca0dbee3739fdef99b4"` [INFO] [stdout] be04949fe859e7aa7f8cf81674f141152e7d79f8eaf94ca0dbee3739fdef99b4