[INFO] crate html2text 0.1.8 is already in cache [INFO] extracting crate html2text 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/html2text/0.1.8 [INFO] extracting crate html2text 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html2text/0.1.8 [INFO] validating manifest of html2text-0.1.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of html2text-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing html2text-0.1.8 [INFO] removed 0 missing examples [INFO] finished frobbing html2text-0.1.8 [INFO] frobbed toml for html2text-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/html2text/0.1.8/Cargo.toml [INFO] started frobbing html2text-0.1.8 [INFO] removed 0 missing examples [INFO] finished frobbing html2text-0.1.8 [INFO] frobbed toml for html2text-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html2text/0.1.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting html2text-0.1.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/html2text/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c0657470bce1312f02db0b886d97e3f1f0c31f63c5e7e912e26c387c2ae1288 [INFO] running `"docker" "start" "-a" "1c0657470bce1312f02db0b886d97e3f1f0c31f63c5e7e912e26c387c2ae1288"` [INFO] [stderr] Compiling syn v0.9.2 [INFO] [stderr] Compiling string_cache_codegen v0.3.1 [INFO] [stderr] Compiling string_cache v0.2.29 [INFO] [stderr] Compiling string_cache v0.3.0 [INFO] [stderr] Compiling html5ever-atoms v0.1.3 [INFO] [stderr] Compiling html5ever v0.9.0 [INFO] [stderr] Checking html2text v0.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/text_renderer.rs:75:40 [INFO] [stderr] | [INFO] [stderr] 75 | self.v.push(TaggedString { s: s, tag: tag.clone() }); [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/text_renderer.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/text_renderer.rs:489:13 [INFO] [stderr] | [INFO] [stderr] 489 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | num_columns: num_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:230:50 [INFO] [stderr] | [INFO] [stderr] 230 | self.size_estimate = Some(SizeEstimate { size: size, min_width: min_width }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:230:62 [INFO] [stderr] | [INFO] [stderr] 230 | self.size_estimate = Some(SizeEstimate { size: size, min_width: min_width }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:9 [INFO] [stderr] | [INFO] [stderr] 445 | cells: cells, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:462:9 [INFO] [stderr] | [INFO] [stderr] 462 | colspan: colspan, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `colspan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:570:16 [INFO] [stderr] | [INFO] [stderr] 570 | _ => { write!(err_out, "Unhandled: {:?}\n", node).unwrap(); None }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/text_renderer.rs:75:40 [INFO] [stderr] | [INFO] [stderr] 75 | self.v.push(TaggedString { s: s, tag: tag.clone() }); [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/text_renderer.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/text_renderer.rs:489:13 [INFO] [stderr] | [INFO] [stderr] 489 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | num_columns: num_columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:230:50 [INFO] [stderr] | [INFO] [stderr] 230 | self.size_estimate = Some(SizeEstimate { size: size, min_width: min_width }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:230:62 [INFO] [stderr] | [INFO] [stderr] 230 | self.size_estimate = Some(SizeEstimate { size: size, min_width: min_width }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:9 [INFO] [stderr] | [INFO] [stderr] 445 | cells: cells, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:462:9 [INFO] [stderr] | [INFO] [stderr] 462 | colspan: colspan, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `colspan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:570:16 [INFO] [stderr] | [INFO] [stderr] 570 | _ => { write!(err_out, "Unhandled: {:?}\n", node).unwrap(); None }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/render/text_renderer.rs:1023:66 [INFO] [stderr] | [INFO] [stderr] 1023 | fn decorate_preformat_first(&mut self) -> Self::Annotation { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/render/text_renderer.rs:1024:65 [INFO] [stderr] | [INFO] [stderr] 1024 | fn decorate_preformat_cont(&mut self) -> Self::Annotation { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | children [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:344:20 [INFO] [stderr] | [INFO] [stderr] 344 | let children = handle.borrow().children [INFO] [stderr] | ____________________^ [INFO] [stderr] 345 | | .iter() [INFO] [stderr] 346 | | .flat_map(|ch| dom_to_render_tree(ch.clone(), err_out)) [INFO] [stderr] 347 | | .collect(); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:574:5 [INFO] [stderr] | [INFO] [stderr] 574 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/render/text_renderer.rs:1023:66 [INFO] [stderr] | [INFO] [stderr] 1023 | fn decorate_preformat_first(&mut self) -> Self::Annotation { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/render/text_renderer.rs:1024:65 [INFO] [stderr] | [INFO] [stderr] 1024 | fn decorate_preformat_cont(&mut self) -> Self::Annotation { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | children [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:344:20 [INFO] [stderr] | [INFO] [stderr] 344 | let children = handle.borrow().children [INFO] [stderr] | ____________________^ [INFO] [stderr] 345 | | .iter() [INFO] [stderr] 346 | | .flat_map(|ch| dom_to_render_tree(ch.clone(), err_out)) [INFO] [stderr] 347 | | .collect(); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:574:5 [INFO] [stderr] | [INFO] [stderr] 574 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `render::text_renderer::TaggedLine` [INFO] [stderr] --> src/render/text_renderer.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> TaggedLine { [INFO] [stderr] 28 | | TaggedLine { [INFO] [stderr] 29 | | v: Vec::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/render/text_renderer.rs:656:21 [INFO] [stderr] | [INFO] [stderr] 656 | / match c { [INFO] [stderr] 657 | | '\t' => { [INFO] [stderr] 658 | | let tab_stop = 8; [INFO] [stderr] 659 | | let wanted_pos = cur_width + tab_stop - (cur_width % tab_stop); [INFO] [stderr] ... | [INFO] [stderr] 668 | | _ => (), [INFO] [stderr] 669 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 656 | if let '\t' = c { [INFO] [stderr] 657 | let tab_stop = 8; [INFO] [stderr] 658 | let wanted_pos = cur_width + tab_stop - (cur_width % tab_stop); [INFO] [stderr] 659 | let spaces = if wanted_pos > width { [INFO] [stderr] 660 | width - cur_width [INFO] [stderr] 661 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/text_renderer.rs:672:16 [INFO] [stderr] | [INFO] [stderr] 672 | if acc.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!acc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/render/text_renderer.rs:774:13 [INFO] [stderr] | [INFO] [stderr] 774 | / if let &mut RenderLine::Line(ref mut prev_border) = self.lines.last_mut().unwrap() { [INFO] [stderr] 775 | | for &(w, _) in &line_sets[..line_sets.len()-1] { [INFO] [stderr] 776 | | prev_border.join_below(pos+w); [INFO] [stderr] 777 | | next_border.join_above(pos+w); [INFO] [stderr] ... | [INFO] [stderr] 781 | | panic!("Expected a border line"); [INFO] [stderr] 782 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 774 | if let RenderLine::Line(ref mut prev_border) = *self.lines.last_mut().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/text_renderer.rs:798:40 [INFO] [stderr] | [INFO] [stderr] 798 | let starts_border = if sublines.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sublines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/render/text_renderer.rs:808:21 [INFO] [stderr] | [INFO] [stderr] 808 | / if let &mut RenderLine::Line(ref mut prev_border) = self.lines.last_mut().expect("No previous line") { [INFO] [stderr] 809 | | if let RenderLine::Line(line) = sublines.remove(0) { [INFO] [stderr] 810 | | prev_border.merge_from_below(&line, pos); [INFO] [stderr] 811 | | } [INFO] [stderr] 812 | | } else { [INFO] [stderr] 813 | | unreachable!(); [INFO] [stderr] 814 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 808 | if let RenderLine::Line(ref mut prev_border) = *self.lines.last_mut().expect("No previous line") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/text_renderer.rs:822:38 [INFO] [stderr] | [INFO] [stderr] 822 | let ends_border = if sublines.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sublines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/render/text_renderer.rs:850:21 [INFO] [stderr] | [INFO] [stderr] 850 | / match piece { [INFO] [stderr] 851 | | &mut RenderLine::Text(ref mut tline) => { [INFO] [stderr] 852 | | line.consume(tline); [INFO] [stderr] 853 | | }, [INFO] [stderr] ... | [INFO] [stderr] 859 | | }, [INFO] [stderr] 860 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 850 | match *piece { [INFO] [stderr] 851 | RenderLine::Text(ref mut tline) => { [INFO] [stderr] 852 | line.consume(tline); [INFO] [stderr] 853 | }, [INFO] [stderr] 854 | RenderLine::Line(ref bord) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/render/text_renderer.rs:863:28 [INFO] [stderr] | [INFO] [stderr] 863 | s: column_padding[cellno].as_ref().map(|s| s.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `column_padding[cellno].as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `render::text_renderer::PlainDecorator` [INFO] [stderr] --> src/render/text_renderer.rs:972:5 [INFO] [stderr] | [INFO] [stderr] 972 | / pub fn new() -> PlainDecorator { [INFO] [stderr] 973 | | PlainDecorator { [INFO] [stderr] 974 | | links: Vec::new(), [INFO] [stderr] 975 | | } [INFO] [stderr] 976 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 965 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `render::text_renderer::RichDecorator` [INFO] [stderr] --> src/render/text_renderer.rs:1076:5 [INFO] [stderr] | [INFO] [stderr] 1076 | / pub fn new() -> RichDecorator { [INFO] [stderr] 1077 | | RichDecorator { [INFO] [stderr] 1078 | | } [INFO] [stderr] 1079 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1044 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / pub fn add(self, other: SizeEstimate) -> SizeEstimate { [INFO] [stderr] 119 | | SizeEstimate { [INFO] [stderr] 120 | | size: self.size + other.size, [INFO] [stderr] 121 | | min_width: max(self.min_width, other.min_width), [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:359:17 [INFO] [stderr] | [INFO] [stderr] 359 | / match *name { [INFO] [stderr] 360 | | qualname!(html, "li") => { [INFO] [stderr] 361 | | let li_children = children_to_render_nodes(child.clone(), err_out); [INFO] [stderr] 362 | | children.push(RenderNode::new(RenderNodeInfo::Block(li_children))); [INFO] [stderr] 363 | | }, [INFO] [stderr] 364 | | _ => {}, [INFO] [stderr] 365 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 359 | if let $ crate :: QualName { ns : ns ! ( $ ns ) , local : local_name ! ( $ local ) , [INFO] [stderr] 360 | } = *name { [INFO] [stderr] 361 | let li_children = children_to_render_nodes(child.clone(), err_out); [INFO] [stderr] 362 | children.push(RenderNode::new(RenderNodeInfo::Block(li_children))); [INFO] [stderr] 363 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:393:8 [INFO] [stderr] | [INFO] [stderr] 393 | if rows.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `render::text_renderer::TaggedLine` [INFO] [stderr] --> src/render/text_renderer.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> TaggedLine { [INFO] [stderr] 28 | | TaggedLine { [INFO] [stderr] 29 | | v: Vec::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/render/text_renderer.rs:656:21 [INFO] [stderr] | [INFO] [stderr] 656 | / match c { [INFO] [stderr] 657 | | '\t' => { [INFO] [stderr] 658 | | let tab_stop = 8; [INFO] [stderr] 659 | | let wanted_pos = cur_width + tab_stop - (cur_width % tab_stop); [INFO] [stderr] ... | [INFO] [stderr] 668 | | _ => (), [INFO] [stderr] 669 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 656 | if let '\t' = c { [INFO] [stderr] 657 | let tab_stop = 8; [INFO] [stderr] 658 | let wanted_pos = cur_width + tab_stop - (cur_width % tab_stop); [INFO] [stderr] 659 | let spaces = if wanted_pos > width { [INFO] [stderr] 660 | width - cur_width [INFO] [stderr] 661 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/text_renderer.rs:672:16 [INFO] [stderr] | [INFO] [stderr] 672 | if acc.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!acc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/render/text_renderer.rs:774:13 [INFO] [stderr] | [INFO] [stderr] 774 | / if let &mut RenderLine::Line(ref mut prev_border) = self.lines.last_mut().unwrap() { [INFO] [stderr] 775 | | for &(w, _) in &line_sets[..line_sets.len()-1] { [INFO] [stderr] 776 | | prev_border.join_below(pos+w); [INFO] [stderr] 777 | | next_border.join_above(pos+w); [INFO] [stderr] ... | [INFO] [stderr] 781 | | panic!("Expected a border line"); [INFO] [stderr] 782 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 774 | if let RenderLine::Line(ref mut prev_border) = *self.lines.last_mut().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/text_renderer.rs:798:40 [INFO] [stderr] | [INFO] [stderr] 798 | let starts_border = if sublines.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sublines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/render/text_renderer.rs:808:21 [INFO] [stderr] | [INFO] [stderr] 808 | / if let &mut RenderLine::Line(ref mut prev_border) = self.lines.last_mut().expect("No previous line") { [INFO] [stderr] 809 | | if let RenderLine::Line(line) = sublines.remove(0) { [INFO] [stderr] 810 | | prev_border.merge_from_below(&line, pos); [INFO] [stderr] 811 | | } [INFO] [stderr] 812 | | } else { [INFO] [stderr] 813 | | unreachable!(); [INFO] [stderr] 814 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 808 | if let RenderLine::Line(ref mut prev_border) = *self.lines.last_mut().expect("No previous line") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/render/text_renderer.rs:822:38 [INFO] [stderr] | [INFO] [stderr] 822 | let ends_border = if sublines.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sublines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/render/text_renderer.rs:850:21 [INFO] [stderr] | [INFO] [stderr] 850 | / match piece { [INFO] [stderr] 851 | | &mut RenderLine::Text(ref mut tline) => { [INFO] [stderr] 852 | | line.consume(tline); [INFO] [stderr] 853 | | }, [INFO] [stderr] ... | [INFO] [stderr] 859 | | }, [INFO] [stderr] 860 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 850 | match *piece { [INFO] [stderr] 851 | RenderLine::Text(ref mut tline) => { [INFO] [stderr] 852 | line.consume(tline); [INFO] [stderr] 853 | }, [INFO] [stderr] 854 | RenderLine::Line(ref bord) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/render/text_renderer.rs:863:28 [INFO] [stderr] | [INFO] [stderr] 863 | s: column_padding[cellno].as_ref().map(|s| s.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `column_padding[cellno].as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `render::text_renderer::PlainDecorator` [INFO] [stderr] --> src/render/text_renderer.rs:972:5 [INFO] [stderr] | [INFO] [stderr] 972 | / pub fn new() -> PlainDecorator { [INFO] [stderr] 973 | | PlainDecorator { [INFO] [stderr] 974 | | links: Vec::new(), [INFO] [stderr] 975 | | } [INFO] [stderr] 976 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 965 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `render::text_renderer::RichDecorator` [INFO] [stderr] --> src/render/text_renderer.rs:1076:5 [INFO] [stderr] | [INFO] [stderr] 1076 | / pub fn new() -> RichDecorator { [INFO] [stderr] 1077 | | RichDecorator { [INFO] [stderr] 1078 | | } [INFO] [stderr] 1079 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1044 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / pub fn add(self, other: SizeEstimate) -> SizeEstimate { [INFO] [stderr] 119 | | SizeEstimate { [INFO] [stderr] 120 | | size: self.size + other.size, [INFO] [stderr] 121 | | min_width: max(self.min_width, other.min_width), [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:359:17 [INFO] [stderr] | [INFO] [stderr] 359 | / match *name { [INFO] [stderr] 360 | | qualname!(html, "li") => { [INFO] [stderr] 361 | | let li_children = children_to_render_nodes(child.clone(), err_out); [INFO] [stderr] 362 | | children.push(RenderNode::new(RenderNodeInfo::Block(li_children))); [INFO] [stderr] 363 | | }, [INFO] [stderr] 364 | | _ => {}, [INFO] [stderr] 365 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 359 | if let $ crate :: QualName { ns : ns ! ( $ ns ) , local : local_name ! ( $ local ) , [INFO] [stderr] 360 | } = *name { [INFO] [stderr] 361 | let li_children = children_to_render_nodes(child.clone(), err_out); [INFO] [stderr] 362 | children.push(RenderNode::new(RenderNodeInfo::Block(li_children))); [INFO] [stderr] 363 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:393:8 [INFO] [stderr] | [INFO] [stderr] 393 | if rows.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/tables.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `html2text`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/html2term.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | fn to_style(tag: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RichAnnotation]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/html2term.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | fn link_from_tag(tag: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RichAnnotation]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/html2term.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | fn find_links(lines: &Vec>>) -> LinkMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[TaggedLine>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "1c0657470bce1312f02db0b886d97e3f1f0c31f63c5e7e912e26c387c2ae1288"` [INFO] running `"docker" "rm" "-f" "1c0657470bce1312f02db0b886d97e3f1f0c31f63c5e7e912e26c387c2ae1288"` [INFO] [stdout] 1c0657470bce1312f02db0b886d97e3f1f0c31f63c5e7e912e26c387c2ae1288