[INFO] crate html2runes 1.0.0 is already in cache
[INFO] extracting crate html2runes 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/html2runes/1.0.0
[INFO] extracting crate html2runes 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html2runes/1.0.0
[INFO] validating manifest of html2runes-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of html2runes-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing html2runes-1.0.0
[INFO] finished frobbing html2runes-1.0.0
[INFO] frobbed toml for html2runes-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/html2runes/1.0.0/Cargo.toml
[INFO] started frobbing html2runes-1.0.0
[INFO] finished frobbing html2runes-1.0.0
[INFO] frobbed toml for html2runes-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html2runes/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting html2runes-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/html2runes/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9515ef7369034161e336bf76cab0c52c5359635469a8cd1c9aab45475fc1eb72
[INFO] running `"docker" "start" "-a" "9515ef7369034161e336bf76cab0c52c5359635469a8cd1c9aab45475fc1eb72"`
[INFO] [stderr] Checking clap v2.20.5
[INFO] [stderr] Compiling string_cache_codegen v0.3.1
[INFO] [stderr] Compiling html5ever v0.13.1
[INFO] [stderr] Compiling string_cache v0.4.0
[INFO] [stderr] Compiling html5ever-atoms v0.2.2
[INFO] [stderr] Checking html2runes v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr] --> src/parse.rs:15:5
[INFO] [stderr] |
[INFO] [stderr] 15 | dom
[INFO] [stderr] | ^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr] --> src/parse.rs:11:15
[INFO] [stderr] |
[INFO] [stderr] 11 | let dom = parse_document(RcDom::default(), Default::default())
[INFO] [stderr] | _______________^
[INFO] [stderr] 12 | | .from_utf8()
[INFO] [stderr] 13 | | .read_from(&mut stdin.lock())
[INFO] [stderr] 14 | | .unwrap();
[INFO] [stderr] | |_________________^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr]
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr] --> src/parse.rs:24:5
[INFO] [stderr] |
[INFO] [stderr] 24 | dom
[INFO] [stderr] | ^^^
[INFO] [stderr] |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr] --> src/parse.rs:20:15
[INFO] [stderr] |
[INFO] [stderr] 20 | let dom = parse_document(RcDom::default(), Default::default())
[INFO] [stderr] | _______________^
[INFO] [stderr] 21 | | .from_utf8()
[INFO] [stderr] 22 | | .read_from(&mut text.as_bytes())
[INFO] [stderr] 23 | | .unwrap();
[INFO] [stderr] | |_________________^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr]
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr] --> src/parse.rs:15:5
[INFO] [stderr] |
[INFO] [stderr] 15 | dom
[INFO] [stderr] | ^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr] --> src/parse.rs:11:15
[INFO] [stderr] |
[INFO] [stderr] 11 | let dom = parse_document(RcDom::default(), Default::default())
[INFO] [stderr] | _______________^
[INFO] [stderr] 12 | | .from_utf8()
[INFO] [stderr] 13 | | .read_from(&mut stdin.lock())
[INFO] [stderr] 14 | | .unwrap();
[INFO] [stderr] | |_________________^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr]
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr] --> src/parse.rs:24:5
[INFO] [stderr] |
[INFO] [stderr] 24 | dom
[INFO] [stderr] | ^^^
[INFO] [stderr] |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr] --> src/parse.rs:20:15
[INFO] [stderr] |
[INFO] [stderr] 20 | let dom = parse_document(RcDom::default(), Default::default())
[INFO] [stderr] | _______________^
[INFO] [stderr] 21 | | .from_utf8()
[INFO] [stderr] 22 | | .read_from(&mut text.as_bytes())
[INFO] [stderr] 23 | | .unwrap();
[INFO] [stderr] | |_________________^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr]
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `markdown::MarkdownConverter<'a>`
[INFO] [stderr] --> src/markdown.rs:35:5
[INFO] [stderr] |
[INFO] [stderr] 35 | / pub fn new() -> MarkdownConverter<'a> {
[INFO] [stderr] 36 | | MarkdownConverter {
[INFO] [stderr] 37 | | buf: String::new(),
[INFO] [stderr] 38 | | prefix: LinkedList::new(),
[INFO] [stderr] 39 | | list_markers: Vec::new(),
[INFO] [stderr] 40 | | }
[INFO] [stderr] 41 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 28 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/markdown.rs:60:58
[INFO] [stderr] |
[INFO] [stderr] 60 | fn handle_element(&mut self, name: &QualName, attrs: &Vec, node: &Ref) {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/markdown.rs:80:52
[INFO] [stderr] |
[INFO] [stderr] 80 | fn element_start(&mut self, name: &str, attrs: &Vec) {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: The function/method `li_start` doesn't need a mutable reference
[INFO] [stderr] --> src/markdown.rs:91:45
[INFO] [stderr] |
[INFO] [stderr] 91 | "li" => li_start(&mut self.buf, &mut self.list_markers),
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/markdown.rs:96:50
[INFO] [stderr] |
[INFO] [stderr] 96 | fn element_end(&mut self, name: &str, attrs: &Vec) {
[INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/markdown.rs:152:52
[INFO] [stderr] |
[INFO] [stderr] 152 | let mut prev = buf.is_empty() || buf.ends_with(" ") || buf.ends_with("\n");
[INFO] [stderr] | ^^^ help: try using a char instead: `' '`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/markdown.rs:152:74
[INFO] [stderr] |
[INFO] [stderr] 152 | let mut prev = buf.is_empty() || buf.ends_with(" ") || buf.ends_with("\n");
[INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/markdown.rs:187:25
[INFO] [stderr] |
[INFO] [stderr] 187 | while buf.ends_with(" ") || buf.ends_with("\t") {
[INFO] [stderr] | ^^^ help: try using a char instead: `' '`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr] --> src/markdown.rs:187:47
[INFO] [stderr] |
[INFO] [stderr] 187 | while buf.ends_with(" ") || buf.ends_with("\t") {
[INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr]
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr] --> src/markdown.rs:193:25
[INFO] [stderr] |
[INFO] [stderr] 193 | fn prefix(list_markers: &Vec