[INFO] crate html2pango 0.1.0 is already in cache [INFO] extracting crate html2pango 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/html2pango/0.1.0 [INFO] extracting crate html2pango 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html2pango/0.1.0 [INFO] validating manifest of html2pango-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of html2pango-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing html2pango-0.1.0 [INFO] finished frobbing html2pango-0.1.0 [INFO] frobbed toml for html2pango-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/html2pango/0.1.0/Cargo.toml [INFO] started frobbing html2pango-0.1.0 [INFO] finished frobbing html2pango-0.1.0 [INFO] frobbed toml for html2pango-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/html2pango/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting html2pango-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/html2pango/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 912b8a168d738ed37960a1cc1633430f7cd172194d4bd119ceecb3f95263aaa2 [INFO] running `"docker" "start" "-a" "912b8a168d738ed37960a1cc1633430f7cd172194d4bd119ceecb3f95263aaa2"` [INFO] [stderr] Checking linkify v0.3.1 [INFO] [stderr] Checking html5ever v0.22.5 [INFO] [stderr] Checking ammonia v1.2.0 [INFO] [stderr] Checking html2pango v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/lib.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/lib.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut foo = Vec::with_capacity(s.as_bytes().len()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:218:1 [INFO] [stderr] | [INFO] [stderr] 218 | / fn convert_tag<'a>(t: &'a str) -> Option<(&'a str, &'a str)> { [INFO] [stderr] 219 | | let allowed = [ [INFO] [stderr] 220 | | "a", "br", "em", "p", "code", "strong", "blockquote", [INFO] [stderr] 221 | | ]; [INFO] [stderr] ... | [INFO] [stderr] 235 | | } [INFO] [stderr] 236 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:260:25 [INFO] [stderr] | [INFO] [stderr] 260 | / match &s[..] { [INFO] [stderr] 261 | | "href" => { link = attr.value.to_string(); } [INFO] [stderr] 262 | | _ => {} [INFO] [stderr] 263 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let "href" = &s[..] { link = attr.value.to_string(); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let mut foo = Vec::with_capacity(s.as_bytes().len()); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:218:1 [INFO] [stderr] | [INFO] [stderr] 218 | / fn convert_tag<'a>(t: &'a str) -> Option<(&'a str, &'a str)> { [INFO] [stderr] 219 | | let allowed = [ [INFO] [stderr] 220 | | "a", "br", "em", "p", "code", "strong", "blockquote", [INFO] [stderr] 221 | | ]; [INFO] [stderr] ... | [INFO] [stderr] 235 | | } [INFO] [stderr] 236 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:260:25 [INFO] [stderr] | [INFO] [stderr] 260 | / match &s[..] { [INFO] [stderr] 261 | | "href" => { link = attr.value.to_string(); } [INFO] [stderr] 262 | | _ => {} [INFO] [stderr] 263 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let "href" = &s[..] { link = attr.value.to_string(); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.76s [INFO] running `"docker" "inspect" "912b8a168d738ed37960a1cc1633430f7cd172194d4bd119ceecb3f95263aaa2"` [INFO] running `"docker" "rm" "-f" "912b8a168d738ed37960a1cc1633430f7cd172194d4bd119ceecb3f95263aaa2"` [INFO] [stdout] 912b8a168d738ed37960a1cc1633430f7cd172194d4bd119ceecb3f95263aaa2