[INFO] crate ht16k33 0.1.0 is already in cache
[INFO] extracting crate ht16k33 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ht16k33/0.1.0
[INFO] extracting crate ht16k33 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ht16k33/0.1.0
[INFO] validating manifest of ht16k33-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ht16k33-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ht16k33-0.1.0
[INFO] finished frobbing ht16k33-0.1.0
[INFO] frobbed toml for ht16k33-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ht16k33/0.1.0/Cargo.toml
[INFO] started frobbing ht16k33-0.1.0
[INFO] finished frobbing ht16k33-0.1.0
[INFO] frobbed toml for ht16k33-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ht16k33/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ht16k33-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ht16k33/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8fee7b0fa26495ef1b031bee4c8a721b6aba319c36e0322aef3f2accd8c35174
[INFO] running `"docker" "start" "-a" "8fee7b0fa26495ef1b031bee4c8a721b6aba319c36e0322aef3f2accd8c35174"`
[INFO] [stderr]     Checking slog-scope v4.1.1
[INFO] [stderr]     Checking slog-stdlog v3.0.4-pre
[INFO] [stderr]     Checking ht16k33 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/i2c_mock.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             logger: logger,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `logger`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/i2c_mock.rs:212:13
[INFO] [stderr]     |
[INFO] [stderr] 212 |             logger: logger,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `logger`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:166:13
[INFO] [stderr]     |
[INFO] [stderr] 166 |             i2c_device: i2c_device,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `i2c_device`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:168:13
[INFO] [stderr]     |
[INFO] [stderr] 168 |             logger: logger,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `logger`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |             steps: steps,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/i2c_mock.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             logger: logger,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `logger`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/i2c_mock.rs:212:13
[INFO] [stderr]     |
[INFO] [stderr] 212 |             logger: logger,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `logger`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:166:13
[INFO] [stderr]     |
[INFO] [stderr] 166 |             i2c_device: i2c_device,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `i2c_device`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:168:13
[INFO] [stderr]     |
[INFO] [stderr] 168 |             logger: logger,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `logger`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:169:13
[INFO] [stderr]     |
[INFO] [stderr] 169 |             steps: steps,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/i2c_mock.rs:54:36
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let logger = logger.into().unwrap_or(Logger::root(StdLog.fuse(), o!()));
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Logger::root(StdLog.fuse(), o!()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `data`.
[INFO] [stderr]   --> src/i2c_mock.rs:83:18
[INFO] [stderr]    |
[INFO] [stderr] 83 |         for i in 0..data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 83 |         for <item> in &mut data {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]    --> src/i2c_mock.rs:144:18
[INFO] [stderr]     |
[INFO] [stderr] 144 |         for i in 0..data.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 144 |         for (i, <item>) in data.iter().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/i2c_mock.rs:144:18
[INFO] [stderr]     |
[INFO] [stderr] 144 |         for i in 0..data.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^ help: try replacing the loop by: `self.registers[offset..(data.len() + offset)].clone_from_slice(&data[..])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/i2c_mock.rs:204:36
[INFO] [stderr]     |
[INFO] [stderr] 204 |         let logger = logger.into().unwrap_or(Logger::root(StdLog.fuse(), o!()));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Logger::root(StdLog.fuse(), o!()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:160:36
[INFO] [stderr]     |
[INFO] [stderr] 160 |         let logger = logger.into().unwrap_or(Logger::root(StdLog.fuse(), o!()));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Logger::root(StdLog.fuse(), o!()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:259:21
[INFO] [stderr]     |
[INFO] [stderr] 259 |     pub fn is_ready(&mut self) -> bool {
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/lib.rs:523:31
[INFO] [stderr]     |
[INFO] [stderr] 523 |     pub fn set_bar(&mut self, bar: u8, color: u8) -> Result<(), HT16K33Error<D>> {
[INFO] [stderr]     |                               ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:540:13
[INFO] [stderr]     |
[INFO] [stderr] 540 |             if color & COLOR_GREEN > 0 { true } else { false },
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `color & COLOR_GREEN > 0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:544:34
[INFO] [stderr]     |
[INFO] [stderr] 544 |         self.set_led(c * 16 + a, if color & COLOR_RED > 0 { true } else { false })?;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `color & COLOR_RED > 0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/i2c_mock.rs:54:36
[INFO] [stderr]    |
[INFO] [stderr] 54 |         let logger = logger.into().unwrap_or(Logger::root(StdLog.fuse(), o!()));
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Logger::root(StdLog.fuse(), o!()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `data`.
[INFO] [stderr]   --> src/i2c_mock.rs:83:18
[INFO] [stderr]    |
[INFO] [stderr] 83 |         for i in 0..data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 83 |         for <item> in &mut data {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]    --> src/i2c_mock.rs:144:18
[INFO] [stderr]     |
[INFO] [stderr] 144 |         for i in 0..data.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 144 |         for (i, <item>) in data.iter().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]    --> src/i2c_mock.rs:144:18
[INFO] [stderr]     |
[INFO] [stderr] 144 |         for i in 0..data.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^ help: try replacing the loop by: `self.registers[offset..(data.len() + offset)].clone_from_slice(&data[..])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/i2c_mock.rs:204:36
[INFO] [stderr]     |
[INFO] [stderr] 204 |         let logger = logger.into().unwrap_or(Logger::root(StdLog.fuse(), o!()));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Logger::root(StdLog.fuse(), o!()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:160:36
[INFO] [stderr]     |
[INFO] [stderr] 160 |         let logger = logger.into().unwrap_or(Logger::root(StdLog.fuse(), o!()));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Logger::root(StdLog.fuse(), o!()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:259:21
[INFO] [stderr]     |
[INFO] [stderr] 259 |     pub fn is_ready(&mut self) -> bool {
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/lib.rs:523:31
[INFO] [stderr]     |
[INFO] [stderr] 523 |     pub fn set_bar(&mut self, bar: u8, color: u8) -> Result<(), HT16K33Error<D>> {
[INFO] [stderr]     |                               ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:540:13
[INFO] [stderr]     |
[INFO] [stderr] 540 |             if color & COLOR_GREEN > 0 { true } else { false },
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `color & COLOR_GREEN > 0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:544:34
[INFO] [stderr]     |
[INFO] [stderr] 544 |         self.set_led(c * 16 + a, if color & COLOR_RED > 0 { true } else { false })?;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `color & COLOR_RED > 0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.14s
[INFO] running `"docker" "inspect" "8fee7b0fa26495ef1b031bee4c8a721b6aba319c36e0322aef3f2accd8c35174"`
[INFO] running `"docker" "rm" "-f" "8fee7b0fa26495ef1b031bee4c8a721b6aba319c36e0322aef3f2accd8c35174"`
[INFO] [stdout] 8fee7b0fa26495ef1b031bee4c8a721b6aba319c36e0322aef3f2accd8c35174