[INFO] crate howtocards_backend 0.1.2 is already in cache
[INFO] extracting crate howtocards_backend 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/howtocards_backend/0.1.2
[INFO] extracting crate howtocards_backend 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/howtocards_backend/0.1.2
[INFO] validating manifest of howtocards_backend-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of howtocards_backend-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing howtocards_backend-0.1.2
[INFO] finished frobbing howtocards_backend-0.1.2
[INFO] frobbed toml for howtocards_backend-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/howtocards_backend/0.1.2/Cargo.toml
[INFO] started frobbing howtocards_backend-0.1.2
[INFO] finished frobbing howtocards_backend-0.1.2
[INFO] frobbed toml for howtocards_backend-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/howtocards_backend/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting howtocards_backend-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/howtocards_backend/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f75edc269635950d196d363f9ead959761483226aac685ff88dfe809c8ab231a
[INFO] running `"docker" "start" "-a" "f75edc269635950d196d363f9ead959761483226aac685ff88dfe809c8ab231a"`
[INFO] [stderr]     Checking serde v1.0.85
[INFO] [stderr]     Checking dotenv v0.13.0
[INFO] [stderr]     Checking trust-dns-proto v0.6.3
[INFO] [stderr]     Checking trust-dns-proto v0.5.0
[INFO] [stderr]     Checking trust-dns-resolver v0.10.3
[INFO] [stderr]     Checking uuid v0.7.2
[INFO] [stderr]     Checking serde_json v1.0.37
[INFO] [stderr]     Checking serde_urlencoded v0.5.4
[INFO] [stderr]     Checking ron v0.2.2
[INFO] [stderr]     Checking actix v0.7.9
[INFO] [stderr]     Checking rustbreak v2.0.0-rc3
[INFO] [stderr]     Checking actix-net v0.2.6
[INFO] [stderr]     Checking actix-web v0.7.18
[INFO] [stderr]     Checking howtocards_backend v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:4:18
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub const SALT: &'static str = "SALT";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/consts.rs:4:18
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub const SALT: &'static str = "SALT";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/auth_token.rs:31:50
[INFO] [stderr]    |
[INFO] [stderr] 31 |             let chunks: Vec<&str> = source.split(" ").collect();
[INFO] [stderr]    |                                                  ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: item `db::token::Tokens` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]   --> src/db/token.rs:45:1
[INFO] [stderr]    |
[INFO] [stderr] 45 | / impl Tokens {
[INFO] [stderr] 46 | |     fn new() -> Tokens {
[INFO] [stderr] 47 | |         Tokens {
[INFO] [stderr] 48 | |             ..Default::default()
[INFO] [stderr] ...  |
[INFO] [stderr] 86 | |     }
[INFO] [stderr] 87 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/db/token.rs:59:41
[INFO] [stderr]    |
[INFO] [stderr] 59 |     pub fn remove_one(&mut self, token: &String) {
[INFO] [stderr]    |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/db/token.rs:68:30
[INFO] [stderr]    |
[INFO] [stderr] 68 |                 let tokens = self.by_user_id.get(&user_id).unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.by_user_id[&user_id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/db/token.rs:78:31
[INFO] [stderr]    |
[INFO] [stderr] 78 |     pub fn find(&self, token: &String) -> Option<(String, u32)> {
[INFO] [stderr]    |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/db/user.rs:40:26
[INFO] [stderr]    |
[INFO] [stderr] 40 |         for (_, user) in &self.users {
[INFO] [stderr]    |                          ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 40 |         for user in self.users.values() {
[INFO] [stderr]    |             ^^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/db/user.rs:82:36
[INFO] [stderr]    |
[INFO] [stderr] 82 |     pub fn has_email(&self, email: &String) -> bool {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/db/user.rs:86:39
[INFO] [stderr]    |
[INFO] [stderr] 86 |     pub fn get_by_email(&self, email: &String) -> Option<&User> {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/hasher.rs:38:38
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn validate_password<P, S>(hash: &String, salt: S, password: P) -> bool
[INFO] [stderr]    |                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/handlers/account/login.rs:61:40
[INFO] [stderr]    |
[INFO] [stderr] 61 |             .filter(users::password.eq(new_account.password.clone()))
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 61 |             .filter(users::password.eq(&(*new_account.password).clone()))
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 61 |             .filter(users::password.eq(&str::clone(new_account.password)))
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:55:38
[INFO] [stderr]    |
[INFO] [stderr] 55 |     PgConnection::establish(&db_url).expect(&format!("Error connecting to {}", db_url))
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", db_url))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `howtocards_backend`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/auth_token.rs:31:50
[INFO] [stderr]    |
[INFO] [stderr] 31 |             let chunks: Vec<&str> = source.split(" ").collect();
[INFO] [stderr]    |                                                  ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: item `db::token::Tokens` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]   --> src/db/token.rs:45:1
[INFO] [stderr]    |
[INFO] [stderr] 45 | / impl Tokens {
[INFO] [stderr] 46 | |     fn new() -> Tokens {
[INFO] [stderr] 47 | |         Tokens {
[INFO] [stderr] 48 | |             ..Default::default()
[INFO] [stderr] ...  |
[INFO] [stderr] 86 | |     }
[INFO] [stderr] 87 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/db/token.rs:59:41
[INFO] [stderr]    |
[INFO] [stderr] 59 |     pub fn remove_one(&mut self, token: &String) {
[INFO] [stderr]    |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/db/token.rs:68:30
[INFO] [stderr]    |
[INFO] [stderr] 68 |                 let tokens = self.by_user_id.get(&user_id).unwrap();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.by_user_id[&user_id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/db/token.rs:78:31
[INFO] [stderr]    |
[INFO] [stderr] 78 |     pub fn find(&self, token: &String) -> Option<(String, u32)> {
[INFO] [stderr]    |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]   --> src/db/user.rs:40:26
[INFO] [stderr]    |
[INFO] [stderr] 40 |         for (_, user) in &self.users {
[INFO] [stderr]    |                          ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 40 |         for user in self.users.values() {
[INFO] [stderr]    |             ^^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/db/user.rs:82:36
[INFO] [stderr]    |
[INFO] [stderr] 82 |     pub fn has_email(&self, email: &String) -> bool {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/db/user.rs:86:39
[INFO] [stderr]    |
[INFO] [stderr] 86 |     pub fn get_by_email(&self, email: &String) -> Option<&User> {
[INFO] [stderr]    |                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/hasher.rs:38:38
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn validate_password<P, S>(hash: &String, salt: S, password: P) -> bool
[INFO] [stderr]    |                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/handlers/account/login.rs:61:40
[INFO] [stderr]    |
[INFO] [stderr] 61 |             .filter(users::password.eq(new_account.password.clone()))
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 61 |             .filter(users::password.eq(&(*new_account.password).clone()))
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 61 |             .filter(users::password.eq(&str::clone(new_account.password)))
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:55:38
[INFO] [stderr]    |
[INFO] [stderr] 55 |     PgConnection::establish(&db_url).expect(&format!("Error connecting to {}", db_url))
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", db_url))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `howtocards_backend`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "f75edc269635950d196d363f9ead959761483226aac685ff88dfe809c8ab231a"`
[INFO] running `"docker" "rm" "-f" "f75edc269635950d196d363f9ead959761483226aac685ff88dfe809c8ab231a"`
[INFO] [stdout] f75edc269635950d196d363f9ead959761483226aac685ff88dfe809c8ab231a