[INFO] crate howmuch 0.1.2 is already in cache [INFO] extracting crate howmuch 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/howmuch/0.1.2 [INFO] extracting crate howmuch 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/howmuch/0.1.2 [INFO] validating manifest of howmuch-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of howmuch-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing howmuch-0.1.2 [INFO] removed 1 missing examples [INFO] finished frobbing howmuch-0.1.2 [INFO] frobbed toml for howmuch-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/howmuch/0.1.2/Cargo.toml [INFO] started frobbing howmuch-0.1.2 [INFO] removed 1 missing examples [INFO] finished frobbing howmuch-0.1.2 [INFO] frobbed toml for howmuch-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/howmuch/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting howmuch-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/howmuch/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aac3c85bac3c9f9b2067885d9f164715e9f6d00f17d6a1bf3ad35c943279e1c4 [INFO] running `"docker" "start" "-a" "aac3c85bac3c9f9b2067885d9f164715e9f6d00f17d6a1bf3ad35c943279e1c4"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/simple.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking howmuch v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `HowMuch` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> HowMuch { [INFO] [stderr] 48 | | let mut hm = HowMuch { [INFO] [stderr] 49 | | total: Instant::now(), [INFO] [stderr] 50 | | diff: Instant::now(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | hm [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | impl Default for HowMuch { [INFO] [stderr] 47 | fn default() -> Self { [INFO] [stderr] 48 | Self::new() [INFO] [stderr] 49 | } [INFO] [stderr] 50 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:110:50 [INFO] [stderr] | [INFO] [stderr] 110 | Output::Log(ref lvl) => log!(lvl.clone(), "{}", &record), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*lvl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | total = tag.since_begin.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tag.since_begin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:123:34 [INFO] [stderr] | [INFO] [stderr] 123 | Report::Gt(ref v) if &total > v => report(), [INFO] [stderr] | ------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `total` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:124:34 [INFO] [stderr] | [INFO] [stderr] 124 | Report::Ge(ref v) if &total >= v => report(), [INFO] [stderr] | ------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:125:34 [INFO] [stderr] | [INFO] [stderr] 125 | Report::Lt(ref v) if &total < v => report(), [INFO] [stderr] | ------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:126:34 [INFO] [stderr] | [INFO] [stderr] 126 | Report::Le(ref v) if &total <= v => report(), [INFO] [stderr] | ------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `HowMuch` [INFO] [stderr] --> src/lib.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> HowMuch { [INFO] [stderr] 48 | | let mut hm = HowMuch { [INFO] [stderr] 49 | | total: Instant::now(), [INFO] [stderr] 50 | | diff: Instant::now(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | hm [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | impl Default for HowMuch { [INFO] [stderr] 47 | fn default() -> Self { [INFO] [stderr] 48 | Self::new() [INFO] [stderr] 49 | } [INFO] [stderr] 50 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:110:50 [INFO] [stderr] | [INFO] [stderr] 110 | Output::Log(ref lvl) => log!(lvl.clone(), "{}", &record), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*lvl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | total = tag.since_begin.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tag.since_begin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:123:34 [INFO] [stderr] | [INFO] [stderr] 123 | Report::Gt(ref v) if &total > v => report(), [INFO] [stderr] | ------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `total` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:124:34 [INFO] [stderr] | [INFO] [stderr] 124 | Report::Ge(ref v) if &total >= v => report(), [INFO] [stderr] | ------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:125:34 [INFO] [stderr] | [INFO] [stderr] 125 | Report::Lt(ref v) if &total < v => report(), [INFO] [stderr] | ------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:126:34 [INFO] [stderr] | [INFO] [stderr] 126 | Report::Le(ref v) if &total <= v => report(), [INFO] [stderr] | ------^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `"docker" "inspect" "aac3c85bac3c9f9b2067885d9f164715e9f6d00f17d6a1bf3ad35c943279e1c4"` [INFO] running `"docker" "rm" "-f" "aac3c85bac3c9f9b2067885d9f164715e9f6d00f17d6a1bf3ad35c943279e1c4"` [INFO] [stdout] aac3c85bac3c9f9b2067885d9f164715e9f6d00f17d6a1bf3ad35c943279e1c4