[INFO] crate hotmic 0.2.1 is already in cache [INFO] extracting crate hotmic 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/hotmic/0.2.1 [INFO] extracting crate hotmic 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hotmic/0.2.1 [INFO] validating manifest of hotmic-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hotmic-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hotmic-0.2.1 [INFO] finished frobbing hotmic-0.2.1 [INFO] frobbed toml for hotmic-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/hotmic/0.2.1/Cargo.toml [INFO] started frobbing hotmic-0.2.1 [INFO] finished frobbing hotmic-0.2.1 [INFO] frobbed toml for hotmic-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hotmic/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hotmic-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hotmic/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 233a9461f805277b865c4196d5df22bf5a7e02d9bb2ce16d57d8ba03f692bf0e [INFO] running `"docker" "start" "-a" "233a9461f805277b865c4196d5df22bf5a7e02d9bb2ce16d57d8ba03f692bf0e"` [INFO] [stderr] Checking hdrhistogram v6.1.1 [INFO] [stderr] Checking hotmic v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/control.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | Controller { control_tx: control_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | granularity: granularity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `granularity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | buckets: buckets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | num_buckets: num_buckets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | granularity: granularity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `granularity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | conf: conf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | poll: poll, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `poll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | buffer_pool_rx: buffer_pool_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | buffer_pool_tx: buffer_pool_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | data_tx: data_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `data_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | data_rx: data_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `data_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | control_tx: control_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | control_rx: control_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sink.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | buffer_pool_rx: buffer_pool_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sink.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | data_tx: data_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `data_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sink.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | control_tx: control_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sink.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | batch_size: batch_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/control.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | Controller { control_tx: control_tx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | granularity: granularity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `granularity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | buckets: buckets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | num_buckets: num_buckets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data/histogram.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | granularity: granularity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `granularity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | conf: conf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | poll: poll, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `poll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | buffer_pool_rx: buffer_pool_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | buffer_pool_tx: buffer_pool_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | data_tx: data_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `data_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | data_rx: data_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `data_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | control_tx: control_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/receiver.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | control_rx: control_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sink.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | buffer_pool_rx: buffer_pool_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sink.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | data_tx: data_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `data_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sink.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | control_tx: control_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sink.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | batch_size: batch_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/channel.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match self.tx.is_full() { [INFO] [stderr] 76 | | true => Err(SendError::Full(t)), [INFO] [stderr] 77 | | false => { [INFO] [stderr] 78 | | self.tx.send(t); [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 75 | if self.tx.is_full() { Err(SendError::Full(t)) } else { [INFO] [stderr] 76 | self.tx.send(t); [INFO] [stderr] 77 | let _ = self.ctl.mark_send(); [INFO] [stderr] 78 | Ok(()) [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/data/gauge.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match sample { [INFO] [stderr] 26 | | Sample::Value(key, value) => { [INFO] [stderr] 27 | | if let Some(entry) = self.data.get_mut(&key) { [INFO] [stderr] 28 | | *entry = *value; [INFO] [stderr] ... | [INFO] [stderr] 31 | | _ => {}, [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Sample::Value(key, value) = sample { [INFO] [stderr] 26 | if let Some(entry) = self.data.get_mut(&key) { [INFO] [stderr] 27 | *entry = *value; [INFO] [stderr] 28 | } [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/data/histogram.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | let _ = self.data.entry(key).or_insert(WindowedHistogram::new( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 27 | | self.window.clone(), self.granularity.clone() [INFO] [stderr] 28 | | )); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | let _ = self.data.entry(key).or_insert_with(|| WindowedHistogram::new( [INFO] [stderr] 27 | self.window.clone(), self.granularity.clone() [INFO] [stderr] 28 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/data/histogram.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | self.window.clone(), self.granularity.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/data/histogram.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | self.window.clone(), self.granularity.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.granularity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data/histogram.rs:40:69 [INFO] [stderr] | [INFO] [stderr] 40 | let delta = (delta.as_secs() * 1_000_000_000) + delta.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(delta.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::Snapshot` [INFO] [stderr] --> src/data/mod.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> Snapshot { [INFO] [stderr] 124 | | Snapshot { [INFO] [stderr] 125 | | marker: PhantomData, [INFO] [stderr] 126 | | signed_data: FnvHashMap::default(), [INFO] [stderr] 127 | | unsigned_data: FnvHashMap::default(), [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/receiver.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | let _ = buffer_pool_tx.send(Vec::with_capacity(conf.batch_size)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/receiver.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | let _ = self.buffer_pool_tx.send(results); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/receiver.rs:146:41 [INFO] [stderr] | [INFO] [stderr] 146 | / match self.histogram.snapshot(key.clone()) { [INFO] [stderr] 147 | | Some(hs) => { [INFO] [stderr] 148 | | snapshot.set_timing_percentiles(key.clone(), hs, &self.percentiles) [INFO] [stderr] 149 | | }, [INFO] [stderr] 150 | | None => {}, [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(hs) = self.histogram.snapshot(key.clone()) { [INFO] [stderr] 147 | snapshot.set_timing_percentiles(key.clone(), hs, &self.percentiles) [INFO] [stderr] 148 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/receiver.rs:154:41 [INFO] [stderr] | [INFO] [stderr] 154 | / match self.histogram.snapshot(key.clone()) { [INFO] [stderr] 155 | | Some(hs) => { [INFO] [stderr] 156 | | snapshot.set_value_percentiles(key.clone(), hs, &self.percentiles) [INFO] [stderr] 157 | | }, [INFO] [stderr] 158 | | None => {}, [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(hs) = self.histogram.snapshot(key.clone()) { [INFO] [stderr] 155 | snapshot.set_value_percentiles(key.clone(), hs, &self.percentiles) [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/sink.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(io_error("failed to get sample buffer"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io_error("failed to get sample buffer"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helper.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | (d.as_secs() * 1_000_000_000) + d.subsec_nanos() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/benchmark.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/channel.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match self.tx.is_full() { [INFO] [stderr] 76 | | true => Err(SendError::Full(t)), [INFO] [stderr] 77 | | false => { [INFO] [stderr] 78 | | self.tx.send(t); [INFO] [stderr] ... | [INFO] [stderr] 81 | | } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 75 | if self.tx.is_full() { Err(SendError::Full(t)) } else { [INFO] [stderr] 76 | self.tx.send(t); [INFO] [stderr] 77 | let _ = self.ctl.mark_send(); [INFO] [stderr] 78 | Ok(()) [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/data/gauge.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match sample { [INFO] [stderr] 26 | | Sample::Value(key, value) => { [INFO] [stderr] 27 | | if let Some(entry) = self.data.get_mut(&key) { [INFO] [stderr] 28 | | *entry = *value; [INFO] [stderr] ... | [INFO] [stderr] 31 | | _ => {}, [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Sample::Value(key, value) = sample { [INFO] [stderr] 26 | if let Some(entry) = self.data.get_mut(&key) { [INFO] [stderr] 27 | *entry = *value; [INFO] [stderr] 28 | } [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/data/histogram.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | let _ = self.data.entry(key).or_insert(WindowedHistogram::new( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 27 | | self.window.clone(), self.granularity.clone() [INFO] [stderr] 28 | | )); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | let _ = self.data.entry(key).or_insert_with(|| WindowedHistogram::new( [INFO] [stderr] 27 | self.window.clone(), self.granularity.clone() [INFO] [stderr] 28 | )); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/data/histogram.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | self.window.clone(), self.granularity.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/data/histogram.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | self.window.clone(), self.granularity.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.granularity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data/histogram.rs:40:69 [INFO] [stderr] | [INFO] [stderr] 40 | let delta = (delta.as_secs() * 1_000_000_000) + delta.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(delta.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::Snapshot` [INFO] [stderr] --> src/data/mod.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn new() -> Snapshot { [INFO] [stderr] 124 | | Snapshot { [INFO] [stderr] 125 | | marker: PhantomData, [INFO] [stderr] 126 | | signed_data: FnvHashMap::default(), [INFO] [stderr] 127 | | unsigned_data: FnvHashMap::default(), [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/receiver.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | let _ = buffer_pool_tx.send(Vec::with_capacity(conf.batch_size)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/receiver.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | let _ = self.buffer_pool_tx.send(results); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/receiver.rs:146:41 [INFO] [stderr] | [INFO] [stderr] 146 | / match self.histogram.snapshot(key.clone()) { [INFO] [stderr] 147 | | Some(hs) => { [INFO] [stderr] 148 | | snapshot.set_timing_percentiles(key.clone(), hs, &self.percentiles) [INFO] [stderr] 149 | | }, [INFO] [stderr] 150 | | None => {}, [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(hs) = self.histogram.snapshot(key.clone()) { [INFO] [stderr] 147 | snapshot.set_timing_percentiles(key.clone(), hs, &self.percentiles) [INFO] [stderr] 148 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/receiver.rs:154:41 [INFO] [stderr] | [INFO] [stderr] 154 | / match self.histogram.snapshot(key.clone()) { [INFO] [stderr] 155 | | Some(hs) => { [INFO] [stderr] 156 | | snapshot.set_value_percentiles(key.clone(), hs, &self.percentiles) [INFO] [stderr] 157 | | }, [INFO] [stderr] 158 | | None => {}, [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(hs) = self.histogram.snapshot(key.clone()) { [INFO] [stderr] 155 | snapshot.set_value_percentiles(key.clone(), hs, &self.percentiles) [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/sink.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(io_error("failed to get sample buffer"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io_error("failed to get sample buffer"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helper.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | (d.as_secs() * 1_000_000_000) + d.subsec_nanos() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/benchmark.rs:180:34 [INFO] [stderr] | [INFO] [stderr] 180 | (d.as_secs() as f64 * 1e9) + d.subsec_nanos() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.66s [INFO] running `"docker" "inspect" "233a9461f805277b865c4196d5df22bf5a7e02d9bb2ce16d57d8ba03f692bf0e"` [INFO] running `"docker" "rm" "-f" "233a9461f805277b865c4196d5df22bf5a7e02d9bb2ce16d57d8ba03f692bf0e"` [INFO] [stdout] 233a9461f805277b865c4196d5df22bf5a7e02d9bb2ce16d57d8ba03f692bf0e