[INFO] crate hornet 0.1.0 is already in cache [INFO] extracting crate hornet 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/hornet/0.1.0 [INFO] extracting crate hornet 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hornet/0.1.0 [INFO] validating manifest of hornet-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hornet-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hornet-0.1.0 [INFO] finished frobbing hornet-0.1.0 [INFO] frobbed toml for hornet-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/hornet/0.1.0/Cargo.toml [INFO] started frobbing hornet-0.1.0 [INFO] finished frobbing hornet-0.1.0 [INFO] frobbed toml for hornet-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hornet/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hornet-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hornet/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35d41d8755695651438549abd6f18fe8002dca63cf3d5dbbdb59844a223863fe [INFO] running `"docker" "start" "-a" "35d41d8755695651438549abd6f18fe8002dca63cf3d5dbbdb59844a223863fe"` [INFO] [stderr] Checking hdrsample v4.0.0 [INFO] [stderr] Checking hornet v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/counter.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | metric: metric, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `metric` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/counter.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | init_val: init_val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `init_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gauge.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | metric: metric, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `metric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gauge.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | init_val: init_val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `init_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/timer.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | metric: metric, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `metric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/timer.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | time_scale: time_scale, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/countvector.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | im: im, [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/countvector.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | indom: indom, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `indom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/countvector.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | init_vals: init_vals [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gaugevector.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | im: im, [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gaugevector.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | indom: indom, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `indom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gaugevector.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | init_val: init_val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `init_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/histogram.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | im: im, [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/histogram.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | indom: indom, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `indom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/histogram.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | histogram: histogram [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histogram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | pmapi_repr: pmapi_repr [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pmapi_repr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:571:13 [INFO] [stderr] | [INFO] [stderr] 571 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:572:13 [INFO] [stderr] | [INFO] [stderr] 572 | sem: sem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:734:13 [INFO] [stderr] | [INFO] [stderr] 734 | vals: vals, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:735:13 [INFO] [stderr] | [INFO] [stderr] 735 | metric: metric [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `metric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | cluster_id: cluster_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cluster_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | mmv_path: mmv_path [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mmv_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | magic: magic, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `magic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | gen1: gen1, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `gen1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | gen2: gen2, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `gen2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | toc_count: toc_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `toc_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | cluster_id: cluster_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cluster_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | sec: sec, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | sec_offset: sec_offset [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sec_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:373:13 [INFO] [stderr] | [INFO] [stderr] 373 | sem: sem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | unit: unit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | pad: pad, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | instances: instances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:534:13 [INFO] [stderr] | [INFO] [stderr] 534 | pad: pad, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:535:13 [INFO] [stderr] | [INFO] [stderr] 535 | internal_id: internal_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `internal_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:536:13 [INFO] [stderr] | [INFO] [stderr] 536 | external_id: external_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | string: string [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:651:13 [INFO] [stderr] | [INFO] [stderr] 651 | string_toc: string_toc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `string_toc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:652:13 [INFO] [stderr] | [INFO] [stderr] 652 | indom_toc: indom_toc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indom_toc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:653:13 [INFO] [stderr] | [INFO] [stderr] 653 | instance_toc: instance_toc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_toc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:654:13 [INFO] [stderr] | [INFO] [stderr] 654 | indom_blks: indom_blks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indom_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:655:13 [INFO] [stderr] | [INFO] [stderr] 655 | instance_blks: instance_blks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:656:13 [INFO] [stderr] | [INFO] [stderr] 656 | metric_blks: metric_blks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `metric_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:657:13 [INFO] [stderr] | [INFO] [stderr] 657 | value_blks: value_blks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:658:13 [INFO] [stderr] | [INFO] [stderr] 658 | string_blks: string_blks [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `string_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/counter.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | metric: metric, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `metric` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/counter.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | init_val: init_val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `init_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gauge.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | metric: metric, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `metric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gauge.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | init_val: init_val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `init_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/timer.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | metric: metric, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `metric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/timer.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | time_scale: time_scale, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/countvector.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | im: im, [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/countvector.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | indom: indom, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `indom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/countvector.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | init_vals: init_vals [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gaugevector.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | im: im, [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gaugevector.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | indom: indom, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `indom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/gaugevector.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | init_val: init_val [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `init_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/histogram.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | im: im, [INFO] [stderr] | ^^^^^^ help: replace it with: `im` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/histogram.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | indom: indom, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `indom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/histogram.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | histogram: histogram [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histogram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | pmapi_repr: pmapi_repr [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pmapi_repr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:571:13 [INFO] [stderr] | [INFO] [stderr] 571 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:572:13 [INFO] [stderr] | [INFO] [stderr] 572 | sem: sem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:734:13 [INFO] [stderr] | [INFO] [stderr] 734 | vals: vals, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/metric/mod.rs:735:13 [INFO] [stderr] | [INFO] [stderr] 735 | metric: metric [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `metric` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | cluster_id: cluster_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cluster_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | mmv_path: mmv_path [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mmv_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/mmv/mmvfmt.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | magic: magic, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `magic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | gen1: gen1, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `gen1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | gen2: gen2, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `gen2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | toc_count: toc_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `toc_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | cluster_id: cluster_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cluster_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | sec: sec, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | sec_offset: sec_offset [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sec_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:373:13 [INFO] [stderr] | [INFO] [stderr] 373 | sem: sem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | unit: unit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | pad: pad, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | instances: instances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:534:13 [INFO] [stderr] | [INFO] [stderr] 534 | pad: pad, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:535:13 [INFO] [stderr] | [INFO] [stderr] 535 | internal_id: internal_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `internal_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:536:13 [INFO] [stderr] | [INFO] [stderr] 536 | external_id: external_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | string: string [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:651:13 [INFO] [stderr] | [INFO] [stderr] 651 | string_toc: string_toc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `string_toc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:652:13 [INFO] [stderr] | [INFO] [stderr] 652 | indom_toc: indom_toc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indom_toc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:653:13 [INFO] [stderr] | [INFO] [stderr] 653 | instance_toc: instance_toc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_toc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:654:13 [INFO] [stderr] | [INFO] [stderr] 654 | indom_blks: indom_blks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `indom_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:655:13 [INFO] [stderr] | [INFO] [stderr] 655 | instance_blks: instance_blks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:656:13 [INFO] [stderr] | [INFO] [stderr] 656 | metric_blks: metric_blks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `metric_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:657:13 [INFO] [stderr] | [INFO] [stderr] 657 | value_blks: value_blks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mmv/mod.rs:658:13 [INFO] [stderr] | [INFO] [stderr] 658 | string_blks: string_blks [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `string_blks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/client/metric/countvector.rs:111:36 [INFO] [stderr] | [INFO] [stderr] 111 | self.im.set_val(instance, *self.init_vals.get(instance).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.init_vals[instance]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: item `client::metric::histogram::Histogram` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/client/metric/histogram.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / impl Histogram { [INFO] [stderr] 68 | | /// Creates a new histogram metric [INFO] [stderr] 69 | | /// [INFO] [stderr] 70 | | /// Internally creates a corresponding HDR histogram with auto-resizing disabled [INFO] [stderr] ... | [INFO] [stderr] 166 | | pub fn hdr_histogram(&self) -> &HdrHist { &self.histogram } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::metric::private::MMVWriterState` [INFO] [stderr] --> src/client/metric/mod.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn new() -> Self { [INFO] [stderr] 115 | | MMVWriterState { [INFO] [stderr] 116 | | mmap_view: None, [INFO] [stderr] 117 | | [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | #[derive(Default)] [INFO] [stderr] 71 | pub struct MMVWriterState { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(mem::transmute::<$typ, $base_typ>(*self))` [INFO] [stderr] ... [INFO] [stderr] 192 | impl_metric_type_for!(i32, u32, MTCode::I32); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(mem::transmute::<$typ, $base_typ>(*self))` [INFO] [stderr] ... [INFO] [stderr] 193 | impl_metric_type_for!(u32, u32, MTCode::U32); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`u32`) to itself [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 193 | impl_metric_type_for!(u32, u32, MTCode::U32); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`u64`) to itself [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 195 | impl_metric_type_for!(u64, u64, MTCode::U64); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(mem::transmute::<$typ, $base_typ>(*self))` [INFO] [stderr] ... [INFO] [stderr] 196 | impl_metric_type_for!(f32, u32, MTCode::F32); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::metric::Unit` [INFO] [stderr] --> src/client/metric/mod.rs:370:5 [INFO] [stderr] | [INFO] [stderr] 370 | / pub fn new() -> Self { [INFO] [stderr] 371 | | Self::from_raw(0) [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 329 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:398:20 [INFO] [stderr] | [INFO] [stderr] 398 | fn space_scale(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:402:19 [INFO] [stderr] | [INFO] [stderr] 402 | fn time_scale(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:406:20 [INFO] [stderr] | [INFO] [stderr] 406 | fn count_scale(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:421:12 [INFO] [stderr] | [INFO] [stderr] 421 | fn dim(&self, lsb: u8) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:428:18 [INFO] [stderr] | [INFO] [stderr] 428 | fn space_dim(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:432:17 [INFO] [stderr] | [INFO] [stderr] 432 | fn time_dim(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:436:18 [INFO] [stderr] | [INFO] [stderr] 436 | fn count_dim(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/client/metric/mod.rs:641:34 [INFO] [stderr] | [INFO] [stderr] 641 | instances: instances.into_iter().map(|inst| inst.to_string()).collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/client/metric/mod.rs:908:9 [INFO] [stderr] | [INFO] [stderr] 908 | / if !ws.indom_cache.contains_key(&self.indom.id) { [INFO] [stderr] 909 | | ws.n_indoms += 1; [INFO] [stderr] 910 | | ws.n_instances += self.indom.instances.len() as u64; [INFO] [stderr] 911 | | ws.indom_cache.insert(self.indom.id, None); [INFO] [stderr] ... | [INFO] [stderr] 921 | | } [INFO] [stderr] 922 | | } [INFO] [stderr] | |_________^ help: consider using: `ws.indom_cache.entry(self.indom.id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/client/metric/mod.rs:930:30 [INFO] [stderr] | [INFO] [stderr] 930 | fn write_indom_and_instances<'a>(ws: &mut MMVWriterState, c: &mut Cursor<&mut [u8]>, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/metric/mod.rs:935:9 [INFO] [stderr] | [INFO] [stderr] 935 | / if let &Some(ref blk_offs) = blk_offs { [INFO] [stderr] 936 | | return Ok(blk_offs.clone()) [INFO] [stderr] 937 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 935 | if let Some(ref blk_offs) = *blk_offs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/metric/mod.rs:1064:8 [INFO] [stderr] | [INFO] [stderr] 1064 | if string.len() > 0 && !ws.non_value_string_cache.contains_key(string) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/metric/mod.rs:1079:8 [INFO] [stderr] | [INFO] [stderr] 1079 | if string.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client/metric/mod.rs:1091:38 [INFO] [stderr] | [INFO] [stderr] 1091 | if let Some(cached_offset) = ws.non_value_string_cache.get(string).clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ws.non_value_string_cache.get(string)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/metric/mod.rs:1092:13 [INFO] [stderr] | [INFO] [stderr] 1092 | / if let &Some(off) = cached_offset { [INFO] [stderr] 1093 | | return Ok(off); [INFO] [stderr] 1094 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1092 | if let Some(off) = *cached_offset { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client/mod.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | .join(env::var_os("PCP_CONF").unwrap_or(OsString::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var_os("PCP_CONF").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / match RE.captures(&line) { [INFO] [stderr] 101 | | Some(caps) => { [INFO] [stderr] 102 | | match (caps.get(1), caps.get(2)) { [INFO] [stderr] 103 | | (Some(key), Some(val)) => env::set_var( [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let Some(caps) = RE.captures(&line) { [INFO] [stderr] 101 | match (caps.get(1), caps.get(2)) { [INFO] [stderr] 102 | (Some(key), Some(val)) => env::set_var( [INFO] [stderr] 103 | osstr_from_bytes(key.as_bytes()), [INFO] [stderr] 104 | osstr_from_bytes(val.as_bytes()), [INFO] [stderr] 105 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | / match (caps.get(1), caps.get(2)) { [INFO] [stderr] 103 | | (Some(key), Some(val)) => env::set_var( [INFO] [stderr] 104 | | osstr_from_bytes(key.as_bytes()), [INFO] [stderr] 105 | | osstr_from_bytes(val.as_bytes()), [INFO] [stderr] 106 | | ), [INFO] [stderr] 107 | | _ => {} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | if let (Some(key), Some(val)) = (caps.get(1), caps.get(2)) { env::set_var( [INFO] [stderr] 103 | osstr_from_bytes(key.as_bytes()), [INFO] [stderr] 104 | osstr_from_bytes(val.as_bytes()), [INFO] [stderr] 105 | ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/client/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / let mut prev_flag = false; [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | if self.contains(NOPREFIX) { [INFO] [stderr] 165 | | write!(f, "no prefix")?; [INFO] [stderr] 166 | | prev_flag = true; [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let prev_flag = if self.contains(NOPREFIX) { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client/mod.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | file.write(&vec![0; mmv_size])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mmv/mmvfmt.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / match string { [INFO] [stderr] 56 | | &VersionSpecificString::String(ref string) => write!(f, "{}", string), [INFO] [stderr] 57 | | &VersionSpecificString::Offset(ref offset) => { [INFO] [stderr] 58 | | let string = mmv.string_blks().get(offset).unwrap().string(); [INFO] [stderr] 59 | | write!(f, "{}", string) [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | match *string { [INFO] [stderr] 56 | VersionSpecificString::String(ref string) => write!(f, "{}", string), [INFO] [stderr] 57 | VersionSpecificString::Offset(ref offset) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gauge.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(gauge.val(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gauge.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(gauge.val(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gauge.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(gauge.val(), 3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gauge.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(gauge.val(), 3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gauge.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(gauge.val(), 6.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gauge.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(gauge.val(), 6.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gauge.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(gauge.val(), 4.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gauge.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(gauge.val(), 4.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gauge.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(gauge.val(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gauge.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(gauge.val(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/client/metric/countvector.rs:111:36 [INFO] [stderr] | [INFO] [stderr] 111 | self.im.set_val(instance, *self.init_vals.get(instance).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.init_vals[instance]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/mmv/mmvfmt.rs:175:45 [INFO] [stderr] | [INFO] [stderr] 175 | mem::transmute::(value.value() as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(value.value() as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/mmv/mmvfmt.rs:181:45 [INFO] [stderr] | [INFO] [stderr] 181 | mem::transmute::(value.value()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(value.value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(gv.val("a").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(gv.val("a").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | assert_eq!(gv.val("b").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | assert_eq!(gv.val("b").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | assert_eq!(gv.val("c").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | assert_eq!(gv.val("c").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(gv.val("a").unwrap(), 2.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(gv.val("a").unwrap(), 2.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | assert_eq!(gv.val("b").unwrap(), 3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | assert_eq!(gv.val("b").unwrap(), 3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | assert_eq!(gv.val("c").unwrap(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | assert_eq!(gv.val("c").unwrap(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(gv.val("a").unwrap(), 4.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(gv.val("a").unwrap(), 4.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | assert_eq!(gv.val("b").unwrap(), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | assert_eq!(gv.val("b").unwrap(), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | assert_eq!(gv.val("c").unwrap(), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | assert_eq!(gv.val("c").unwrap(), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | assert_eq!(gv.val("a").unwrap(), 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | assert_eq!(gv.val("a").unwrap(), 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | assert_eq!(gv.val("b").unwrap(), 4.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | assert_eq!(gv.val("b").unwrap(), 4.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(gv.val("c").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(gv.val("c").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | assert_eq!(gv.val("b").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | assert_eq!(gv.val("b").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(gv.val("a").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(gv.val("a").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | assert_eq!(gv.val("b").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | assert_eq!(gv.val("b").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/gaugevector.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(gv.val("c").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/gaugevector.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(gv.val("c").unwrap(), 1.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: item `client::metric::histogram::Histogram` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/client/metric/histogram.rs:67:1 [INFO] [stderr] | [INFO] [stderr] 67 | / impl Histogram { [INFO] [stderr] 68 | | /// Creates a new histogram metric [INFO] [stderr] 69 | | /// [INFO] [stderr] 70 | | /// Internally creates a corresponding HDR histogram with auto-resizing disabled [INFO] [stderr] ... | [INFO] [stderr] 166 | | pub fn hdr_histogram(&self) -> &HdrHist { &self.histogram } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/histogram.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / assert_eq!( [INFO] [stderr] 215 | | hist.im.val(MIN_INST).unwrap(), [INFO] [stderr] 216 | | hist.histogram.min() as f64 [INFO] [stderr] 217 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/histogram.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / assert_eq!( [INFO] [stderr] 215 | | hist.im.val(MIN_INST).unwrap(), [INFO] [stderr] 216 | | hist.histogram.min() as f64 [INFO] [stderr] 217 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/histogram.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / assert_eq!( [INFO] [stderr] 220 | | hist.im.val(MAX_INST).unwrap(), [INFO] [stderr] 221 | | hist.histogram.max() as f64 [INFO] [stderr] 222 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/histogram.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / assert_eq!( [INFO] [stderr] 220 | | hist.im.val(MAX_INST).unwrap(), [INFO] [stderr] 221 | | hist.histogram.max() as f64 [INFO] [stderr] 222 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/histogram.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / assert_eq!( [INFO] [stderr] 225 | | hist.im.val(MEAN_INST).unwrap(), [INFO] [stderr] 226 | | hist.histogram.mean() [INFO] [stderr] 227 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/histogram.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / assert_eq!( [INFO] [stderr] 225 | | hist.im.val(MEAN_INST).unwrap(), [INFO] [stderr] 226 | | hist.histogram.mean() [INFO] [stderr] 227 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/histogram.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / assert_eq!( [INFO] [stderr] 230 | | hist.im.val(STDEV_INST).unwrap(), [INFO] [stderr] 231 | | hist.histogram.stdev() [INFO] [stderr] 232 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/histogram.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / assert_eq!( [INFO] [stderr] 230 | | hist.im.val(STDEV_INST).unwrap(), [INFO] [stderr] 231 | | hist.histogram.stdev() [INFO] [stderr] 232 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::metric::private::MMVWriterState` [INFO] [stderr] --> src/client/metric/mod.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn new() -> Self { [INFO] [stderr] 115 | | MMVWriterState { [INFO] [stderr] 116 | | mmap_view: None, [INFO] [stderr] 117 | | [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | #[derive(Default)] [INFO] [stderr] 71 | pub struct MMVWriterState { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(mem::transmute::<$typ, $base_typ>(*self))` [INFO] [stderr] ... [INFO] [stderr] 192 | impl_metric_type_for!(i32, u32, MTCode::I32); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(mem::transmute::<$typ, $base_typ>(*self))` [INFO] [stderr] ... [INFO] [stderr] 193 | impl_metric_type_for!(u32, u32, MTCode::U32); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`u32`) to itself [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 193 | impl_metric_type_for!(u32, u32, MTCode::U32); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a type (`u64`) to itself [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 195 | impl_metric_type_for!(u64, u64, MTCode::U64); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/client/metric/mod.rs:183:25 [INFO] [stderr] | [INFO] [stderr] 183 | mem::transmute::<$typ, $base_typ>(*self) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(mem::transmute::<$typ, $base_typ>(*self))` [INFO] [stderr] ... [INFO] [stderr] 196 | impl_metric_type_for!(f32, u32, MTCode::F32); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `client::metric::Unit` [INFO] [stderr] --> src/client/metric/mod.rs:370:5 [INFO] [stderr] | [INFO] [stderr] 370 | / pub fn new() -> Self { [INFO] [stderr] 371 | | Self::from_raw(0) [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 329 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:398:20 [INFO] [stderr] | [INFO] [stderr] 398 | fn space_scale(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:402:19 [INFO] [stderr] | [INFO] [stderr] 402 | fn time_scale(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:406:20 [INFO] [stderr] | [INFO] [stderr] 406 | fn count_scale(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:421:12 [INFO] [stderr] | [INFO] [stderr] 421 | fn dim(&self, lsb: u8) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:428:18 [INFO] [stderr] | [INFO] [stderr] 428 | fn space_dim(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:432:17 [INFO] [stderr] | [INFO] [stderr] 432 | fn time_dim(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/client/metric/mod.rs:436:18 [INFO] [stderr] | [INFO] [stderr] 436 | fn count_dim(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/client/metric/mod.rs:641:34 [INFO] [stderr] | [INFO] [stderr] 641 | instances: instances.into_iter().map(|inst| inst.to_string()).collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hornet`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/client/metric/mod.rs:908:9 [INFO] [stderr] | [INFO] [stderr] 908 | / if !ws.indom_cache.contains_key(&self.indom.id) { [INFO] [stderr] 909 | | ws.n_indoms += 1; [INFO] [stderr] 910 | | ws.n_instances += self.indom.instances.len() as u64; [INFO] [stderr] 911 | | ws.indom_cache.insert(self.indom.id, None); [INFO] [stderr] ... | [INFO] [stderr] 921 | | } [INFO] [stderr] 922 | | } [INFO] [stderr] | |_________^ help: consider using: `ws.indom_cache.entry(self.indom.id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/client/metric/mod.rs:930:30 [INFO] [stderr] | [INFO] [stderr] 930 | fn write_indom_and_instances<'a>(ws: &mut MMVWriterState, c: &mut Cursor<&mut [u8]>, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/metric/mod.rs:935:9 [INFO] [stderr] | [INFO] [stderr] 935 | / if let &Some(ref blk_offs) = blk_offs { [INFO] [stderr] 936 | | return Ok(blk_offs.clone()) [INFO] [stderr] 937 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 935 | if let Some(ref blk_offs) = *blk_offs { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/metric/mod.rs:1064:8 [INFO] [stderr] | [INFO] [stderr] 1064 | if string.len() > 0 && !ws.non_value_string_cache.contains_key(string) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/metric/mod.rs:1079:8 [INFO] [stderr] | [INFO] [stderr] 1079 | if string.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client/metric/mod.rs:1091:38 [INFO] [stderr] | [INFO] [stderr] 1091 | if let Some(cached_offset) = ws.non_value_string_cache.get(string).clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ws.non_value_string_cache.get(string)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/metric/mod.rs:1092:13 [INFO] [stderr] | [INFO] [stderr] 1092 | / if let &Some(off) = cached_offset { [INFO] [stderr] 1093 | | return Ok(off); [INFO] [stderr] 1094 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1092 | if let Some(off) = *cached_offset { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/metric/mod.rs:1286:9 [INFO] [stderr] | [INFO] [stderr] 1286 | / match m_blk.name() { [INFO] [stderr] 1287 | | &VersionSpecificString::String(ref s) => [INFO] [stderr] 1288 | | panic!("metric name \"{}\" should be in string section", s), [INFO] [stderr] 1289 | | &VersionSpecificString::Offset(ref off) => { [INFO] [stderr] ... | [INFO] [stderr] 1292 | | } [INFO] [stderr] 1293 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1286 | match *m_blk.name() { [INFO] [stderr] 1287 | VersionSpecificString::String(ref s) => [INFO] [stderr] 1288 | panic!("metric name \"{}\" should be in string section", s), [INFO] [stderr] 1289 | VersionSpecificString::Offset(ref off) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/metric/mod.rs:1297:9 [INFO] [stderr] | [INFO] [stderr] 1297 | / match i_blk.external_id() { [INFO] [stderr] 1298 | | &VersionSpecificString::String(ref s) => [INFO] [stderr] 1299 | | panic!("instance \"{}\" should be in string section", s), [INFO] [stderr] 1300 | | &VersionSpecificString::Offset(ref off) => { [INFO] [stderr] ... | [INFO] [stderr] 1303 | | } [INFO] [stderr] 1304 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1297 | match *i_blk.external_id() { [INFO] [stderr] 1298 | VersionSpecificString::String(ref s) => [INFO] [stderr] 1299 | panic!("instance \"{}\" should be in string section", s), [INFO] [stderr] 1300 | VersionSpecificString::Offset(ref off) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/client/metric/mod.rs:1424:13 [INFO] [stderr] | [INFO] [stderr] 1424 | transmute::(freq_slice.read_u64::().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(freq_slice.read_u64::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/client/metric/mod.rs:1421:5 [INFO] [stderr] | [INFO] [stderr] 1421 | / assert_eq!( [INFO] [stderr] 1422 | | new_freq, [INFO] [stderr] 1423 | | unsafe { [INFO] [stderr] 1424 | | transmute::(freq_slice.read_u64::().unwrap()) [INFO] [stderr] 1425 | | } [INFO] [stderr] 1426 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/client/metric/mod.rs:1421:5 [INFO] [stderr] | [INFO] [stderr] 1421 | / assert_eq!( [INFO] [stderr] 1422 | | new_freq, [INFO] [stderr] 1423 | | unsafe { [INFO] [stderr] 1424 | | transmute::(freq_slice.read_u64::().unwrap()) [INFO] [stderr] 1425 | | } [INFO] [stderr] 1426 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/client/mod.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | .join(env::var_os("PCP_CONF").unwrap_or(OsString::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var_os("PCP_CONF").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / match RE.captures(&line) { [INFO] [stderr] 101 | | Some(caps) => { [INFO] [stderr] 102 | | match (caps.get(1), caps.get(2)) { [INFO] [stderr] 103 | | (Some(key), Some(val)) => env::set_var( [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => {} [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let Some(caps) = RE.captures(&line) { [INFO] [stderr] 101 | match (caps.get(1), caps.get(2)) { [INFO] [stderr] 102 | (Some(key), Some(val)) => env::set_var( [INFO] [stderr] 103 | osstr_from_bytes(key.as_bytes()), [INFO] [stderr] 104 | osstr_from_bytes(val.as_bytes()), [INFO] [stderr] 105 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client/mod.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | / match (caps.get(1), caps.get(2)) { [INFO] [stderr] 103 | | (Some(key), Some(val)) => env::set_var( [INFO] [stderr] 104 | | osstr_from_bytes(key.as_bytes()), [INFO] [stderr] 105 | | osstr_from_bytes(val.as_bytes()), [INFO] [stderr] 106 | | ), [INFO] [stderr] 107 | | _ => {} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | if let (Some(key), Some(val)) = (caps.get(1), caps.get(2)) { env::set_var( [INFO] [stderr] 103 | osstr_from_bytes(key.as_bytes()), [INFO] [stderr] 104 | osstr_from_bytes(val.as_bytes()), [INFO] [stderr] 105 | ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/client/mod.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / let mut prev_flag = false; [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | if self.contains(NOPREFIX) { [INFO] [stderr] 165 | | write!(f, "no prefix")?; [INFO] [stderr] 166 | | prev_flag = true; [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let prev_flag = if self.contains(NOPREFIX) { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client/mod.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | file.write(&vec![0; mmv_size])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/client/mod.rs:411:16 [INFO] [stderr] | [INFO] [stderr] 411 | assert_eq!('M' as u8, cursor.read_u8().unwrap()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'M' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/client/mod.rs:412:16 [INFO] [stderr] | [INFO] [stderr] 412 | assert_eq!('M' as u8, cursor.read_u8().unwrap()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'M' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/client/mod.rs:413:16 [INFO] [stderr] | [INFO] [stderr] 413 | assert_eq!('V' as u8, cursor.read_u8().unwrap()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'V' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/client/mod.rs:438:10 [INFO] [stderr] | [INFO] [stderr] 438 | .expect(&format!("{} not set", PCP_TMP_DIR_KEY)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{} not set", PCP_TMP_DIR_KEY))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/client/mod.rs:486:27 [INFO] [stderr] | [INFO] [stderr] 486 | env::var(key).expect(&format!("{} not set", key)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} not set", key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mmv/mmvfmt.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / match string { [INFO] [stderr] 56 | | &VersionSpecificString::String(ref string) => write!(f, "{}", string), [INFO] [stderr] 57 | | &VersionSpecificString::Offset(ref offset) => { [INFO] [stderr] 58 | | let string = mmv.string_blks().get(offset).unwrap().string(); [INFO] [stderr] 59 | | write!(f, "{}", string) [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | match *string { [INFO] [stderr] 56 | VersionSpecificString::String(ref string) => write!(f, "{}", string), [INFO] [stderr] 57 | VersionSpecificString::Offset(ref offset) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/mmv/mmvfmt.rs:175:45 [INFO] [stderr] | [INFO] [stderr] 175 | mem::transmute::(value.value() as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(value.value() as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/mmv/mmvfmt.rs:181:45 [INFO] [stderr] | [INFO] [stderr] 181 | mem::transmute::(value.value()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(value.value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] error: aborting due to 27 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `hornet`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "35d41d8755695651438549abd6f18fe8002dca63cf3d5dbbdb59844a223863fe"` [INFO] running `"docker" "rm" "-f" "35d41d8755695651438549abd6f18fe8002dca63cf3d5dbbdb59844a223863fe"` [INFO] [stdout] 35d41d8755695651438549abd6f18fe8002dca63cf3d5dbbdb59844a223863fe