[INFO] crate home 0.3.3 is already in cache [INFO] extracting crate home 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/home/0.3.3 [INFO] extracting crate home 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/home/0.3.3 [INFO] validating manifest of home-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of home-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing home-0.3.3 [INFO] finished frobbing home-0.3.3 [INFO] frobbed toml for home-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/home/0.3.3/Cargo.toml [INFO] started frobbing home-0.3.3 [INFO] finished frobbing home-0.3.3 [INFO] frobbed toml for home-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/home/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting home-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/home/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 81dc10492d0aeec1fcfd0d3bfdbe81ec64d4d1d9346e9b759a3ccf8194c6faad [INFO] running `"docker" "start" "-a" "81dc10492d0aeec1fcfd0d3bfdbe81ec64d4d1d9346e9b759a3ccf8194c6faad"` [INFO] [stderr] Checking home v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:212:12 [INFO] [stderr] | [INFO] [stderr] 212 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 213 | | if let Some(d) = compat_user_home { [INFO] [stderr] 214 | | if d.exists() { [INFO] [stderr] 215 | | Ok(d) [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 212 | } else if let Some(d) = compat_user_home { [INFO] [stderr] 213 | if d.exists() { [INFO] [stderr] 214 | Ok(d) [INFO] [stderr] 215 | } else { [INFO] [stderr] 216 | user_home [INFO] [stderr] 217 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | ::std::env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:207:27 [INFO] [stderr] | [INFO] [stderr] 207 | let compat_home_dir = ::std::env::home_dir(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:203:10 [INFO] [stderr] | [INFO] [stderr] 203 | .ok_or(io::Error::new(io::ErrorKind::Other, "couldn't find home dir")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::Other, "couldn't find home dir"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:257:10 [INFO] [stderr] | [INFO] [stderr] 257 | .ok_or(io::Error::new(io::ErrorKind::Other, "couldn't find home dir")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::Other, "couldn't find home dir"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:212:12 [INFO] [stderr] | [INFO] [stderr] 212 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 213 | | if let Some(d) = compat_user_home { [INFO] [stderr] 214 | | if d.exists() { [INFO] [stderr] 215 | | Ok(d) [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 212 | } else if let Some(d) = compat_user_home { [INFO] [stderr] 213 | if d.exists() { [INFO] [stderr] 214 | Ok(d) [INFO] [stderr] 215 | } else { [INFO] [stderr] 216 | user_home [INFO] [stderr] 217 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | ::std::env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:207:27 [INFO] [stderr] | [INFO] [stderr] 207 | let compat_home_dir = ::std::env::home_dir(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:203:10 [INFO] [stderr] | [INFO] [stderr] 203 | .ok_or(io::Error::new(io::ErrorKind::Other, "couldn't find home dir")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::Other, "couldn't find home dir"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:257:10 [INFO] [stderr] | [INFO] [stderr] 257 | .ok_or(io::Error::new(io::ErrorKind::Other, "couldn't find home dir")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::Other, "couldn't find home dir"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "81dc10492d0aeec1fcfd0d3bfdbe81ec64d4d1d9346e9b759a3ccf8194c6faad"` [INFO] running `"docker" "rm" "-f" "81dc10492d0aeec1fcfd0d3bfdbe81ec64d4d1d9346e9b759a3ccf8194c6faad"` [INFO] [stdout] 81dc10492d0aeec1fcfd0d3bfdbe81ec64d4d1d9346e9b759a3ccf8194c6faad