[INFO] crate holyhashmap 0.1.1 is already in cache
[INFO] extracting crate holyhashmap 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/holyhashmap/0.1.1
[INFO] extracting crate holyhashmap 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/holyhashmap/0.1.1
[INFO] validating manifest of holyhashmap-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of holyhashmap-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing holyhashmap-0.1.1
[INFO] finished frobbing holyhashmap-0.1.1
[INFO] frobbed toml for holyhashmap-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/holyhashmap/0.1.1/Cargo.toml
[INFO] started frobbing holyhashmap-0.1.1
[INFO] finished frobbing holyhashmap-0.1.1
[INFO] frobbed toml for holyhashmap-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/holyhashmap/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting holyhashmap-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/holyhashmap/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 19e201b6766f66fed2f7d02b052d0745e2025d1afd3ee6978fb41214db3fb41a
[INFO] running `"docker" "start" "-a" "19e201b6766f66fed2f7d02b052d0745e2025d1afd3ee6978fb41214db3fb41a"`
[INFO] [stderr]     Checking holyhashmap v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:305:9
[INFO] [stderr]     |
[INFO] [stderr] 305 |         result
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:300:22
[INFO] [stderr]     |
[INFO] [stderr] 300 |         let result = self.inner.insert_full(hash, key, value);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:353:9
[INFO] [stderr]     |
[INFO] [stderr] 353 |         result
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:348:22
[INFO] [stderr]     |
[INFO] [stderr] 348 |         let result = self.inner.remove(hash, key);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:376:13
[INFO] [stderr]     |
[INFO] [stderr] 376 |             result
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:371:26
[INFO] [stderr]     |
[INFO] [stderr] 371 |             let result = self.inner.remove_index(hash, index);
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:250:23
[INFO] [stderr]     |
[INFO] [stderr] 250 |     pub fn from_index(&self, index: EntryIndex) -> Option<(&K, &V)> {
[INFO] [stderr]     |                       ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:260:9
[INFO] [stderr]     |
[INFO] [stderr] 260 |         &mut self,
[INFO] [stderr]     |         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:689:23
[INFO] [stderr]     |
[INFO] [stderr] 689 |     pub fn from_index(&self, index: EntryIndex) -> Option<(&K, &V)> {
[INFO] [stderr]     |                       ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:696:9
[INFO] [stderr]     |
[INFO] [stderr] 696 |         &mut self,
[INFO] [stderr]     |         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:250:23
[INFO] [stderr]     |
[INFO] [stderr] 250 |     pub fn from_index(&self, index: EntryIndex) -> Option<(&K, &V)> {
[INFO] [stderr]     |                       ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:260:9
[INFO] [stderr]     |
[INFO] [stderr] 260 |         &mut self,
[INFO] [stderr]     |         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/lib.rs:399:25
[INFO] [stderr]     |
[INFO] [stderr] 399 |                   assert!(match self.inner.entries[bucket.index.0] {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 400 | |                     None => false,
[INFO] [stderr] 401 | |                     Some(_) => true,
[INFO] [stderr] 402 | |                 });
[INFO] [stderr]     | |_________________^ help: try this: `self.inner.entries[bucket.index.0].is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:689:23
[INFO] [stderr]     |
[INFO] [stderr] 689 |     pub fn from_index(&self, index: EntryIndex) -> Option<(&K, &V)> {
[INFO] [stderr]     |                       ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:696:9
[INFO] [stderr]     |
[INFO] [stderr] 696 |         &mut self,
[INFO] [stderr]     |         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]     --> src/lib.rs:1854:5
[INFO] [stderr]      |
[INFO] [stderr] 1854 | /     fn test_lots_of_insertions() {
[INFO] [stderr] 1855 | |         let mut m = HashMap::new();
[INFO] [stderr] 1856 | |
[INFO] [stderr] 1857 | |         // Try this a few times to make sure we never screw up the hashmap's
[INFO] [stderr] ...    |
[INFO] [stderr] 1915 | |         }
[INFO] [stderr] 1916 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]      = help: you could split it up into multiple smaller functions
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]     --> src/lib.rs:1865:26
[INFO] [stderr]      |
[INFO] [stderr] 1865 |                 for j in 1..i + 1 {
[INFO] [stderr]      |                          ^^^^^^^^ help: use: `1..=i`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]     --> src/lib.rs:1886:26
[INFO] [stderr]      |
[INFO] [stderr] 1886 |                 for j in 1..i + 1 {
[INFO] [stderr]      |                          ^^^^^^^^ help: use: `1..=i`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]     --> src/lib.rs:2003:9
[INFO] [stderr]      |
[INFO] [stderr] 2003 |         map[&4];
[INFO] [stderr]      |         ^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]     --> src/lib.rs:2141:18
[INFO] [stderr]      |
[INFO] [stderr] 2141 |         a.insert(key.clone(), value.clone());
[INFO] [stderr]      |                  ^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]      |
[INFO] [stderr] 2141 |         a.insert(&(*key).clone(), value.clone());
[INFO] [stderr]      |                  ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]      |
[INFO] [stderr] 2141 |         a.insert(&str::clone(key), value.clone());
[INFO] [stderr]      |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]     --> src/lib.rs:2141:31
[INFO] [stderr]      |
[INFO] [stderr] 2141 |         a.insert(key.clone(), value.clone());
[INFO] [stderr]      |                               ^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]      |
[INFO] [stderr] 2141 |         a.insert(key.clone(), &(*value).clone());
[INFO] [stderr]      |                               ^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]      |
[INFO] [stderr] 2141 |         a.insert(key.clone(), &str::clone(value));
[INFO] [stderr]      |                               ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]     --> src/lib.rs:2145:23
[INFO] [stderr]      |
[INFO] [stderr] 2145 |         match a.entry(key.clone()) {
[INFO] [stderr]      |                       ^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]      |
[INFO] [stderr] 2145 |         match a.entry(&(*key).clone()) {
[INFO] [stderr]      |                       ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]      |
[INFO] [stderr] 2145 |         match a.entry(&str::clone(key)) {
[INFO] [stderr]      |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]     --> src/lib.rs:2160:23
[INFO] [stderr]      |
[INFO] [stderr] 2160 |         match a.entry(key.clone()) {
[INFO] [stderr]      |                       ^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]      |
[INFO] [stderr] 2160 |         match a.entry(&(*key).clone()) {
[INFO] [stderr]      |                       ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]      |
[INFO] [stderr] 2160 |         match a.entry(&str::clone(key)) {
[INFO] [stderr]      |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]     --> src/lib.rs:2164:26
[INFO] [stderr]      |
[INFO] [stderr] 2164 |                 e.insert(value.clone());
[INFO] [stderr]      |                          ^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]      |
[INFO] [stderr] 2164 |                 e.insert(&(*value).clone());
[INFO] [stderr]      |                          ^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]      |
[INFO] [stderr] 2164 |                 e.insert(&str::clone(value));
[INFO] [stderr]      |                          ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `holyhashmap`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "19e201b6766f66fed2f7d02b052d0745e2025d1afd3ee6978fb41214db3fb41a"`
[INFO] running `"docker" "rm" "-f" "19e201b6766f66fed2f7d02b052d0745e2025d1afd3ee6978fb41214db3fb41a"`
[INFO] [stdout] 19e201b6766f66fed2f7d02b052d0745e2025d1afd3ee6978fb41214db3fb41a