[INFO] crate hivm2 0.0.2 is already in cache [INFO] extracting crate hivm2 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/hivm2/0.0.2 [INFO] extracting crate hivm2 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hivm2/0.0.2 [INFO] validating manifest of hivm2-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hivm2-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hivm2-0.0.2 [INFO] finished frobbing hivm2-0.0.2 [INFO] frobbed toml for hivm2-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/hivm2/0.0.2/Cargo.toml [INFO] started frobbing hivm2-0.0.2 [INFO] finished frobbing hivm2-0.0.2 [INFO] frobbed toml for hivm2-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hivm2/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hivm2-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hivm2/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fee83aa7cfb1dba79518eeba4b443f8ed877b7f7e26c4f4a40d09bfc150c7e1d [INFO] running `"docker" "start" "-a" "fee83aa7cfb1dba79518eeba4b443f8ed877b7f7e26c4f4a40d09bfc150c7e1d"` [INFO] [stderr] Checking hivm2 v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | Program { stmts: stmts } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stmts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | BasicBlock { stmts: stmts, } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stmts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | Ok(Path { segments: segments }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:159:15 [INFO] [stderr] | [INFO] [stderr] 159 | Mod { path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:170:18 [INFO] [stderr] | [INFO] [stderr] 170 | Extern { path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | constructor: constructor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constructor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | argument: argument, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `argument` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:198:18 [INFO] [stderr] | [INFO] [stderr] 198 | Static { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | Local { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | lvalue: lvalue, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lvalue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | rvalue: rvalue, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rvalue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:273:14 [INFO] [stderr] | [INFO] [stderr] 273 | Fn { parameters: parameters, body: body, } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:273:38 [INFO] [stderr] | [INFO] [stderr] 273 | Fn { parameters: parameters, body: body, } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:284:18 [INFO] [stderr] | [INFO] [stderr] 284 | Return { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | Program { stmts: stmts } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stmts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | BasicBlock { stmts: stmts, } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stmts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:137:19 [INFO] [stderr] | [INFO] [stderr] 137 | Ok(Path { segments: segments }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:159:15 [INFO] [stderr] | [INFO] [stderr] 159 | Mod { path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:170:18 [INFO] [stderr] | [INFO] [stderr] 170 | Extern { path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | constructor: constructor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constructor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | argument: argument, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `argument` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:198:18 [INFO] [stderr] | [INFO] [stderr] 198 | Static { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | Local { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | lvalue: lvalue, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lvalue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | rvalue: rvalue, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rvalue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:273:14 [INFO] [stderr] | [INFO] [stderr] 273 | Fn { parameters: parameters, body: body, } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:273:38 [INFO] [stderr] | [INFO] [stderr] 273 | Fn { parameters: parameters, body: body, } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:284:18 [INFO] [stderr] | [INFO] [stderr] 284 | Return { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/asm/mod.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm/mod.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return Path::new(segments) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Path::new(segments)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/asm_parser/parser.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | ||{ () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm_parser/util.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return IResult::Error( [INFO] [stderr] 27 | | NomErr::Position(ErrorKind::Alt, input) [INFO] [stderr] 28 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | IResult::Error( [INFO] [stderr] 27 | NomErr::Position(ErrorKind::Alt, input) [INFO] [stderr] 28 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm/mod.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return Path::new(segments) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Path::new(segments)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/asm_parser/parser.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | ||{ () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/asm_parser/parser.rs:338:19 [INFO] [stderr] | [INFO] [stderr] 338 | const EMPTY: &'static [u8] = b""; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/asm_parser/util.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return IResult::Error( [INFO] [stderr] 27 | | NomErr::Position(ErrorKind::Alt, input) [INFO] [stderr] 28 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | IResult::Error( [INFO] [stderr] 27 | NomErr::Position(ErrorKind::Alt, input) [INFO] [stderr] 28 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `asm::Program` [INFO] [stderr] --> src/asm/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Program { [INFO] [stderr] 10 | | Program { [INFO] [stderr] 11 | | stmts: Vec::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm/mod.rs:123:40 [INFO] [stderr] | [INFO] [stderr] 123 | if segment.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm/mod.rs:129:40 [INFO] [stderr] | [INFO] [stderr] 129 | if segment.starts_with("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/asm/mod.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 145 | | let parts = s.split('.'); [INFO] [stderr] 146 | | let segments = parts.map(|p| p.to_string() ).collect(); [INFO] [stderr] 147 | | [INFO] [stderr] 148 | | return Path::new(segments) [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/asm/mod.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | / pub fn from_str(op: &str) -> Result { [INFO] [stderr] 221 | | match op { [INFO] [stderr] 222 | | "=" => Ok(AssignmentOp::Plain), [INFO] [stderr] 223 | | ":=" => Ok(AssignmentOp::AllocateAndAssign), [INFO] [stderr] 224 | | _ => Err(ParseError::InvalidOperator(op)), [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/asm_parser/parser.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | if remaining.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/asm_parser/util.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match result { [INFO] [stderr] 21 | | IResult::Done(_, _) => { return result }, [INFO] [stderr] 22 | | _ => (), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ help: try this: `if let IResult::Done(_, _) = result { return result }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `asm::Program` [INFO] [stderr] --> src/asm/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Program { [INFO] [stderr] 10 | | Program { [INFO] [stderr] 11 | | stmts: Vec::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm/mod.rs:123:40 [INFO] [stderr] | [INFO] [stderr] 123 | if segment.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/asm/mod.rs:129:40 [INFO] [stderr] | [INFO] [stderr] 129 | if segment.starts_with("$") { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/asm/mod.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 145 | | let parts = s.split('.'); [INFO] [stderr] 146 | | let segments = parts.map(|p| p.to_string() ).collect(); [INFO] [stderr] 147 | | [INFO] [stderr] 148 | | return Path::new(segments) [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/asm/mod.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | / pub fn from_str(op: &str) -> Result { [INFO] [stderr] 221 | | match op { [INFO] [stderr] 222 | | "=" => Ok(AssignmentOp::Plain), [INFO] [stderr] 223 | | ":=" => Ok(AssignmentOp::AllocateAndAssign), [INFO] [stderr] 224 | | _ => Err(ParseError::InvalidOperator(op)), [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/asm_parser/parser.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | if remaining.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remaining.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/asm_parser/util.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match result { [INFO] [stderr] 21 | | IResult::Done(_, _) => { return result }, [INFO] [stderr] 22 | | _ => (), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ help: try this: `if let IResult::Done(_, _) = result { return result }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/asm_parser/util.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | IResult::Done("c".as_bytes(), Some("ab".as_bytes())) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"c"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/asm_parser/util.rs:105:48 [INFO] [stderr] | [INFO] [stderr] 105 | IResult::Done("c".as_bytes(), Some("ab".as_bytes())) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/asm_parser/util.rs:113:27 [INFO] [stderr] | [INFO] [stderr] 113 | IResult::Done("abc".as_bytes(), None) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/asm_parser/util.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | ||{ "abc".as_bytes() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/asm_parser/util.rs:136:27 [INFO] [stderr] | [INFO] [stderr] 136 | IResult::Done("".as_bytes(), "ab".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/asm_parser/util.rs:136:42 [INFO] [stderr] | [INFO] [stderr] 136 | IResult::Done("".as_bytes(), "ab".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ab"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/asm_parser/util.rs:150:61 [INFO] [stderr] | [INFO] [stderr] 150 | IResult::Error(NomErr::Position(ErrorKind::Alt, "cd".as_bytes())) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"cd"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.02s [INFO] running `"docker" "inspect" "fee83aa7cfb1dba79518eeba4b443f8ed877b7f7e26c4f4a40d09bfc150c7e1d"` [INFO] running `"docker" "rm" "-f" "fee83aa7cfb1dba79518eeba4b443f8ed877b7f7e26c4f4a40d09bfc150c7e1d"` [INFO] [stdout] fee83aa7cfb1dba79518eeba4b443f8ed877b7f7e26c4f4a40d09bfc150c7e1d