[INFO] crate hey_listen 0.2.1 is already in cache [INFO] extracting crate hey_listen 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/hey_listen/0.2.1 [INFO] extracting crate hey_listen 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hey_listen/0.2.1 [INFO] validating manifest of hey_listen-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hey_listen-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hey_listen-0.2.1 [INFO] finished frobbing hey_listen-0.2.1 [INFO] frobbed toml for hey_listen-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/hey_listen/0.2.1/Cargo.toml [INFO] started frobbing hey_listen-0.2.1 [INFO] finished frobbing hey_listen-0.2.1 [INFO] frobbed toml for hey_listen-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hey_listen/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hey_listen-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hey_listen/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6154a5615c52f31d58ff6100267ec603859e5f478826a29ad16d8b1fd8a4dc26 [INFO] running `"docker" "start" "-a" "6154a5615c52f31d58ff6100267ec603859e5f478826a29ad16d8b1fd8a4dc26"` [INFO] [stderr] Compiling hey_listen v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/sync/parallel_dispatcher.rs:311:29 [INFO] [stderr] | [INFO] [stderr] 311 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/sync/parallel_dispatcher.rs:311:29 [INFO] [stderr] | [INFO] [stderr] 311 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rc/mod.rs:107:36 [INFO] [stderr] | [INFO] [stderr] 107 | fn map_usize_to_request(x: &usize) -> Option { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sync/mod.rs:143:36 [INFO] [stderr] | [INFO] [stderr] 143 | fn map_usize_to_request(x: &usize) -> Option { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `EventVariant` [INFO] [stderr] --> examples/rc_dispatcher.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / enum EventEnum { [INFO] [stderr] 23 | | EventVariantA, [INFO] [stderr] 24 | | EventVariantB, [INFO] [stderr] 25 | | EventVariantC, [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `EventVariant` [INFO] [stderr] --> examples/sync_dispatcher.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / enum EventEnum { [INFO] [stderr] 23 | | EventVariantA, [INFO] [stderr] 24 | | EventVariantB, [INFO] [stderr] 25 | | EventVariantC, [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match to destructure a single infallible pattern. Consider using `let` [INFO] [stderr] --> tests/sync_listener_test.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / let enum_field = match *listener.lock().deref() { [INFO] [stderr] 51 | | EnumListener::SomeVariant(x) => x, [INFO] [stderr] 52 | | }; [INFO] [stderr] | |______^ help: try this: `let EnumListener::SomeVariant(enum_field) = *listener.lock().deref();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::infallible_destructuring_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#infallible_destructuring_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.29s [INFO] running `"docker" "inspect" "6154a5615c52f31d58ff6100267ec603859e5f478826a29ad16d8b1fd8a4dc26"` [INFO] running `"docker" "rm" "-f" "6154a5615c52f31d58ff6100267ec603859e5f478826a29ad16d8b1fd8a4dc26"` [INFO] [stdout] 6154a5615c52f31d58ff6100267ec603859e5f478826a29ad16d8b1fd8a4dc26