[INFO] crate hexe_core 0.0.5 is already in cache [INFO] extracting crate hexe_core 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/hexe_core/0.0.5 [INFO] extracting crate hexe_core 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hexe_core/0.0.5 [INFO] validating manifest of hexe_core-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hexe_core-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hexe_core-0.0.5 [INFO] finished frobbing hexe_core-0.0.5 [INFO] frobbed toml for hexe_core-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/hexe_core/0.0.5/Cargo.toml [INFO] started frobbing hexe_core-0.0.5 [INFO] finished frobbing hexe_core-0.0.5 [INFO] frobbed toml for hexe_core-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hexe_core/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hexe_core-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hexe_core/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13e9446686c8f61936159fae69e96dc5a512294125635225151735a2b0bee142 [INFO] running `"docker" "start" "-a" "13e9446686c8f61936159fae69e96dc5a512294125635225151735a2b0bee142"` [INFO] [stderr] Checking uncon v1.1.0 [INFO] [stderr] Compiling uncon_derive v1.1.1 [INFO] [stderr] Checking hexe_core v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | #![allow(cast_lossless)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `explicit_into_iter_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | #![allow(explicit_into_iter_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::explicit_into_iter_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | #![allow(inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | #![allow(needless_lifetimes)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:39:10 [INFO] [stderr] | [INFO] [stderr] 39 | #![allow(redundant_field_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | #![allow(suspicious_arithmetic_impl)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | #![allow(unreadable_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `verbose_bit_mask` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:42:10 [INFO] [stderr] | [INFO] [stderr] 42 | #![allow(verbose_bit_mask)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change it to: `clippy::verbose_bit_mask` [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_prefixed_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:43:10 [INFO] [stderr] | [INFO] [stderr] 43 | #![allow(zero_prefixed_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::zero_prefixed_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `bool_comparison` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | #![deny(bool_comparison)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::bool_comparison` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | #![allow(cast_lossless)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `explicit_into_iter_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:36:10 [INFO] [stderr] | [INFO] [stderr] 36 | #![allow(explicit_into_iter_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::explicit_into_iter_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | #![allow(inline_always)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | #![allow(needless_lifetimes)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:39:10 [INFO] [stderr] | [INFO] [stderr] 39 | #![allow(redundant_field_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:40:10 [INFO] [stderr] | [INFO] [stderr] 40 | #![allow(suspicious_arithmetic_impl)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | #![allow(unreadable_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `verbose_bit_mask` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:42:10 [INFO] [stderr] | [INFO] [stderr] 42 | #![allow(verbose_bit_mask)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change it to: `clippy::verbose_bit_mask` [INFO] [stderr] [INFO] [stderr] warning: lint name `zero_prefixed_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:43:10 [INFO] [stderr] | [INFO] [stderr] 43 | #![allow(zero_prefixed_literal)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::zero_prefixed_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `bool_comparison` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | #![deny(bool_comparison)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::bool_comparison` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | #![allow(cast_lossless)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | #![allow(cast_lossless)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board/bitboard/mod.rs:437:49 [INFO] [stderr] | [INFO] [stderr] 437 | pub fn map_str T>(&self, f: F) -> T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/board/piece_map/mod.rs:471:19 [INFO] [stderr] | [INFO] [stderr] 471 | let ptr = &mut buf[start_sq as usize] as *mut u8 as *mut u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/castle.rs:180:49 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn map_str T>(&self, f: F) -> T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/iter.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | const ALL: Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `iter::Range` to be `Copy` [INFO] [stderr] --> src/iter.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | const ALL: Range; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/piece.rs:223:25 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn is_promotion(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/square/mod.rs:536:26 [INFO] [stderr] | [INFO] [stderr] 536 | pub fn adjacent_mask(&self) -> Bitboard { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/square/mod.rs:590:26 [INFO] [stderr] | [INFO] [stderr] 590 | pub fn adjacent_mask(&self) -> Bitboard { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/util/count.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | chunks.into_iter().fold(0usize, |sums, chunk| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `hexe_core`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: function is never used: `rand_pairs` [INFO] [stderr] --> src/util/mod.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn rand_pairs() -> [(T, U); 1000] [INFO] [stderr] 21 | | where T: ::rand::Rand, [INFO] [stderr] 22 | | U: ::rand::Rand, [INFO] [stderr] 23 | | { [INFO] [stderr] ... | [INFO] [stderr] 31 | | pairs [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board/bitboard/mod.rs:437:49 [INFO] [stderr] | [INFO] [stderr] 437 | pub fn map_str T>(&self, f: F) -> T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/board/piece_map/tests.rs:148:1 [INFO] [stderr] | [INFO] [stderr] 148 | / fn castle() { [INFO] [stderr] 149 | | fn affected_range(right: Right) -> ops::Range { [INFO] [stderr] 150 | | match right { [INFO] [stderr] 151 | | Right::WhiteKing => 4..8, [INFO] [stderr] ... | [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/board/piece_map/mod.rs:471:19 [INFO] [stderr] | [INFO] [stderr] 471 | let ptr = &mut buf[start_sq as usize] as *mut u8 as *mut u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/castle.rs:180:49 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn map_str T>(&self, f: F) -> T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/iter.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | const ALL: Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `iter::Range` to be `Copy` [INFO] [stderr] --> src/iter.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | const ALL: Range; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/piece.rs:223:25 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn is_promotion(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/square/mod.rs:536:26 [INFO] [stderr] | [INFO] [stderr] 536 | pub fn adjacent_mask(&self) -> Bitboard { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/square/mod.rs:590:26 [INFO] [stderr] | [INFO] [stderr] 590 | pub fn adjacent_mask(&self) -> Bitboard { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square/mod.rs:751:19 [INFO] [stderr] | [INFO] [stderr] 751 | for ch in b'A'..(b'F' + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `b'A'..=b'F'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/square/mod.rs:760:19 [INFO] [stderr] | [INFO] [stderr] 760 | for ch in b'1'..(b'8' + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `b'1'..=b'8'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/util/count.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | chunks.into_iter().fold(0usize, |sums, chunk| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `hexe_core`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "13e9446686c8f61936159fae69e96dc5a512294125635225151735a2b0bee142"` [INFO] running `"docker" "rm" "-f" "13e9446686c8f61936159fae69e96dc5a512294125635225151735a2b0bee142"` [INFO] [stdout] 13e9446686c8f61936159fae69e96dc5a512294125635225151735a2b0bee142