[INFO] crate hexchat-plugin 0.2.10 is already in cache
[INFO] extracting crate hexchat-plugin 0.2.10 into work/ex/clippy-test-run/sources/stable/reg/hexchat-plugin/0.2.10
[INFO] extracting crate hexchat-plugin 0.2.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hexchat-plugin/0.2.10
[INFO] validating manifest of hexchat-plugin-0.2.10 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hexchat-plugin-0.2.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hexchat-plugin-0.2.10
[INFO] finished frobbing hexchat-plugin-0.2.10
[INFO] frobbed toml for hexchat-plugin-0.2.10 written to work/ex/clippy-test-run/sources/stable/reg/hexchat-plugin/0.2.10/Cargo.toml
[INFO] started frobbing hexchat-plugin-0.2.10
[INFO] finished frobbing hexchat-plugin-0.2.10
[INFO] frobbed toml for hexchat-plugin-0.2.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hexchat-plugin/0.2.10/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hexchat-plugin-0.2.10 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hexchat-plugin/0.2.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ec4ce332a5f2e336406c31adc3ecf385ac2f5b465c64a97a2d1bf8382d0ccb79
[INFO] running `"docker" "start" "-a" "ec4ce332a5f2e336406c31adc3ecf385ac2f5b465c64a97a2d1bf8382d0ccb79"`
[INFO] [stderr]     Checking hexchat-plugin v0.2.10 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `ph`
[INFO] [stderr]     --> src/lib.rs:1249:59
[INFO] [stderr]      |
[INFO] [stderr] 1249 |     closure.set(Some(ph.hook_print("Close Context", move |ph, _| {
[INFO] [stderr]      |                                                           ^^ help: consider using `_ph` instead
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `filename`
[INFO] [stderr]     --> src/lib.rs:1418:9
[INFO] [stderr]      |
[INFO] [stderr] 1418 |     let filename = if !(*plugin_name).is_null() {
[INFO] [stderr]      |         ^^^^^^^^ help: consider using `_filename` instead
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `HexchatEventAttrsHelper`
[INFO] [stderr]     --> src/lib.rs:1278:1
[INFO] [stderr]      |
[INFO] [stderr] 1278 | struct HexchatEventAttrsHelper(*mut internals::HexchatEventAttrs, *mut internals::Ph);
[INFO] [stderr]      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]     --> src/lib.rs:1281:5
[INFO] [stderr]      |
[INFO] [stderr] 1281 |     fn new(ph: *mut internals::Ph) -> Self {
[INFO] [stderr]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new_with`
[INFO] [stderr]     --> src/lib.rs:1285:5
[INFO] [stderr]      |
[INFO] [stderr] 1285 |     fn new_with(ph: *mut internals::Ph, attrs: EventAttrs) -> Self {
[INFO] [stderr]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ph`
[INFO] [stderr]     --> src/lib.rs:1249:59
[INFO] [stderr]      |
[INFO] [stderr] 1249 |     closure.set(Some(ph.hook_print("Close Context", move |ph, _| {
[INFO] [stderr]      |                                                           ^^ help: consider using `_ph` instead
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `filename`
[INFO] [stderr]     --> src/lib.rs:1418:9
[INFO] [stderr]      |
[INFO] [stderr] 1418 |     let filename = if !(*plugin_name).is_null() {
[INFO] [stderr]      |         ^^^^^^^^ help: consider using `_filename` instead
[INFO] [stderr] 
[INFO] [stderr] warning: the `r @ _` pattern can be written as just `r`
[INFO] [stderr]    --> src/lib.rs:642:24
[INFO] [stderr]     |
[INFO] [stderr] 642 |             Result::Ok(r @ _) => r,
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:643:25
[INFO] [stderr]     |
[INFO] [stderr] 643 |             Result::Err(e @ _) => {
[INFO] [stderr]     |                         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:736:28
[INFO] [stderr]     |
[INFO] [stderr] 736 |                 Result::Ok(v @ _) => v,
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:737:29
[INFO] [stderr]     |
[INFO] [stderr] 737 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:791:28
[INFO] [stderr]     |
[INFO] [stderr] 791 |                 Result::Ok(v @ _) => v,
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:792:29
[INFO] [stderr]     |
[INFO] [stderr] 792 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:845:28
[INFO] [stderr]     |
[INFO] [stderr] 845 |                 Result::Ok(v @ _) => v,
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:846:29
[INFO] [stderr]     |
[INFO] [stderr] 846 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:881:28
[INFO] [stderr]     |
[INFO] [stderr] 881 |                 Result::Ok(v @ _) => v,
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:882:29
[INFO] [stderr]     |
[INFO] [stderr] 882 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:943:29
[INFO] [stderr]     |
[INFO] [stderr] 943 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `cs @ _` pattern can be written as just `cs`
[INFO] [stderr]     --> src/lib.rs:1269:20
[INFO] [stderr]      |
[INFO] [stderr] 1269 |         Result::Ok(cs @ _) => {
[INFO] [stderr]      |                    ^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]     --> src/lib.rs:1273:9
[INFO] [stderr]      |
[INFO] [stderr] 1273 |         e @ _ => if panic_on_nul {e.unwrap();}, // TODO nul_position?
[INFO] [stderr]      |         ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]     --> src/lib.rs:1446:59
[INFO] [stderr]      |
[INFO] [stderr] 1446 |             if !(a > 2 || (a == 2 && (b > 9 || (b == 9 && (c > 6 || (c == 6)))))) {
[INFO] [stderr]      |                                                           ^^^^^^^^^^^^^^^^^^^ help: try: `c >= 6`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::double_comparisons)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: the `plug @ _` pattern can be written as just `plug`
[INFO] [stderr]     --> src/lib.rs:1475:33
[INFO] [stderr]      |
[INFO] [stderr] 1475 |         Result::Ok(Option::Some(plug @ _)) => {
[INFO] [stderr]      |                                 ^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `r @ _` pattern can be written as just `r`
[INFO] [stderr]     --> src/lib.rs:1485:9
[INFO] [stderr]      |
[INFO] [stderr] 1485 |         r @ _ => {
[INFO] [stderr]      |         ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]     --> src/lib.rs:1491:20
[INFO] [stderr]      |
[INFO] [stderr] 1491 |               if let Err(_) = r {
[INFO] [stderr]      |  _____________-      ^^^^^^
[INFO] [stderr] 1492 | |                 // TODO try to log panic?
[INFO] [stderr] 1493 | |             }
[INFO] [stderr]      | |_____________- help: try this: `if r.is_err()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]     --> src/lib.rs:1511:62
[INFO] [stderr]      |
[INFO] [stderr] 1511 |                       safe_to_unload = if catch_unwind(move || {
[INFO] [stderr]      |  ______________________________________________________________^
[INFO] [stderr] 1512 | |                         let userdata = *pop_userdata(ph);
[INFO] [stderr] 1513 | |                         **ausinfo = Some(userdata.pluginfo);
[INFO] [stderr] 1514 | |                         userdata.plug.deinit(&mut PluginHandle::new(ph, userdata.pluginfo));
[INFO] [stderr] 1515 | |                     }).is_ok() { 1 } else { 0 };
[INFO] [stderr]      | |_____________________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `HexchatEventAttrsHelper`
[INFO] [stderr]     --> src/lib.rs:1278:1
[INFO] [stderr]      |
[INFO] [stderr] 1278 | struct HexchatEventAttrsHelper(*mut internals::HexchatEventAttrs, *mut internals::Ph);
[INFO] [stderr]      | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]     --> src/lib.rs:1281:5
[INFO] [stderr]      |
[INFO] [stderr] 1281 |     fn new(ph: *mut internals::Ph) -> Self {
[INFO] [stderr]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new_with`
[INFO] [stderr]     --> src/lib.rs:1285:5
[INFO] [stderr]      |
[INFO] [stderr] 1285 |     fn new_with(ph: *mut internals::Ph, attrs: EventAttrs) -> Self {
[INFO] [stderr]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the `r @ _` pattern can be written as just `r`
[INFO] [stderr]    --> src/lib.rs:642:24
[INFO] [stderr]     |
[INFO] [stderr] 642 |             Result::Ok(r @ _) => r,
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:643:25
[INFO] [stderr]     |
[INFO] [stderr] 643 |             Result::Err(e @ _) => {
[INFO] [stderr]     |                         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:736:28
[INFO] [stderr]     |
[INFO] [stderr] 736 |                 Result::Ok(v @ _) => v,
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:737:29
[INFO] [stderr]     |
[INFO] [stderr] 737 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:791:28
[INFO] [stderr]     |
[INFO] [stderr] 791 |                 Result::Ok(v @ _) => v,
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:792:29
[INFO] [stderr]     |
[INFO] [stderr] 792 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:845:28
[INFO] [stderr]     |
[INFO] [stderr] 845 |                 Result::Ok(v @ _) => v,
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:846:29
[INFO] [stderr]     |
[INFO] [stderr] 846 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:881:28
[INFO] [stderr]     |
[INFO] [stderr] 881 |                 Result::Ok(v @ _) => v,
[INFO] [stderr]     |                            ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:882:29
[INFO] [stderr]     |
[INFO] [stderr] 882 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]    --> src/lib.rs:943:29
[INFO] [stderr]     |
[INFO] [stderr] 943 |                 Result::Err(e @ _) => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `cs @ _` pattern can be written as just `cs`
[INFO] [stderr]     --> src/lib.rs:1269:20
[INFO] [stderr]      |
[INFO] [stderr] 1269 |         Result::Ok(cs @ _) => {
[INFO] [stderr]      |                    ^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `e @ _` pattern can be written as just `e`
[INFO] [stderr]     --> src/lib.rs:1273:9
[INFO] [stderr]      |
[INFO] [stderr] 1273 |         e @ _ => if panic_on_nul {e.unwrap();}, // TODO nul_position?
[INFO] [stderr]      |         ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]     --> src/lib.rs:1446:59
[INFO] [stderr]      |
[INFO] [stderr] 1446 |             if !(a > 2 || (a == 2 && (b > 9 || (b == 9 && (c > 6 || (c == 6)))))) {
[INFO] [stderr]      |                                                           ^^^^^^^^^^^^^^^^^^^ help: try: `c >= 6`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::double_comparisons)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: the `plug @ _` pattern can be written as just `plug`
[INFO] [stderr]     --> src/lib.rs:1475:33
[INFO] [stderr]      |
[INFO] [stderr] 1475 |         Result::Ok(Option::Some(plug @ _)) => {
[INFO] [stderr]      |                                 ^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `r @ _` pattern can be written as just `r`
[INFO] [stderr]     --> src/lib.rs:1485:9
[INFO] [stderr]      |
[INFO] [stderr] 1485 |         r @ _ => {
[INFO] [stderr]      |         ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]     --> src/lib.rs:1491:20
[INFO] [stderr]      |
[INFO] [stderr] 1491 |               if let Err(_) = r {
[INFO] [stderr]      |  _____________-      ^^^^^^
[INFO] [stderr] 1492 | |                 // TODO try to log panic?
[INFO] [stderr] 1493 | |             }
[INFO] [stderr]      | |_____________- help: try this: `if r.is_err()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]     --> src/lib.rs:1511:62
[INFO] [stderr]      |
[INFO] [stderr] 1511 |                       safe_to_unload = if catch_unwind(move || {
[INFO] [stderr]      |  ______________________________________________________________^
[INFO] [stderr] 1512 | |                         let userdata = *pop_userdata(ph);
[INFO] [stderr] 1513 | |                         **ausinfo = Some(userdata.pluginfo);
[INFO] [stderr] 1514 | |                         userdata.plug.deinit(&mut PluginHandle::new(ph, userdata.pluginfo));
[INFO] [stderr] 1515 | |                     }).is_ok() { 1 } else { 0 };
[INFO] [stderr]      | |_____________________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.11s
[INFO] running `"docker" "inspect" "ec4ce332a5f2e336406c31adc3ecf385ac2f5b465c64a97a2d1bf8382d0ccb79"`
[INFO] running `"docker" "rm" "-f" "ec4ce332a5f2e336406c31adc3ecf385ac2f5b465c64a97a2d1bf8382d0ccb79"`
[INFO] [stdout] ec4ce332a5f2e336406c31adc3ecf385ac2f5b465c64a97a2d1bf8382d0ccb79