[INFO] crate hex-utils 0.1.12 is already in cache [INFO] extracting crate hex-utils 0.1.12 into work/ex/clippy-test-run/sources/stable/reg/hex-utils/0.1.12 [INFO] extracting crate hex-utils 0.1.12 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hex-utils/0.1.12 [INFO] validating manifest of hex-utils-0.1.12 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hex-utils-0.1.12 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hex-utils-0.1.12 [INFO] finished frobbing hex-utils-0.1.12 [INFO] frobbed toml for hex-utils-0.1.12 written to work/ex/clippy-test-run/sources/stable/reg/hex-utils/0.1.12/Cargo.toml [INFO] started frobbing hex-utils-0.1.12 [INFO] finished frobbing hex-utils-0.1.12 [INFO] frobbed toml for hex-utils-0.1.12 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hex-utils/0.1.12/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hex-utils-0.1.12 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hex-utils/0.1.12:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9d26373e1fc9390ff885e4f20bde5781a38ab7d3e928ecbbc489e412b5b6fc70 [INFO] running `"docker" "start" "-a" "9d26373e1fc9390ff885e4f20bde5781a38ab7d3e928ecbbc489e412b5b6fc70"` [INFO] [stderr] Checking hex-utils v0.1.12 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:89:32 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn formatter(&self) -> Box)) -> String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pack` [INFO] [stderr] --> src/lib.rs:139:38 [INFO] [stderr] | [INFO] [stderr] 139 | for i in 0..pack.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 139 | for (i, ) in pack.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:146:29 [INFO] [stderr] | [INFO] [stderr] 146 | / match ascii { [INFO] [stderr] 147 | | Some(ref mut ascii) => { [INFO] [stderr] 148 | | if 32<= c && c < 127 { [INFO] [stderr] 149 | | let _ = write!(ascii, "{}", c as char); [INFO] [stderr] ... | [INFO] [stderr] 154 | | None => (), [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(ref mut ascii) = ascii { [INFO] [stderr] 147 | if 32<= c && c < 127 { [INFO] [stderr] 148 | let _ = write!(ascii, "{}", c as char); [INFO] [stderr] 149 | } else { [INFO] [stderr] 150 | let _ = write!(ascii, "{}", self.format.ascii_none); [INFO] [stderr] 151 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:230:33 [INFO] [stderr] | [INFO] [stderr] 230 | xxd(data, Some(format)).map(|line| fmt(line)).fold(String::new(), |mut res, line| {let _ = writeln!(&mut res, "{}", line);res}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `fmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:89:32 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn formatter(&self) -> Box)) -> String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pack` [INFO] [stderr] --> src/lib.rs:139:38 [INFO] [stderr] | [INFO] [stderr] 139 | for i in 0..pack.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 139 | for (i, ) in pack.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:146:29 [INFO] [stderr] | [INFO] [stderr] 146 | / match ascii { [INFO] [stderr] 147 | | Some(ref mut ascii) => { [INFO] [stderr] 148 | | if 32<= c && c < 127 { [INFO] [stderr] 149 | | let _ = write!(ascii, "{}", c as char); [INFO] [stderr] ... | [INFO] [stderr] 154 | | None => (), [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(ref mut ascii) = ascii { [INFO] [stderr] 147 | if 32<= c && c < 127 { [INFO] [stderr] 148 | let _ = write!(ascii, "{}", c as char); [INFO] [stderr] 149 | } else { [INFO] [stderr] 150 | let _ = write!(ascii, "{}", self.format.ascii_none); [INFO] [stderr] 151 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:230:33 [INFO] [stderr] | [INFO] [stderr] 230 | xxd(data, Some(format)).map(|line| fmt(line)).fold(String::new(), |mut res, line| {let _ = writeln!(&mut res, "{}", line);res}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `fmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "9d26373e1fc9390ff885e4f20bde5781a38ab7d3e928ecbbc489e412b5b6fc70"` [INFO] running `"docker" "rm" "-f" "9d26373e1fc9390ff885e4f20bde5781a38ab7d3e928ecbbc489e412b5b6fc70"` [INFO] [stdout] 9d26373e1fc9390ff885e4f20bde5781a38ab7d3e928ecbbc489e412b5b6fc70