[INFO] crate hermod 0.1.2 is already in cache [INFO] extracting crate hermod 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/hermod/0.1.2 [INFO] extracting crate hermod 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hermod/0.1.2 [INFO] validating manifest of hermod-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hermod-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hermod-0.1.2 [INFO] finished frobbing hermod-0.1.2 [INFO] frobbed toml for hermod-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/hermod/0.1.2/Cargo.toml [INFO] started frobbing hermod-0.1.2 [INFO] finished frobbing hermod-0.1.2 [INFO] frobbed toml for hermod-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hermod/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hermod-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hermod/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 521444bec5b88bb3a458f0dac4c57ece99f9f9b3d0883e9ca723e0822e50a790 [INFO] running `"docker" "start" "-a" "521444bec5b88bb3a458f0dac4c57ece99f9f9b3d0883e9ca723e0822e50a790"` [INFO] [stderr] Checking quick-xml v0.13.2 [INFO] [stderr] Checking quick-xml v0.12.4 [INFO] [stderr] Checking rss v1.6.1 [INFO] [stderr] Checking atom_syndication v0.6.0 [INFO] [stderr] Checking hermod v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/futures.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/futures.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/futures.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | .and_then(move |feed| ok(func(feed))) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 51 | .and_then(move |feed| ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/futures.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match reader.read_event(&mut buf) { [INFO] [stderr] 87 | | Ok(Event::Start(ref e)) => match e.name() { [INFO] [stderr] 88 | | b"rss" => { [INFO] [stderr] 89 | | debug!("found rss"); [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => (), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let Ok(Event::Start(ref e)) = reader.read_event(&mut buf) { match e.name() { [INFO] [stderr] 87 | b"rss" => { [INFO] [stderr] 88 | debug!("found rss"); [INFO] [stderr] 89 | match rss::Channel::read_from(BufReader::new(string)) { [INFO] [stderr] 90 | Ok(channel) => return ok(FeedType::RSS(channel)), [INFO] [stderr] 91 | Err(_) => return err(Error::ParseError), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/futures.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | fn process_items<'a>(feed_items: &mut Vec) -> Result, Error> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/futures.rs:146:20 [INFO] [stderr] | [INFO] [stderr] 146 | fn process_entries<'a>(feed_items: &mut Vec) -> Result, Error> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/models.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | RSS(rss::Channel), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 12 | RSS(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/futures.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | .and_then(move |feed| ok(func(feed))) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 51 | .and_then(move |feed| ok(())) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/futures.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match reader.read_event(&mut buf) { [INFO] [stderr] 87 | | Ok(Event::Start(ref e)) => match e.name() { [INFO] [stderr] 88 | | b"rss" => { [INFO] [stderr] 89 | | debug!("found rss"); [INFO] [stderr] ... | [INFO] [stderr] 104 | | _ => (), [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let Ok(Event::Start(ref e)) = reader.read_event(&mut buf) { match e.name() { [INFO] [stderr] 87 | b"rss" => { [INFO] [stderr] 88 | debug!("found rss"); [INFO] [stderr] 89 | match rss::Channel::read_from(BufReader::new(string)) { [INFO] [stderr] 90 | Ok(channel) => return ok(FeedType::RSS(channel)), [INFO] [stderr] 91 | Err(_) => return err(Error::ParseError), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/futures.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | fn process_items<'a>(feed_items: &mut Vec) -> Result, Error> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/futures.rs:146:20 [INFO] [stderr] | [INFO] [stderr] 146 | fn process_entries<'a>(feed_items: &mut Vec) -> Result, Error> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/models.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | RSS(rss::Channel), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 12 | RSS(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.62s [INFO] running `"docker" "inspect" "521444bec5b88bb3a458f0dac4c57ece99f9f9b3d0883e9ca723e0822e50a790"` [INFO] running `"docker" "rm" "-f" "521444bec5b88bb3a458f0dac4c57ece99f9f9b3d0883e9ca723e0822e50a790"` [INFO] [stdout] 521444bec5b88bb3a458f0dac4c57ece99f9f9b3d0883e9ca723e0822e50a790