[INFO] crate herkulex_communicator 0.2.5 is already in cache [INFO] extracting crate herkulex_communicator 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/herkulex_communicator/0.2.5 [INFO] extracting crate herkulex_communicator 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/herkulex_communicator/0.2.5 [INFO] validating manifest of herkulex_communicator-0.2.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of herkulex_communicator-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing herkulex_communicator-0.2.5 [INFO] finished frobbing herkulex_communicator-0.2.5 [INFO] frobbed toml for herkulex_communicator-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/herkulex_communicator/0.2.5/Cargo.toml [INFO] started frobbing herkulex_communicator-0.2.5 [INFO] finished frobbing herkulex_communicator-0.2.5 [INFO] frobbed toml for herkulex_communicator-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/herkulex_communicator/0.2.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting herkulex_communicator-0.2.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/herkulex_communicator/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cc600dc657ff2a3de2b744fad53aac5910412403cbffc3930d2c3c2fe50a8a60 [INFO] running `"docker" "start" "-a" "cc600dc657ff2a3de2b744fad53aac5910412403cbffc3930d2c3c2fe50a8a60"` [INFO] [stderr] Checking array-macro v1.0.3 [INFO] [stderr] Checking reexport-proc-macro v1.0.6 [INFO] [stderr] Checking drs-0x01 v0.1.7 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Compiling enum-map-derive v0.4.1 [INFO] [stderr] Compiling enumset_derive v0.2.0 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking serialport v3.2.0 [INFO] [stderr] Checking enum-map v0.4.1 [INFO] [stderr] Checking enumset v0.3.15 [INFO] [stderr] Checking cursive v0.9.2 [INFO] [stderr] Checking herkulex_communicator v0.2.5 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cli.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | app [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cli.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | let app = app_from_crate!() [INFO] [stderr] | _______________^ [INFO] [stderr] 21 | | // GUI [INFO] [stderr] 22 | | .subcommand(SubCommand::with_name("gui").about("Start the application in graphical mode.")) [INFO] [stderr] 23 | | .subcommand(SubCommand::with_name("completions") [INFO] [stderr] ... | [INFO] [stderr] 169 | | .takes_value(true)) [INFO] [stderr] 170 | | ).setting(AppSettings::ArgRequiredElseHelp); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cli.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | Ok(_) => Err(format!("Invalid speed. It should be in the range 0~1023.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid speed. It should be in the range 0~1023.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cli.rs:100:38 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(_) => Err(format!("Invalid position. It should be in the range 0~1023.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid position. It should be in the range 0~1023.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cli.rs:117:38 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(_) => Err(format!("Invalid ID. It should be in the range 0~253.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid ID. It should be in the range 0~253.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cli.rs:141:42 [INFO] [stderr] | [INFO] [stderr] 141 | Ok(_) => Err(format!("The provided ID is invalid. It should in the range 0~254.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The provided ID is invalid. It should in the range 0~254.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cli.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | app [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cli.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | let app = app_from_crate!() [INFO] [stderr] | _______________^ [INFO] [stderr] 21 | | // GUI [INFO] [stderr] 22 | | .subcommand(SubCommand::with_name("gui").about("Start the application in graphical mode.")) [INFO] [stderr] 23 | | .subcommand(SubCommand::with_name("completions") [INFO] [stderr] ... | [INFO] [stderr] 169 | | .takes_value(true)) [INFO] [stderr] 170 | | ).setting(AppSettings::ArgRequiredElseHelp); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | include_str!("../Cargo.toml"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:150:29 [INFO] [stderr] | [INFO] [stderr] 150 | fn send_message(connection: &mut Box, message: HerkulexMessage) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn SerialPort` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cli.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | Ok(_) => Err(format!("Invalid speed. It should be in the range 0~1023.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid speed. It should be in the range 0~1023.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cli.rs:100:38 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(_) => Err(format!("Invalid position. It should be in the range 0~1023.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid position. It should be in the range 0~1023.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cli.rs:117:38 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(_) => Err(format!("Invalid ID. It should be in the range 0~253.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid ID. It should be in the range 0~253.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/cli.rs:141:42 [INFO] [stderr] | [INFO] [stderr] 141 | Ok(_) => Err(format!("The provided ID is invalid. It should in the range 0~254.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The provided ID is invalid. It should in the range 0~254.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | include_str!("../Cargo.toml"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:150:29 [INFO] [stderr] | [INFO] [stderr] 150 | fn send_message(connection: &mut Box, message: HerkulexMessage) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut dyn SerialPort` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.36s [INFO] running `"docker" "inspect" "cc600dc657ff2a3de2b744fad53aac5910412403cbffc3930d2c3c2fe50a8a60"` [INFO] running `"docker" "rm" "-f" "cc600dc657ff2a3de2b744fad53aac5910412403cbffc3930d2c3c2fe50a8a60"` [INFO] [stdout] cc600dc657ff2a3de2b744fad53aac5910412403cbffc3930d2c3c2fe50a8a60