[INFO] crate hematite-nbt 0.3.0 is already in cache
[INFO] extracting crate hematite-nbt 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/hematite-nbt/0.3.0
[INFO] extracting crate hematite-nbt 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hematite-nbt/0.3.0
[INFO] validating manifest of hematite-nbt-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hematite-nbt-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hematite-nbt-0.3.0
[INFO] finished frobbing hematite-nbt-0.3.0
[INFO] frobbed toml for hematite-nbt-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/hematite-nbt/0.3.0/Cargo.toml
[INFO] started frobbing hematite-nbt-0.3.0
[INFO] finished frobbing hematite-nbt-0.3.0
[INFO] frobbed toml for hematite-nbt-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hematite-nbt/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hematite-nbt-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hematite-nbt/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7f01f68c2a5ae481cad90e2557d431f4d83867d890076c7610678323ae625a26
[INFO] running `"docker" "start" "-a" "7f01f68c2a5ae481cad90e2557d431f4d83867d890076c7610678323ae625a26"`
[INFO] [stderr]     Checking hematite-nbt v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/blob.rs:46:16
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Blob { title: title, content: Value::Compound(map) }
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/blob.rs:59:36
[INFO] [stderr]    |
[INFO] [stderr] 59 |         Ok(Blob { title: header.1, content: content })
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^ help: replace it with: `content`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/tests.rs:329:13
[INFO] [stderr]     |
[INFO] [stderr] 329 |             name: name, health: health, food: food, emeralds: emeralds,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/tests.rs:329:25
[INFO] [stderr]     |
[INFO] [stderr] 329 |             name: name, health: health, food: food, emeralds: emeralds,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: replace it with: `health`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/tests.rs:329:41
[INFO] [stderr]     |
[INFO] [stderr] 329 |             name: name, health: health, food: food, emeralds: emeralds,
[INFO] [stderr]     |                                         ^^^^^^^^^^ help: replace it with: `food`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/tests.rs:329:53
[INFO] [stderr]     |
[INFO] [stderr] 329 |             name: name, health: health, food: food, emeralds: emeralds,
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^ help: replace it with: `emeralds`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/tests.rs:330:13
[INFO] [stderr]     |
[INFO] [stderr] 330 |             timestamp: timestamp, ids: ids, data: data
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/tests.rs:330:35
[INFO] [stderr]     |
[INFO] [stderr] 330 |             timestamp: timestamp, ids: ids, data: data
[INFO] [stderr]     |                                   ^^^^^^^^ help: replace it with: `ids`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/tests.rs:330:45
[INFO] [stderr]     |
[INFO] [stderr] 330 |             timestamp: timestamp, ids: ids, data: data
[INFO] [stderr]     |                                             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/blob.rs:46:16
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Blob { title: title, content: Value::Compound(map) }
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/blob.rs:59:36
[INFO] [stderr]    |
[INFO] [stderr] 59 |         Ok(Blob { title: header.1, content: content })
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^ help: replace it with: `content`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/serialize/mod.rs:196:20
[INFO] [stderr]     |
[INFO] [stderr] 196 |         true  => { return Err(Error::NoRootCompound); },
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NoRootCompound)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/serialize/mod.rs:196:20
[INFO] [stderr]     |
[INFO] [stderr] 196 |         true  => { return Err(Error::NoRootCompound); },
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::NoRootCompound)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/tests.rs:21:41
[INFO] [stderr]    |
[INFO] [stderr] 21 |     nbt.insert("timestamp".to_string(), 1424778774i32).unwrap();
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^ help: consider: `1_424_778_774i32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/tests.rs:217:52
[INFO] [stderr]     |
[INFO] [stderr] 217 |     nbt.insert("timestamp".to_string(), Value::Int(1424778774)).unwrap();
[INFO] [stderr]     |                                                    ^^^^^^^^^^ help: consider: `1_424_778_774`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/tests.rs:339:62
[INFO] [stderr]     |
[INFO] [stderr] 339 |         health: 100, food: 20.0, emeralds: 12345, timestamp: 1424778774,
[INFO] [stderr]     |                                                              ^^^^^^^^^^ help: consider: `1_424_778_774`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/blob.rs:50:24
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn from_reader(mut src: &mut io::Read) -> Result<Blob> {
[INFO] [stderr]    |                        ----^^^
[INFO] [stderr]    |                        |
[INFO] [stderr]    |                        help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/value.rs:88:32
[INFO] [stderr]    |
[INFO] [stderr] 88 |     pub fn write_header(&self, mut dst: &mut io::Write, title: &str) -> Result<()> {
[INFO] [stderr]    |                                ----^^^
[INFO] [stderr]    |                                |
[INFO] [stderr]    |                                help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/value.rs:96:25
[INFO] [stderr]    |
[INFO] [stderr] 96 |     pub fn write(&self, mut dst: &mut io::Write) -> Result<()> {
[INFO] [stderr]    |                         ----^^^
[INFO] [stderr]    |                         |
[INFO] [stderr]    |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/value.rs:155:24
[INFO] [stderr]     |
[INFO] [stderr] 155 |     pub fn read_header(mut src: &mut io::Read) -> Result<(u8, String)> {
[INFO] [stderr]     |                        ----^^^
[INFO] [stderr]     |                        |
[INFO] [stderr]     |                        help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/value.rs:170:32
[INFO] [stderr]     |
[INFO] [stderr] 170 |     pub fn from_reader(id: u8, mut src: &mut io::Read) -> Result<Value> {
[INFO] [stderr]     |                                ----^^^
[INFO] [stderr]     |                                |
[INFO] [stderr]     |                                help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/value.rs:309:14
[INFO] [stderr]     |
[INFO] [stderr] 309 | fn read_utf8(mut src: &mut io::Read, len: usize) -> Result<String> {
[INFO] [stderr]     |              ----^^^
[INFO] [stderr]     |              |
[INFO] [stderr]     |              help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/serialize/raw.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 |     for ref value in values {
[INFO] [stderr]     |         ^^^^^^^^^    ------ help: try: `let value = &values;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/serialize/mod.rs:194:5
[INFO] [stderr]     |
[INFO] [stderr] 194 | /     match T::is_bare() {
[INFO] [stderr] 195 | |         // Refuse to blindly serialize types not wrapped in an NBT Compound.
[INFO] [stderr] 196 | |         true  => { return Err(Error::NoRootCompound); },
[INFO] [stderr] 197 | |         false => obj.to_nbt(dst, ""),
[INFO] [stderr] 198 | |     }
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if T::is_bare() { return Err(Error::NoRootCompound); } else { obj.to_nbt(dst, "") }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/serialize/mod.rs:367:23
[INFO] [stderr]     |
[INFO] [stderr] 367 | impl<S, T> NbtFmt for HashMap<S, T> where S: AsRef<str> + Hash + Eq, T: NbtFmt {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 367 | impl<S, T, S: ::std::hash::BuildHasher> NbtFmt for HashMap<S, T, S> where S: AsRef<str> + Hash + Eq, T: NbtFmt {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^            ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: item `blob::Blob` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/blob.rs:42:1
[INFO] [stderr]     |
[INFO] [stderr] 42  | / impl Blob {
[INFO] [stderr] 43  | |     /// Create a new NBT file format representation with the given name.
[INFO] [stderr] 44  | |     pub fn new(title: String) -> Blob {
[INFO] [stderr] 45  | |         let map: HashMap<String, Value> = HashMap::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 130 | |     }
[INFO] [stderr] 131 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/blob.rs:109:16
[INFO] [stderr]     |
[INFO] [stderr] 109 |             if vals.len() != 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vals.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: item `value::Value` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/value.rs:25:1
[INFO] [stderr]     |
[INFO] [stderr] 25  | / impl Value {
[INFO] [stderr] 26  | |     /// The type ID of this `Value`, which is a single byte in the range
[INFO] [stderr] 27  | |     /// `0x01` to `0x0b`.
[INFO] [stderr] 28  | |     pub fn id(&self) -> u8 {
[INFO] [stderr] ...   |
[INFO] [stderr] 219 | |     }
[INFO] [stderr] 220 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/value.rs:74:49
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 5 + vals.iter().map(|x| x.len()).fold(0, |acc, item| acc + item)
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/value.rs:80:19
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 }).fold(0, |acc, item| acc + item) + 1 // + u8 for the Tag_End
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/value.rs:117:20
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 if vals.len() == 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vals.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/value.rs:234:20
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 if v.len() == 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/blob.rs:50:24
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn from_reader(mut src: &mut io::Read) -> Result<Blob> {
[INFO] [stderr]    |                        ----^^^
[INFO] [stderr]    |                        |
[INFO] [stderr]    |                        help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/value.rs:88:32
[INFO] [stderr]    |
[INFO] [stderr] 88 |     pub fn write_header(&self, mut dst: &mut io::Write, title: &str) -> Result<()> {
[INFO] [stderr]    |                                ----^^^
[INFO] [stderr]    |                                |
[INFO] [stderr]    |                                help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/value.rs:96:25
[INFO] [stderr]    |
[INFO] [stderr] 96 |     pub fn write(&self, mut dst: &mut io::Write) -> Result<()> {
[INFO] [stderr]    |                         ----^^^
[INFO] [stderr]    |                         |
[INFO] [stderr]    |                         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/value.rs:155:24
[INFO] [stderr]     |
[INFO] [stderr] 155 |     pub fn read_header(mut src: &mut io::Read) -> Result<(u8, String)> {
[INFO] [stderr]     |                        ----^^^
[INFO] [stderr]     |                        |
[INFO] [stderr]     |                        help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/value.rs:170:32
[INFO] [stderr]     |
[INFO] [stderr] 170 |     pub fn from_reader(id: u8, mut src: &mut io::Read) -> Result<Value> {
[INFO] [stderr]     |                                ----^^^
[INFO] [stderr]     |                                |
[INFO] [stderr]     |                                help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/value.rs:309:14
[INFO] [stderr]     |
[INFO] [stderr] 309 | fn read_utf8(mut src: &mut io::Read, len: usize) -> Result<String> {
[INFO] [stderr]     |              ----^^^
[INFO] [stderr]     |              |
[INFO] [stderr]     |              help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/serialize/raw.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 |     for ref value in values {
[INFO] [stderr]     |         ^^^^^^^^^    ------ help: try: `let value = &values;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/serialize/mod.rs:194:5
[INFO] [stderr]     |
[INFO] [stderr] 194 | /     match T::is_bare() {
[INFO] [stderr] 195 | |         // Refuse to blindly serialize types not wrapped in an NBT Compound.
[INFO] [stderr] 196 | |         true  => { return Err(Error::NoRootCompound); },
[INFO] [stderr] 197 | |         false => obj.to_nbt(dst, ""),
[INFO] [stderr] 198 | |     }
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if T::is_bare() { return Err(Error::NoRootCompound); } else { obj.to_nbt(dst, "") }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/serialize/mod.rs:367:23
[INFO] [stderr]     |
[INFO] [stderr] 367 | impl<S, T> NbtFmt for HashMap<S, T> where S: AsRef<str> + Hash + Eq, T: NbtFmt {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 367 | impl<S, T, S: ::std::hash::BuildHasher> NbtFmt for HashMap<S, T, S> where S: AsRef<str> + Hash + Eq, T: NbtFmt {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^            ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: item `blob::Blob` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/blob.rs:42:1
[INFO] [stderr]     |
[INFO] [stderr] 42  | / impl Blob {
[INFO] [stderr] 43  | |     /// Create a new NBT file format representation with the given name.
[INFO] [stderr] 44  | |     pub fn new(title: String) -> Blob {
[INFO] [stderr] 45  | |         let map: HashMap<String, Value> = HashMap::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 130 | |     }
[INFO] [stderr] 131 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/blob.rs:109:16
[INFO] [stderr]     |
[INFO] [stderr] 109 |             if vals.len() != 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vals.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: item `value::Value` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/value.rs:25:1
[INFO] [stderr]     |
[INFO] [stderr] 25  | / impl Value {
[INFO] [stderr] 26  | |     /// The type ID of this `Value`, which is a single byte in the range
[INFO] [stderr] 27  | |     /// `0x01` to `0x0b`.
[INFO] [stderr] 28  | |     pub fn id(&self) -> u8 {
[INFO] [stderr] ...   |
[INFO] [stderr] 219 | |     }
[INFO] [stderr] 220 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/value.rs:74:49
[INFO] [stderr]    |
[INFO] [stderr] 74 |                 5 + vals.iter().map(|x| x.len()).fold(0, |acc, item| acc + item)
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/value.rs:80:19
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 }).fold(0, |acc, item| acc + item) + 1 // + u8 for the Tag_End
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/value.rs:117:20
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 if vals.len() == 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vals.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/value.rs:234:20
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 if v.len() == 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.23s
[INFO] running `"docker" "inspect" "7f01f68c2a5ae481cad90e2557d431f4d83867d890076c7610678323ae625a26"`
[INFO] running `"docker" "rm" "-f" "7f01f68c2a5ae481cad90e2557d431f4d83867d890076c7610678323ae625a26"`
[INFO] [stdout] 7f01f68c2a5ae481cad90e2557d431f4d83867d890076c7610678323ae625a26