[INFO] crate helix 0.7.5 is already in cache [INFO] extracting crate helix 0.7.5 into work/ex/clippy-test-run/sources/stable/reg/helix/0.7.5 [INFO] extracting crate helix 0.7.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/helix/0.7.5 [INFO] validating manifest of helix-0.7.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of helix-0.7.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing helix-0.7.5 [INFO] finished frobbing helix-0.7.5 [INFO] frobbed toml for helix-0.7.5 written to work/ex/clippy-test-run/sources/stable/reg/helix/0.7.5/Cargo.toml [INFO] started frobbing helix-0.7.5 [INFO] finished frobbing helix-0.7.5 [INFO] frobbed toml for helix-0.7.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/helix/0.7.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting helix-0.7.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/helix/0.7.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2db2cecf81a01622f436e5242405a65896947c5b27ab9ae7247f1ddacaa0559 [INFO] running `"docker" "start" "-a" "d2db2cecf81a01622f436e5242405a65896947c5b27ab9ae7247f1ddacaa0559"` [INFO] [stderr] Compiling libcruby-sys v0.7.5 [INFO] [stderr] Checking helix v0.7.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:17:55 [INFO] [stderr] | [INFO] [stderr] 17 | MethodDefinition::Class(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:17:67 [INFO] [stderr] | [INFO] [stderr] 17 | MethodDefinition::Class(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:17:87 [INFO] [stderr] | [INFO] [stderr] 17 | MethodDefinition::Class(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:21:58 [INFO] [stderr] | [INFO] [stderr] 21 | MethodDefinition::Instance(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:21:70 [INFO] [stderr] | [INFO] [stderr] 21 | MethodDefinition::Instance(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:21:90 [INFO] [stderr] | [INFO] [stderr] 21 | MethodDefinition::Instance(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coercions/mod.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | CheckedValue { inner: inner, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:17:55 [INFO] [stderr] | [INFO] [stderr] 17 | MethodDefinition::Class(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:17:67 [INFO] [stderr] | [INFO] [stderr] 17 | MethodDefinition::Class(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:17:87 [INFO] [stderr] | [INFO] [stderr] 17 | MethodDefinition::Class(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:21:58 [INFO] [stderr] | [INFO] [stderr] 21 | MethodDefinition::Instance(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:21:70 [INFO] [stderr] | [INFO] [stderr] 21 | MethodDefinition::Instance(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_definition.rs:21:90 [INFO] [stderr] | [INFO] [stderr] 21 | MethodDefinition::Instance(MethodSpecification { name: name, function: function, arity: arity }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `arity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coercions/mod.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | CheckedValue { inner: inner, marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/coercions/unit.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | fn from_checked(checked: ()) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/coercions/string.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 19 | | if unsafe { sys::rb_str_ascii_only_p(value) } { [INFO] [stderr] 20 | | unsafe { Ok(CheckedValue::new(value)) } [INFO] [stderr] 21 | | } else { [INFO] [stderr] 22 | | type_error!(value, "an UTF-8 String") [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | } else if unsafe { sys::rb_str_ascii_only_p(value) } { [INFO] [stderr] 19 | unsafe { Ok(CheckedValue::new(value)) } [INFO] [stderr] 20 | } else { [INFO] [stderr] 21 | type_error!(value, "an UTF-8 String") [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/coercions/unit.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | fn from_checked(checked: ()) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/coercions/string.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 19 | | if unsafe { sys::rb_str_ascii_only_p(value) } { [INFO] [stderr] 20 | | unsafe { Ok(CheckedValue::new(value)) } [INFO] [stderr] 21 | | } else { [INFO] [stderr] 22 | | type_error!(value, "an UTF-8 String") [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 18 | } else if unsafe { sys::rb_str_ascii_only_p(value) } { [INFO] [stderr] 19 | unsafe { Ok(CheckedValue::new(value)) } [INFO] [stderr] 20 | } else { [INFO] [stderr] 21 | type_error!(value, "an UTF-8 String") [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/coercions/option.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | T::from_ruby(value).map(|c| Some(c)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut std::vec::Vec<(sys::VALUE, sys::VALUE)>`) [INFO] [stderr] --> src/coercions/hash.rs:8:50 [INFO] [stderr] | [INFO] [stderr] 8 | let vec: &mut Vec<(VALUE, VALUE)> = unsafe { transmute(vec) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&mut *(vec as *mut std::vec::Vec<(sys::VALUE, sys::VALUE)>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/coercions/hash.rs:13:57 [INFO] [stderr] | [INFO] [stderr] 13 | impl FromRuby for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 13 | impl FromRuby for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/coercions/hash.rs:21:62 [INFO] [stderr] | [INFO] [stderr] 21 | unsafe { rb_hash_foreach(value, rb_hash_collect, transmute(&mut pairs)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut pairs as *mut std::vec::Vec<(sys::VALUE, sys::VALUE)> as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/coercions/hash.rs:43:51 [INFO] [stderr] | [INFO] [stderr] 43 | impl ToRuby for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 43 | impl ToRuby for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/coercions/mod.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn to_value(self) -> VALUE { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn subclass(&self, name: &CStr) -> Class { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:147:41 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn define_method(&self, name: &CStr, method: T) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/coercions/option.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | T::from_ruby(value).map(|c| Some(c)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut libc::c_void`) to a reference type (`&mut std::vec::Vec<(sys::VALUE, sys::VALUE)>`) [INFO] [stderr] --> src/coercions/hash.rs:8:50 [INFO] [stderr] | [INFO] [stderr] 8 | let vec: &mut Vec<(VALUE, VALUE)> = unsafe { transmute(vec) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&mut *(vec as *mut std::vec::Vec<(sys::VALUE, sys::VALUE)>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/coercions/hash.rs:13:57 [INFO] [stderr] | [INFO] [stderr] 13 | impl FromRuby for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 13 | impl FromRuby for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/coercions/hash.rs:21:62 [INFO] [stderr] | [INFO] [stderr] 21 | unsafe { rb_hash_foreach(value, rb_hash_collect, transmute(&mut pairs)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut pairs as *mut std::vec::Vec<(sys::VALUE, sys::VALUE)> as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/coercions/hash.rs:43:51 [INFO] [stderr] | [INFO] [stderr] 43 | impl ToRuby for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 43 | impl ToRuby for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/coercions/mod.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn to_value(self) -> VALUE { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:141:21 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn subclass(&self, name: &CStr) -> Class { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:147:41 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn define_method(&self, name: &CStr, method: T) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.81s [INFO] running `"docker" "inspect" "d2db2cecf81a01622f436e5242405a65896947c5b27ab9ae7247f1ddacaa0559"` [INFO] running `"docker" "rm" "-f" "d2db2cecf81a01622f436e5242405a65896947c5b27ab9ae7247f1ddacaa0559"` [INFO] [stdout] d2db2cecf81a01622f436e5242405a65896947c5b27ab9ae7247f1ddacaa0559