[INFO] crate helianto 0.1.0-beta1 is already in cache [INFO] extracting crate helianto 0.1.0-beta1 into work/ex/clippy-test-run/sources/stable/reg/helianto/0.1.0-beta1 [INFO] extracting crate helianto 0.1.0-beta1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/helianto/0.1.0-beta1 [INFO] validating manifest of helianto-0.1.0-beta1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of helianto-0.1.0-beta1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing helianto-0.1.0-beta1 [INFO] finished frobbing helianto-0.1.0-beta1 [INFO] frobbed toml for helianto-0.1.0-beta1 written to work/ex/clippy-test-run/sources/stable/reg/helianto/0.1.0-beta1/Cargo.toml [INFO] started frobbing helianto-0.1.0-beta1 [INFO] finished frobbing helianto-0.1.0-beta1 [INFO] frobbed toml for helianto-0.1.0-beta1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/helianto/0.1.0-beta1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting helianto-0.1.0-beta1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/helianto/0.1.0-beta1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fb34c1bce44c482272038ca734feef29e94b1ce206c4f7feb22f1a7437ab4cf [INFO] running `"docker" "start" "-a" "3fb34c1bce44c482272038ca734feef29e94b1ce206c4f7feb22f1a7437ab4cf"` [INFO] [stderr] Checking quick-error v0.1.4 [INFO] [stderr] Compiling hoedown v3.0.5 [INFO] [stderr] Checking stdio_logger v0.1.1 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking handlebars v0.12.1 [INFO] [stderr] Checking helianto v0.1.0-beta1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/document.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | Document { metadata: metadata, content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/document.rs:145:40 [INFO] [stderr] | [INFO] [stderr] 145 | Document { metadata: metadata, content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/templates.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | site: site, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/templates.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | document: document, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `document` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/document.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | Document { metadata: metadata, content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/document.rs:145:40 [INFO] [stderr] | [INFO] [stderr] 145 | Document { metadata: metadata, content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/templates.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | site: site, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `site` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/templates.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | document: document, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `document` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | const PATHS: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^------------------------------- help: consider removing `'static`: `&[(&'static str, &'static str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:149:30 [INFO] [stderr] | [INFO] [stderr] 149 | const PATHS: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils.rs:149:44 [INFO] [stderr] | [INFO] [stderr] 149 | const PATHS: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/document.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | const CREATED_FIELD: &'static Field = &Date("created") as &Field; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&Field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/document.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | const MODIFIED_FIELD: &'static Field = &Date("modified") as &Field; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&Field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/document.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | const KEYWORDS_FIELD: &'static Field = &Keywords("keywords") as &Field; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&Field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/document.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | const CREATED_FIELD: &'static Field = &Date("created") as &Field; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&Field` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/document.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | const MODIFIED_FIELD: &'static Field = &Date("modified") as &Field; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&Field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/document.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | const KEYWORDS_FIELD: &'static Field = &Keywords("keywords") as &Field; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&Field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/document.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/document.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/document.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromRaw` [INFO] [stderr] --> src/document.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | use utils::{DateTime, FromRaw}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/utils.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/document.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromRaw` [INFO] [stderr] --> src/document.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | use utils::{DateTime, FromRaw}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:194:18 [INFO] [stderr] | [INFO] [stderr] 194 | .map(|d| DateTime(d)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `DateTime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/templates.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let argument = if value_param.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/templates.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / let _ = try! { [INFO] [stderr] 82 | | write!(rc.writer, "{}", date.format(format_param.as_ref())) [INFO] [stderr] 83 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/templates.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | write!(rc.writer, "{}", date.format(format_param.as_ref())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `format_param` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/templates.rs:101:47 [INFO] [stderr] | [INFO] [stderr] 101 | let argument = if value_param.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/templates.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | let _ = try!(write!(rc.writer, "{}", result.join(separator))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/readers/markdown.rs:80:55 [INFO] [stderr] | [INFO] [stderr] 80 | let parts: Vec<&str> = line.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/metadata.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | Value::Vec(iterator.into_iter().map(|v| Value::from(v)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | fn as_ref<'l>(&'l self) -> Option<&'l T>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | fn as_mut<'l>(&'l mut self) -> Option<&'l mut T>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 143 | impl_opt_as_ref!(bool, Value::Bool); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 143 | impl_opt_as_ref!(bool, Value::Bool); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 144 | impl_opt_as_ref!(i64, Value::I64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 144 | impl_opt_as_ref!(i64, Value::I64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 145 | impl_opt_as_ref!(u64, Value::U64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 145 | impl_opt_as_ref!(u64, Value::U64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 146 | impl_opt_as_ref!(f64, Value::F64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 146 | impl_opt_as_ref!(f64, Value::F64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 147 | impl_opt_as_ref!(String, Value::String); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 147 | impl_opt_as_ref!(String, Value::String); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 148 | impl_opt_as_ref!(DateTime, Value::DateTime); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 148 | impl_opt_as_ref!(DateTime, Value::DateTime); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/metadata.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | let sep = if let Some(_) = metadata.find(';') { [INFO] [stderr] | _______________- ^^^^^^^ [INFO] [stderr] 175 | | ';' [INFO] [stderr] 176 | | } else { [INFO] [stderr] 177 | | ',' [INFO] [stderr] 178 | | }; [INFO] [stderr] | |_____- help: try this: `if metadata.find(';').is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:179:71 [INFO] [stderr] | [INFO] [stderr] 179 | Ok(metadata.split(sep).map(|s| String::from(s.trim())).filter(|s| s.len() > 0).collect()) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:194:18 [INFO] [stderr] | [INFO] [stderr] 194 | .map(|d| DateTime(d)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `DateTime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/settings.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | source_dir: cwd.join(".").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cwd.join(".")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/settings.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | output_dir: cwd.join("_output").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cwd.join("_output")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/settings.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | layouts_dir: cwd.join("_layouts").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cwd.join("_layouts")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/settings.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | .map(|table| Value::Table(table)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / path.extension() [INFO] [stderr] 105 | | .and_then(|extension| extension.to_str()) [INFO] [stderr] 106 | | .and_then(|extension_str| self.readers.get(extension_str)) [INFO] [stderr] 107 | | .map(|rc| rc.clone()) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 104 | path.extension() [INFO] [stderr] 105 | .and_then(|extension| extension.to_str()) [INFO] [stderr] 106 | .and_then(|extension_str| self.readers.get(extension_str)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | try! { fd.write(output.as_ref()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/templates.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let argument = if value_param.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/templates.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / let _ = try! { [INFO] [stderr] 82 | | write!(rc.writer, "{}", date.format(format_param.as_ref())) [INFO] [stderr] 83 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/templates.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | write!(rc.writer, "{}", date.format(format_param.as_ref())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `format_param` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/templates.rs:101:47 [INFO] [stderr] | [INFO] [stderr] 101 | let argument = if value_param.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/templates.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | let _ = try!(write!(rc.writer, "{}", result.join(separator))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:258:52 [INFO] [stderr] | [INFO] [stderr] 258 | let documents: Vec> = self.documents.values().map(|rc| rc.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.documents.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/readers/markdown.rs:80:55 [INFO] [stderr] | [INFO] [stderr] 80 | let parts: Vec<&str> = line.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/metadata.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | Value::Vec(iterator.into_iter().map(|v| Value::from(v)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | fn as_ref<'l>(&'l self) -> Option<&'l T>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | fn as_mut<'l>(&'l mut self) -> Option<&'l mut T>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 143 | impl_opt_as_ref!(bool, Value::Bool); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 143 | impl_opt_as_ref!(bool, Value::Bool); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 144 | impl_opt_as_ref!(i64, Value::I64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 144 | impl_opt_as_ref!(i64, Value::I64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 145 | impl_opt_as_ref!(u64, Value::U64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 145 | impl_opt_as_ref!(u64, Value::U64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 146 | impl_opt_as_ref!(f64, Value::F64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 146 | impl_opt_as_ref!(f64, Value::F64); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 147 | impl_opt_as_ref!(String, Value::String); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 147 | impl_opt_as_ref!(String, Value::String); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | / fn as_ref<'l>(&'l self) -> Option<&'l $to> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | $variant(ref value) => Some(value), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 148 | impl_opt_as_ref!(DateTime, Value::DateTime); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metadata.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / fn as_mut<'l>(&'l mut self) -> Option<&'l mut $to> { [INFO] [stderr] 103 | | match *self { [INFO] [stderr] 104 | | $variant(ref mut value) => Some(value), [INFO] [stderr] 105 | | _ => None, [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 148 | impl_opt_as_ref!(DateTime, Value::DateTime); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: Could not compile `helianto`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/metadata.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | let sep = if let Some(_) = metadata.find(';') { [INFO] [stderr] | _______________- ^^^^^^^ [INFO] [stderr] 175 | | ';' [INFO] [stderr] 176 | | } else { [INFO] [stderr] 177 | | ',' [INFO] [stderr] 178 | | }; [INFO] [stderr] | |_____- help: try this: `if metadata.find(';').is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metadata.rs:179:71 [INFO] [stderr] | [INFO] [stderr] 179 | Ok(metadata.split(sep).map(|s| String::from(s.trim())).filter(|s| s.len() > 0).collect()) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/settings.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | source_dir: cwd.join(".").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cwd.join(".")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/settings.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | output_dir: cwd.join("_output").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cwd.join("_output")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/settings.rs:59:26 [INFO] [stderr] | [INFO] [stderr] 59 | layouts_dir: cwd.join("_layouts").into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cwd.join("_layouts")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/settings.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | .map(|table| Value::Table(table)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Value::Table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / path.extension() [INFO] [stderr] 105 | | .and_then(|extension| extension.to_str()) [INFO] [stderr] 106 | | .and_then(|extension_str| self.readers.get(extension_str)) [INFO] [stderr] 107 | | .map(|rc| rc.clone()) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 104 | path.extension() [INFO] [stderr] 105 | .and_then(|extension| extension.to_str()) [INFO] [stderr] 106 | .and_then(|extension_str| self.readers.get(extension_str)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | try! { fd.write(output.as_ref()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:258:52 [INFO] [stderr] | [INFO] [stderr] 258 | let documents: Vec> = self.documents.values().map(|rc| rc.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.documents.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `helianto`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3fb34c1bce44c482272038ca734feef29e94b1ce206c4f7feb22f1a7437ab4cf"` [INFO] running `"docker" "rm" "-f" "3fb34c1bce44c482272038ca734feef29e94b1ce206c4f7feb22f1a7437ab4cf"` [INFO] [stdout] 3fb34c1bce44c482272038ca734feef29e94b1ce206c4f7feb22f1a7437ab4cf