[INFO] crate hdrhistogram-c 0.1.17 is already in cache [INFO] extracting crate hdrhistogram-c 0.1.17 into work/ex/clippy-test-run/sources/stable/reg/hdrhistogram-c/0.1.17 [INFO] extracting crate hdrhistogram-c 0.1.17 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdrhistogram-c/0.1.17 [INFO] validating manifest of hdrhistogram-c-0.1.17 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hdrhistogram-c-0.1.17 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hdrhistogram-c-0.1.17 [INFO] finished frobbing hdrhistogram-c-0.1.17 [INFO] frobbed toml for hdrhistogram-c-0.1.17 written to work/ex/clippy-test-run/sources/stable/reg/hdrhistogram-c/0.1.17/Cargo.toml [INFO] started frobbing hdrhistogram-c-0.1.17 [INFO] finished frobbing hdrhistogram-c-0.1.17 [INFO] frobbed toml for hdrhistogram-c-0.1.17 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdrhistogram-c/0.1.17/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hdrhistogram-c-0.1.17 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hdrhistogram-c/0.1.17:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8be29cb75841befaf0e9dfbb6bf5278c7e4bdd3d3d28ac39b52d94f27aecb12 [INFO] running `"docker" "start" "-a" "b8be29cb75841befaf0e9dfbb6bf5278c7e4bdd3d3d28ac39b52d94f27aecb12"` [INFO] [stderr] Compiling hdrhistogram-c v0.1.17 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi/test.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | Loaded { raw: raw, cor: cor, scaled_raw: scaled_raw, scaled_cor: scaled_cor } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi/test.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | Loaded { raw: raw, cor: cor, scaled_raw: scaled_raw, scaled_cor: scaled_cor } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi/test.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | Loaded { raw: raw, cor: cor, scaled_raw: scaled_raw, scaled_cor: scaled_cor } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scaled_raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi/test.rs:37:58 [INFO] [stderr] | [INFO] [stderr] 37 | Loaded { raw: raw, cor: cor, scaled_raw: scaled_raw, scaled_cor: scaled_cor } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scaled_cor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi/mod.rs:218:28 [INFO] [stderr] | [INFO] [stderr] 218 | Ok(Histogram { histo: histo, owned: true }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `histo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi/mod.rs:218:28 [INFO] [stderr] | [INFO] [stderr] 218 | Ok(Histogram { histo: histo, owned: true }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `histo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | raw.record_value(100000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | cor.record_corrected_value(100000000, interval); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | scaled_raw.record_value(100000000 * scale); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:35:39 [INFO] [stderr] | [INFO] [stderr] 35 | scaled_cor.record_corrected_value(100000000 * scale, scaled_interval); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | let h = Histogram::init(1, 3600000000, 3).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_600_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | assert_eq!(h.get_memory_size(), 188512); [INFO] [stderr] | ^^^^^^ help: consider: `188_512` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:56:32 [INFO] [stderr] | [INFO] [stderr] 56 | assert!(Histogram::init(0, 6481024, 2).is_err()); [INFO] [stderr] | ^^^^^^^ help: consider: `6_481_024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | assert!(Histogram::init(1, 3600000000, 6).is_err()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_600_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:78:50 [INFO] [stderr] | [INFO] [stderr] 78 | assert!(raw.values_are_equivalent(raw.max(), 100000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:79:50 [INFO] [stderr] | [INFO] [stderr] 79 | assert!(cor.values_are_equivalent(cor.max(), 100000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:97:65 [INFO] [stderr] | [INFO] [stderr] 97 | assert!(compare_percentile(raw.value_at_percentile(99.999), 100000000.0, 0.001)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `100_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:98:64 [INFO] [stderr] | [INFO] [stderr] 98 | assert!(compare_percentile(raw.value_at_percentile(100.0), 100000000.0, 0.001)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `100_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:102:63 [INFO] [stderr] | [INFO] [stderr] 102 | assert!(compare_percentile(cor.value_at_percentile(75.0), 50000000.0, 0.001)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `50_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:103:63 [INFO] [stderr] | [INFO] [stderr] 103 | assert!(compare_percentile(cor.value_at_percentile(90.0), 80000000.0, 0.001)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `80_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:104:63 [INFO] [stderr] | [INFO] [stderr] 104 | assert!(compare_percentile(cor.value_at_percentile(99.0), 98000000.0, 0.001)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `98_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:105:65 [INFO] [stderr] | [INFO] [stderr] 105 | assert!(compare_percentile(cor.value_at_percentile(99.999), 100000000.0, 0.001)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `100_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:106:64 [INFO] [stderr] | [INFO] [stderr] 106 | assert!(compare_percentile(cor.value_at_percentile(100.0), 100000000.0, 0.001)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `100_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:140:40 [INFO] [stderr] | [INFO] [stderr] 140 | for (idx, item) in raw.linear_iter(100000).enumerate() { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:215:67 [INFO] [stderr] | [INFO] [stderr] 215 | assert!(compare_values(cor.mean() * 512.0, scaled_cor.mean(), 0.000001)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:234:33 [INFO] [stderr] | [INFO] [stderr] 234 | let mut h = Histogram::init(20000000, 100000000, 5).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:234:43 [INFO] [stderr] | [INFO] [stderr] 234 | let mut h = Histogram::init(20000000, 100000000, 5).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | h.record_value(100000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | h.record_value(20000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | h.record_value(30000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `30_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:240:37 [INFO] [stderr] | [INFO] [stderr] 240 | assert!(h.values_are_equivalent(20000000, h.value_at_percentile(50.0))); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:241:37 [INFO] [stderr] | [INFO] [stderr] 241 | assert!(h.values_are_equivalent(30000000, h.value_at_percentile(83.33))); [INFO] [stderr] | ^^^^^^^^ help: consider: `30_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:242:37 [INFO] [stderr] | [INFO] [stderr] 242 | assert!(h.values_are_equivalent(100000000, h.value_at_percentile(83.34))); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:243:37 [INFO] [stderr] | [INFO] [stderr] 243 | assert!(h.values_are_equivalent(100000000, h.value_at_percentile(99.0))); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:248:33 [INFO] [stderr] | [INFO] [stderr] 248 | let mut h = Histogram::init(20000000, 100000000, 5).unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:248:43 [INFO] [stderr] | [INFO] [stderr] 248 | let mut h = Histogram::init(20000000, 100000000, 5).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:250:20 [INFO] [stderr] | [INFO] [stderr] 250 | h.record_value(100000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:251:20 [INFO] [stderr] | [INFO] [stderr] 251 | h.record_value(20000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:252:20 [INFO] [stderr] | [INFO] [stderr] 252 | h.record_value(30000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `30_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:259:33 [INFO] [stderr] | [INFO] [stderr] 259 | assert_eq!(h.count_at_value(100000000), b.count_at_value(100000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi/test.rs:259:62 [INFO] [stderr] | [INFO] [stderr] 259 | assert_eq!(h.count_at_value(100000000), b.count_at_value(100000000)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ffi/mod.rs:372:5 [INFO] [stderr] | [INFO] [stderr] 372 | / pub fn linear_iter<'a>(&'a self, value_units_per_bucket: u64) -> LinearIter<'a> { [INFO] [stderr] 373 | | let mut ret = LinearIter { iter: Default::default(), histo: PhantomData }; [INFO] [stderr] 374 | | unsafe { hdr_iter_linear_init(&mut ret.iter, self.histo, value_units_per_bucket as int64_t) }; [INFO] [stderr] 375 | | ret [INFO] [stderr] 376 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ffi/mod.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | / pub fn log_iter<'a>(&'a self, value_units_per_bucket: u64, log_base: f64) -> LogIter<'a> { [INFO] [stderr] 380 | | let mut ret = LogIter { iter: Default::default(), histo: PhantomData }; [INFO] [stderr] 381 | | unsafe { hdr_iter_log_init(&mut ret.iter, self.histo, value_units_per_bucket as int64_t, log_base) }; [INFO] [stderr] 382 | | ret [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ffi/mod.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | / pub fn recorded_iter<'a>(&'a self) -> RecordedIter<'a> { [INFO] [stderr] 387 | | let mut ret = RecordedIter { iter: Default::default(), histo: PhantomData }; [INFO] [stderr] 388 | | unsafe { hdr_iter_recorded_init(&mut ret.iter, self.histo) }; [INFO] [stderr] 389 | | ret [INFO] [stderr] 390 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ffi/mod.rs:393:5 [INFO] [stderr] | [INFO] [stderr] 393 | / pub fn percentile_iter<'a>(&'a self, ticks_per_half_distance: u32) -> PercentileIter<'a> { [INFO] [stderr] 394 | | let mut ret = PercentileIter { iter: Default::default(), histo: PhantomData }; [INFO] [stderr] 395 | | unsafe { hdr_iter_percentile_init(&mut ret.iter, self.histo, ticks_per_half_distance as int32_t) }; [INFO] [stderr] 396 | | ret [INFO] [stderr] 397 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/ffi/mod.rs:410:17 [INFO] [stderr] | [INFO] [stderr] 409 | let mut v = Vec::with_capacity(sz); [INFO] [stderr] | ---------------------- help: consider replace allocation with: `vec![0; sz]` [INFO] [stderr] 410 | v.set_len(sz); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ffi/mod.rs:422:27 [INFO] [stderr] | [INFO] [stderr] 422 | pub fn decode(base64: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ffi/mod.rs:528:51 [INFO] [stderr] | [INFO] [stderr] 528 | let lin : &hdr_iter_linear = unsafe { mem::transmute(&self.iter.union) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.iter.union as *const [i64; 4] as *const ffi::hdr_iter_linear)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ffi/mod.rs:555:48 [INFO] [stderr] | [INFO] [stderr] 555 | let log : &hdr_iter_log = unsafe { mem::transmute(&self.iter.union) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.iter.union as *const [i64; 4] as *const ffi::hdr_iter_log)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ffi/mod.rs:582:53 [INFO] [stderr] | [INFO] [stderr] 582 | let rec : &hdr_iter_recorded = unsafe { mem::transmute(&self.iter.union) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.iter.union as *const [i64; 4] as *const ffi::hdr_iter_recorded)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ffi/mod.rs:609:57 [INFO] [stderr] | [INFO] [stderr] 609 | let perc : &hdr_iter_percentiles = unsafe { mem::transmute(&self.iter.union) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.iter.union as *const [i64; 4] as *const ffi::hdr_iter_percentiles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hdrhistogram-c`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ffi/mod.rs:372:5 [INFO] [stderr] | [INFO] [stderr] 372 | / pub fn linear_iter<'a>(&'a self, value_units_per_bucket: u64) -> LinearIter<'a> { [INFO] [stderr] 373 | | let mut ret = LinearIter { iter: Default::default(), histo: PhantomData }; [INFO] [stderr] 374 | | unsafe { hdr_iter_linear_init(&mut ret.iter, self.histo, value_units_per_bucket as int64_t) }; [INFO] [stderr] 375 | | ret [INFO] [stderr] 376 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ffi/mod.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | / pub fn log_iter<'a>(&'a self, value_units_per_bucket: u64, log_base: f64) -> LogIter<'a> { [INFO] [stderr] 380 | | let mut ret = LogIter { iter: Default::default(), histo: PhantomData }; [INFO] [stderr] 381 | | unsafe { hdr_iter_log_init(&mut ret.iter, self.histo, value_units_per_bucket as int64_t, log_base) }; [INFO] [stderr] 382 | | ret [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ffi/mod.rs:386:5 [INFO] [stderr] | [INFO] [stderr] 386 | / pub fn recorded_iter<'a>(&'a self) -> RecordedIter<'a> { [INFO] [stderr] 387 | | let mut ret = RecordedIter { iter: Default::default(), histo: PhantomData }; [INFO] [stderr] 388 | | unsafe { hdr_iter_recorded_init(&mut ret.iter, self.histo) }; [INFO] [stderr] 389 | | ret [INFO] [stderr] 390 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ffi/mod.rs:393:5 [INFO] [stderr] | [INFO] [stderr] 393 | / pub fn percentile_iter<'a>(&'a self, ticks_per_half_distance: u32) -> PercentileIter<'a> { [INFO] [stderr] 394 | | let mut ret = PercentileIter { iter: Default::default(), histo: PhantomData }; [INFO] [stderr] 395 | | unsafe { hdr_iter_percentile_init(&mut ret.iter, self.histo, ticks_per_half_distance as int32_t) }; [INFO] [stderr] 396 | | ret [INFO] [stderr] 397 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/ffi/mod.rs:410:17 [INFO] [stderr] | [INFO] [stderr] 409 | let mut v = Vec::with_capacity(sz); [INFO] [stderr] | ---------------------- help: consider replace allocation with: `vec![0; sz]` [INFO] [stderr] 410 | v.set_len(sz); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ffi/mod.rs:422:27 [INFO] [stderr] | [INFO] [stderr] 422 | pub fn decode(base64: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ffi/mod.rs:528:51 [INFO] [stderr] | [INFO] [stderr] 528 | let lin : &hdr_iter_linear = unsafe { mem::transmute(&self.iter.union) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.iter.union as *const [i64; 4] as *const ffi::hdr_iter_linear)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ffi/mod.rs:555:48 [INFO] [stderr] | [INFO] [stderr] 555 | let log : &hdr_iter_log = unsafe { mem::transmute(&self.iter.union) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.iter.union as *const [i64; 4] as *const ffi::hdr_iter_log)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ffi/mod.rs:582:53 [INFO] [stderr] | [INFO] [stderr] 582 | let rec : &hdr_iter_recorded = unsafe { mem::transmute(&self.iter.union) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.iter.union as *const [i64; 4] as *const ffi::hdr_iter_recorded)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ffi/mod.rs:609:57 [INFO] [stderr] | [INFO] [stderr] 609 | let perc : &hdr_iter_percentiles = unsafe { mem::transmute(&self.iter.union) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.iter.union as *const [i64; 4] as *const ffi::hdr_iter_percentiles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hdrhistogram-c`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b8be29cb75841befaf0e9dfbb6bf5278c7e4bdd3d3d28ac39b52d94f27aecb12"` [INFO] running `"docker" "rm" "-f" "b8be29cb75841befaf0e9dfbb6bf5278c7e4bdd3d3d28ac39b52d94f27aecb12"` [INFO] [stdout] b8be29cb75841befaf0e9dfbb6bf5278c7e4bdd3d3d28ac39b52d94f27aecb12