[INFO] crate hdrhistogram 6.1.1 is already in cache [INFO] extracting crate hdrhistogram 6.1.1 into work/ex/clippy-test-run/sources/stable/reg/hdrhistogram/6.1.1 [INFO] extracting crate hdrhistogram 6.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdrhistogram/6.1.1 [INFO] validating manifest of hdrhistogram-6.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hdrhistogram-6.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hdrhistogram-6.1.1 [INFO] removed 1 missing examples [INFO] finished frobbing hdrhistogram-6.1.1 [INFO] frobbed toml for hdrhistogram-6.1.1 written to work/ex/clippy-test-run/sources/stable/reg/hdrhistogram/6.1.1/Cargo.toml [INFO] started frobbing hdrhistogram-6.1.1 [INFO] removed 1 missing examples [INFO] finished frobbing hdrhistogram-6.1.1 [INFO] frobbed toml for hdrhistogram-6.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdrhistogram/6.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hdrhistogram-6.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hdrhistogram/6.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f57539441e844ef34aca3afc592a3af551cceb67ba8fbf9d38a8ff95b458345 [INFO] running `"docker" "start" "-a" "9f57539441e844ef34aca3afc592a3af551cceb67ba8fbf9d38a8ff95b458345"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/cli.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.10 [INFO] [stderr] Compiling rug v1.3.0 [INFO] [stderr] Checking hdrhistogram v6.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/serialization/interval_log/mod.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | write!(self.writer, "#{}\n", l)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/iterators/quantile.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/serialization/deserializer.rs:95:48 [INFO] [stderr] | [INFO] [stderr] 95 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialization/interval_log/mod.rs:751:13 [INFO] [stderr] | [INFO] [stderr] 751 | return Err(Err::Error(error_position!(input, ErrorKind::Custom(0)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Err::Error(error_position!(input, ErrorKind::Custom(0))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serialization/interval_log/mod.rs:753:19 [INFO] [stderr] | [INFO] [stderr] 753 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/iterators/quantile.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `serialization::interval_log::IntervalLogWriterBuilder` [INFO] [stderr] --> src/serialization/interval_log/mod.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / pub fn new() -> IntervalLogWriterBuilder { [INFO] [stderr] 238 | | IntervalLogWriterBuilder { [INFO] [stderr] 239 | | comments: Vec::new(), [INFO] [stderr] 240 | | start_time: None, [INFO] [stderr] ... | [INFO] [stderr] 243 | | } [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 228 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/serialization/interval_log/mod.rs:322:12 [INFO] [stderr] | [INFO] [stderr] 322 | if self.max_value_divisor != 1.0_f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.max_value_divisor - 1.0_f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/serialization/interval_log/mod.rs:322:12 [INFO] [stderr] | [INFO] [stderr] 322 | if self.max_value_divisor != 1.0_f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/serialization/interval_log/mod.rs:453:22 [INFO] [stderr] | [INFO] [stderr] 453 | .map_err(|e| IntervalLogWriterError::SerializeError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `IntervalLogWriterError::SerializeError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/serialization/interval_log/mod.rs:660:26 [INFO] [stderr] | [INFO] [stderr] 660 | d.as_secs() as f64 + d.subsec_nanos() as f64 / 1_000_000_000_f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hdrhistogram`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "9f57539441e844ef34aca3afc592a3af551cceb67ba8fbf9d38a8ff95b458345"` [INFO] running `"docker" "rm" "-f" "9f57539441e844ef34aca3afc592a3af551cceb67ba8fbf9d38a8ff95b458345"` [INFO] [stdout] 9f57539441e844ef34aca3afc592a3af551cceb67ba8fbf9d38a8ff95b458345