[INFO] crate hdlc 0.2.4 is already in cache [INFO] extracting crate hdlc 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/hdlc/0.2.4 [INFO] extracting crate hdlc 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdlc/0.2.4 [INFO] validating manifest of hdlc-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hdlc-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hdlc-0.2.4 [INFO] finished frobbing hdlc-0.2.4 [INFO] frobbed toml for hdlc-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/hdlc/0.2.4/Cargo.toml [INFO] started frobbing hdlc-0.2.4 [INFO] finished frobbing hdlc-0.2.4 [INFO] frobbed toml for hdlc-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdlc/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hdlc-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hdlc/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0959227e1bbbac2b205a0a1cbd416c8a3e1e9e086c9e213108b2c177fae9c7a5 [INFO] running `"docker" "start" "-a" "0959227e1bbbac2b205a0a1cbd416c8a3e1e9e086c9e213108b2c177fae9c7a5"` [INFO] [stderr] Checking hdlc v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | return Err(HDLCError::MissingFinalFend); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HDLCError::MissingFinalFend)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:360:20 [INFO] [stderr] | [INFO] [stderr] 360 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 361 | | if sync > 0 { [INFO] [stderr] 362 | | // Minus 1 because indexing starts at 0 [INFO] [stderr] 363 | | input[index - swap - 1] = *byte; [INFO] [stderr] 364 | | } [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 360 | } else if sync > 0 { [INFO] [stderr] 361 | // Minus 1 because indexing starts at 0 [INFO] [stderr] 362 | input[index - swap - 1] = *byte; [INFO] [stderr] 363 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn encode(data: &Vec, s_chars: SpecialChars) -> Result, HDLCError> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:162:31 [INFO] [stderr] | [INFO] [stderr] 162 | let mut input_iter = data.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:168:29 [INFO] [stderr] | [INFO] [stderr] 168 | while let Some(value) = input_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `for value in input_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / match value { [INFO] [stderr] 170 | | // FEND and FESC [INFO] [stderr] 171 | | &val if val == s_chars.fesc => { [INFO] [stderr] 172 | | output.push(s_chars.fesc); [INFO] [stderr] ... | [INFO] [stderr] 180 | | _ => output.push(*value), [INFO] [stderr] 181 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 169 | match *value { [INFO] [stderr] 170 | // FEND and FESC [INFO] [stderr] 171 | val if val == s_chars.fesc => { [INFO] [stderr] 172 | output.push(s_chars.fesc); [INFO] [stderr] 173 | output.push(s_chars.tfesc); [INFO] [stderr] 174 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn decode(input: &Vec, s_chars: SpecialChars) -> Result, HDLCError> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:236:32 [INFO] [stderr] | [INFO] [stderr] 236 | let mut input_iter = input.into_iter().peekable(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | / match value { [INFO] [stderr] 248 | | // Handle a FESC [INFO] [stderr] 249 | | &val if val == s_chars.fesc => match input_iter.next() { [INFO] [stderr] 250 | | Some(&val) if val == s_chars.tfend => output.push(s_chars.fend), [INFO] [stderr] ... | [INFO] [stderr] 263 | | _ => output.push(*value), [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 247 | match *value { [INFO] [stderr] 248 | // Handle a FESC [INFO] [stderr] 249 | val if val == s_chars.fesc => match input_iter.next() { [INFO] [stderr] 250 | Some(&val) if val == s_chars.tfend => output.push(s_chars.fend), [INFO] [stderr] 251 | Some(&val) if val == s_chars.tfesc => output.push(s_chars.fesc), [INFO] [stderr] 252 | _ => return Err(HDLCError::MissingTradeChar), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | swap = swap + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `swap += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:335:17 [INFO] [stderr] | [INFO] [stderr] 335 | swap = swap + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `swap += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | return Err(HDLCError::MissingFinalFend); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HDLCError::MissingFinalFend)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:360:20 [INFO] [stderr] | [INFO] [stderr] 360 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 361 | | if sync > 0 { [INFO] [stderr] 362 | | // Minus 1 because indexing starts at 0 [INFO] [stderr] 363 | | input[index - swap - 1] = *byte; [INFO] [stderr] 364 | | } [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 360 | } else if sync > 0 { [INFO] [stderr] 361 | // Minus 1 because indexing starts at 0 [INFO] [stderr] 362 | input[index - swap - 1] = *byte; [INFO] [stderr] 363 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn encode(data: &Vec, s_chars: SpecialChars) -> Result, HDLCError> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:162:31 [INFO] [stderr] | [INFO] [stderr] 162 | let mut input_iter = data.into_iter(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:168:29 [INFO] [stderr] | [INFO] [stderr] 168 | while let Some(value) = input_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `for value in input_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / match value { [INFO] [stderr] 170 | | // FEND and FESC [INFO] [stderr] 171 | | &val if val == s_chars.fesc => { [INFO] [stderr] 172 | | output.push(s_chars.fesc); [INFO] [stderr] ... | [INFO] [stderr] 180 | | _ => output.push(*value), [INFO] [stderr] 181 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 169 | match *value { [INFO] [stderr] 170 | // FEND and FESC [INFO] [stderr] 171 | val if val == s_chars.fesc => { [INFO] [stderr] 172 | output.push(s_chars.fesc); [INFO] [stderr] 173 | output.push(s_chars.tfesc); [INFO] [stderr] 174 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn decode(input: &Vec, s_chars: SpecialChars) -> Result, HDLCError> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:236:32 [INFO] [stderr] | [INFO] [stderr] 236 | let mut input_iter = input.into_iter().peekable(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | / match value { [INFO] [stderr] 248 | | // Handle a FESC [INFO] [stderr] 249 | | &val if val == s_chars.fesc => match input_iter.next() { [INFO] [stderr] 250 | | Some(&val) if val == s_chars.tfend => output.push(s_chars.fend), [INFO] [stderr] ... | [INFO] [stderr] 263 | | _ => output.push(*value), [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 247 | match *value { [INFO] [stderr] 248 | // Handle a FESC [INFO] [stderr] 249 | val if val == s_chars.fesc => match input_iter.next() { [INFO] [stderr] 250 | Some(&val) if val == s_chars.tfend => output.push(s_chars.fend), [INFO] [stderr] 251 | Some(&val) if val == s_chars.tfesc => output.push(s_chars.fesc), [INFO] [stderr] 252 | _ => return Err(HDLCError::MissingTradeChar), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | swap = swap + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `swap += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:335:17 [INFO] [stderr] | [INFO] [stderr] 335 | swap = swap + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `swap += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `hdlc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0959227e1bbbac2b205a0a1cbd416c8a3e1e9e086c9e213108b2c177fae9c7a5"` [INFO] running `"docker" "rm" "-f" "0959227e1bbbac2b205a0a1cbd416c8a3e1e9e086c9e213108b2c177fae9c7a5"` [INFO] [stdout] 0959227e1bbbac2b205a0a1cbd416c8a3e1e9e086c9e213108b2c177fae9c7a5