[INFO] crate hdf5 0.4.1 is already in cache [INFO] extracting crate hdf5 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/hdf5/0.4.1 [INFO] extracting crate hdf5 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdf5/0.4.1 [INFO] validating manifest of hdf5-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hdf5-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hdf5-0.4.1 [INFO] removed 0 missing tests [INFO] finished frobbing hdf5-0.4.1 [INFO] frobbed toml for hdf5-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/hdf5/0.4.1/Cargo.toml [INFO] started frobbing hdf5-0.4.1 [INFO] removed 0 missing tests [INFO] finished frobbing hdf5-0.4.1 [INFO] frobbed toml for hdf5-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdf5/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hdf5-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hdf5/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15af1e70d100ba9d38747522185cc6350e55a740b7abd6a2bed0529637ef8102 [INFO] running `"docker" "start" "-a" "15af1e70d100ba9d38747522185cc6350e55a740b7abd6a2bed0529637ef8102"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/write.rs [INFO] [stderr] * /opt/crater/workdir/tests/encode.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling hdf5-sys v0.4.1 [INFO] [stderr] Checking hdf5 v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:163:43 [INFO] [stderr] | [INFO] [stderr] 163 | Ok(Slice { data: self.as_bytes(), datatype: datatype, dimensions: [1] }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dataspace.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | Dataspace { id: id } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(Inner { dataset: dataset, datatype: datatype, dimensions: dimensions.len() }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dataset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:75:38 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(Inner { dataset: dataset, datatype: datatype, dimensions: dimensions.len() }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | Encoder { file: file, name: Some(name.to_string()), state: State::Uncertain } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(Blob { data: data, datatype: datatype, dimensions: [length] }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:138:31 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(Blob { data: data, datatype: datatype, dimensions: [length] }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Blob { data: data, datatype: datatype, dimensions: [1] }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Blob { data: data, datatype: datatype, dimensions: [1] }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:163:43 [INFO] [stderr] | [INFO] [stderr] 163 | Ok(Slice { data: self.as_bytes(), datatype: datatype, dimensions: [1] }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dataspace.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | Dataspace { id: id } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(Inner { dataset: dataset, datatype: datatype, dimensions: dimensions.len() }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dataset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:75:38 [INFO] [stderr] | [INFO] [stderr] 75 | Ok(Inner { dataset: dataset, datatype: datatype, dimensions: dimensions.len() }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | Encoder { file: file, name: Some(name.to_string()), state: State::Uncertain } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(Blob { data: data, datatype: datatype, dimensions: [length] }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:138:31 [INFO] [stderr] | [INFO] [stderr] 138 | Ok(Blob { data: data, datatype: datatype, dimensions: [length] }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Blob { data: data, datatype: datatype, dimensions: [1] }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:150:31 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Blob { data: data, datatype: datatype, dimensions: [1] }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `datatype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/data.rs:7:27 [INFO] [stderr] | [INFO] [stderr] 7 | const SCALAR_DIMENSIONS: &'static [usize] = &[1]; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/data.rs:7:27 [INFO] [stderr] | [INFO] [stderr] 7 | const SCALAR_DIMENSIONS: &'static [usize] = &[1]; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dataspace.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | 0 as *const _, size.as_ptr() as *const _, 0 as *const _), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dataspace.rs:15:80 [INFO] [stderr] | [INFO] [stderr] 15 | 0 as *const _, size.as_ptr() as *const _, 0 as *const _), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dataspace.rs:30:72 [INFO] [stderr] | [INFO] [stderr] 30 | dimensions.as_ptr() as *const _, 0 as *const _), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/datatype.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if size <= 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using size == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dataspace.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | 0 as *const _, size.as_ptr() as *const _, 0 as *const _), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dataspace.rs:15:80 [INFO] [stderr] | [INFO] [stderr] 15 | 0 as *const _, size.as_ptr() as *const _, 0 as *const _), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/dataspace.rs:30:72 [INFO] [stderr] | [INFO] [stderr] 30 | dimensions.as_ptr() as *const _, 0 as *const _), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/datatype.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if size <= 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using size == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/encoder.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | copy(from.as_ptr(), into.as_mut_ptr().offset(current as isize), delta); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `into.as_mut_ptr().add(current)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/encoder.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | copy(from.as_ptr(), into.as_mut_ptr().offset(current as isize), delta); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `into.as_mut_ptr().add(current)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hdf5`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hdf5`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "15af1e70d100ba9d38747522185cc6350e55a740b7abd6a2bed0529637ef8102"` [INFO] running `"docker" "rm" "-f" "15af1e70d100ba9d38747522185cc6350e55a740b7abd6a2bed0529637ef8102"` [INFO] [stdout] 15af1e70d100ba9d38747522185cc6350e55a740b7abd6a2bed0529637ef8102