[INFO] crate hdbconnect 0.10.0 is already in cache [INFO] extracting crate hdbconnect 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/hdbconnect/0.10.0 [INFO] extracting crate hdbconnect 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdbconnect/0.10.0 [INFO] validating manifest of hdbconnect-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hdbconnect-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hdbconnect-0.10.0 [INFO] finished frobbing hdbconnect-0.10.0 [INFO] frobbed toml for hdbconnect-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/hdbconnect/0.10.0/Cargo.toml [INFO] started frobbing hdbconnect-0.10.0 [INFO] finished frobbing hdbconnect-0.10.0 [INFO] frobbed toml for hdbconnect-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hdbconnect/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hdbconnect-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hdbconnect/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66d303aaed00430e73468a82849e1cd77acc6709c5bc9051e61b223b539744b3 [INFO] running `"docker" "start" "-a" "66d303aaed00430e73468a82849e1cd77acc6709c5bc9051e61b223b539744b3"` [INFO] [stderr] Checking dist_tx v0.2.2 [INFO] [stderr] Checking serde_db v0.5.1 [INFO] [stderr] Checking num-bigint v0.2.2 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking blake2 v0.8.0 [INFO] [stderr] Checking pbkdf2 v0.3.0 [INFO] [stderr] Checking flexi_logger v0.10.5 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking bigdecimal v0.0.14 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking hdbconnect v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/conn_core/connection_core.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unit_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/connection.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | #[allow(unit_arg)] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::unit_arg` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/conn_core/connection_core.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/protocol/argument.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/protocol/reply.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | #[allow(let_and_return)] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unit_arg` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/connection.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | #[allow(unit_arg)] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::unit_arg` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/protocol/argument.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/protocol/reply.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | #[allow(let_and_return)] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/conn_core/connection_core.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/conn_core/connection_core.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/authentication/scram_pbkdf2_sha256.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Box { [INFO] [stderr] 20 | | let mut client_challenge = [0u8; 64]; [INFO] [stderr] 21 | | let mut rng = thread_rng(); [INFO] [stderr] 22 | | rng.fill_bytes(&mut client_challenge); [INFO] [stderr] ... | [INFO] [stderr] 26 | | }) [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/authentication/scram_sha256.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Box { [INFO] [stderr] 19 | | let mut client_challenge = [0u8; 64]; [INFO] [stderr] 20 | | let mut rng = thread_rng(); [INFO] [stderr] 21 | | rng.fill_bytes(&mut client_challenge); [INFO] [stderr] ... | [INFO] [stderr] 25 | | }) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/authentication/scram_pbkdf2_sha256.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Box { [INFO] [stderr] 20 | | let mut client_challenge = [0u8; 64]; [INFO] [stderr] 21 | | let mut rng = thread_rng(); [INFO] [stderr] 22 | | rng.fill_bytes(&mut client_challenge); [INFO] [stderr] ... | [INFO] [stderr] 26 | | }) [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/authentication/scram_sha256.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Box { [INFO] [stderr] 19 | | let mut client_challenge = [0u8; 64]; [INFO] [stderr] 20 | | let mut rng = thread_rng(); [INFO] [stderr] 21 | | rng.fill_bytes(&mut client_challenge); [INFO] [stderr] ... | [INFO] [stderr] 25 | | }) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/test_050_metadata.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/test_050_metadata.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> tests/test_032_blobs.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 66 | let mut raw_data = Vec::::with_capacity(SIZE); [INFO] [stderr] | ------------------------------ help: consider replace allocation with: `vec![0; SIZE]` [INFO] [stderr] 67 | raw_data.resize(SIZE, 0_u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> tests/test_011_invalid_password.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | if let Err(_) = result { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 73 | | panic!("Changing password did not reopen the connection"); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____- help: try this: `if result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> tests/test_023_secondtime.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / fn test_secondtime(_loghandle: &mut ReconfigurationHandle) -> HdbResult { [INFO] [stderr] 29 | | info!("verify that NaiveTime values match the expected string representation"); [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | debug!("prepare the test data"); [INFO] [stderr] ... | [INFO] [stderr] 128 | | Ok(connection.get_call_count()?) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> tests/test_024_daydate.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / fn test_daydate(_loghandle: &mut ReconfigurationHandle) -> HdbResult { [INFO] [stderr] 29 | | info!("verify that NaiveDate values match the expected string representation"); [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | debug!("prepare the test data"); [INFO] [stderr] ... | [INFO] [stderr] 141 | | Ok(connection.get_call_count()?) [INFO] [stderr] 142 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/test_025_decimals.rs:59:62 [INFO] [stderr] | [INFO] [stderr] 59 | insert_stmt.add_batch(&("75.53500", BigDecimal::from_f32(75.53500).unwrap()))?; [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `75.535` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/test_025_decimals.rs:95:27 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(td.f1, format!("{}", format!("{0:.1$}", td.f2, scale))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/test_015_resultset.rs:158:37 [INFO] [stderr] | [INFO] [stderr] 158 | for fs in [10, 100, 1000, 2000].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `hdbconnect`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | let sep3 = url[sep1 + 3..].find("@").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/test_utils/mod.rs:40:41 [INFO] [stderr] | [INFO] [stderr] 40 | let sep2 = url[sep1 + 3..sep3].find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/test_027_small_decimals.rs:59:62 [INFO] [stderr] | [INFO] [stderr] 59 | insert_stmt.add_batch(&("75.53500", BigDecimal::from_f32(75.53500).unwrap()))?; [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `75.535` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/test_027_small_decimals.rs:96:27 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(td.f1, format!("{}", format!("{0:.1$}", td.f2, scale))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "66d303aaed00430e73468a82849e1cd77acc6709c5bc9051e61b223b539744b3"` [INFO] running `"docker" "rm" "-f" "66d303aaed00430e73468a82849e1cd77acc6709c5bc9051e61b223b539744b3"` [INFO] [stdout] 66d303aaed00430e73468a82849e1cd77acc6709c5bc9051e61b223b539744b3