[INFO] crate hd44780-hal 0.2.1 is already in cache [INFO] extracting crate hd44780-hal 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/hd44780-hal/0.2.1 [INFO] extracting crate hd44780-hal 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hd44780-hal/0.2.1 [INFO] validating manifest of hd44780-hal-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hd44780-hal-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hd44780-hal-0.2.1 [INFO] finished frobbing hd44780-hal-0.2.1 [INFO] frobbed toml for hd44780-hal-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/hd44780-hal/0.2.1/Cargo.toml [INFO] started frobbing hd44780-hal-0.2.1 [INFO] finished frobbing hd44780-hal-0.2.1 [INFO] frobbed toml for hd44780-hal-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hd44780-hal/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hd44780-hal-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hd44780-hal/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a798ece12b7565b5501f9158282fbec3fbfa051100863c35b7741be7b5f4644 [INFO] running `"docker" "start" "-a" "9a798ece12b7565b5501f9158282fbec3fbfa051100863c35b7741be7b5f4644"` [INFO] [stderr] Checking hd44780-hal v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | return hd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:377:9 [INFO] [stderr] | [INFO] [stderr] 377 | return hd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:303:10 [INFO] [stderr] | [INFO] [stderr] 303 | ) -> HD44780> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | / pub fn new_8bit( [INFO] [stderr] 292 | | rs: RS, [INFO] [stderr] 293 | | en: EN, [INFO] [stderr] 294 | | d0: D0, [INFO] [stderr] ... | [INFO] [stderr] 322 | | return hd; [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | return hd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:377:9 [INFO] [stderr] | [INFO] [stderr] 377 | return hd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:303:10 [INFO] [stderr] | [INFO] [stderr] 303 | ) -> HD44780> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | / pub fn new_8bit( [INFO] [stderr] 292 | | rs: RS, [INFO] [stderr] 293 | | en: EN, [INFO] [stderr] 294 | | d0: D0, [INFO] [stderr] ... | [INFO] [stderr] 322 | | return hd; [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "9a798ece12b7565b5501f9158282fbec3fbfa051100863c35b7741be7b5f4644"` [INFO] running `"docker" "rm" "-f" "9a798ece12b7565b5501f9158282fbec3fbfa051100863c35b7741be7b5f4644"` [INFO] [stdout] 9a798ece12b7565b5501f9158282fbec3fbfa051100863c35b7741be7b5f4644