[INFO] crate hd44780-driver 0.2.1 is already in cache [INFO] extracting crate hd44780-driver 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/hd44780-driver/0.2.1 [INFO] extracting crate hd44780-driver 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hd44780-driver/0.2.1 [INFO] validating manifest of hd44780-driver-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hd44780-driver-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hd44780-driver-0.2.1 [INFO] finished frobbing hd44780-driver-0.2.1 [INFO] frobbed toml for hd44780-driver-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/hd44780-driver/0.2.1/Cargo.toml [INFO] started frobbing hd44780-driver-0.2.1 [INFO] finished frobbing hd44780-driver-0.2.1 [INFO] frobbed toml for hd44780-driver-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hd44780-driver/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hd44780-driver-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hd44780-driver/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afa7dfafdffd0f41831213e6609e661b5ef8a204d36f84ac6be360f840b642c2 [INFO] running `"docker" "start" "-a" "afa7dfafdffd0f41831213e6609e661b5ef8a204d36f84ac6be360f840b642c2"` [INFO] [stderr] Checking hd44780-driver v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return hd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return hd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/bus/eightbit.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn from_pins( [INFO] [stderr] 44 | | rs: RS, [INFO] [stderr] 45 | | en: EN, [INFO] [stderr] 46 | | d0: D0, [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/display_mode.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | let cursor_blink_bits = match self.cursor_blink { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 20 | | true => 0b0000_0001, [INFO] [stderr] 21 | | false => 0, [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.cursor_blink { 0b0000_0001 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/display_mode.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | let cursor_visible_bits = match self.cursor_visible { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 25 | | true => 0b0000_0010, [INFO] [stderr] 26 | | false => 0, [INFO] [stderr] 27 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.cursor_visible { 0b0000_0010 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/display_mode.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | let display_visible_bits = match self.display_visible { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 30 | | true => 0b0000_0100, [INFO] [stderr] 31 | | false => 0, [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.display_visible { 0b0000_0100 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:71:10 [INFO] [stderr] | [INFO] [stderr] 71 | ) -> HD44780> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new_8bit( [INFO] [stderr] 60 | | rs: RS, [INFO] [stderr] 61 | | en: EN, [INFO] [stderr] 62 | | d0: D0, [INFO] [stderr] ... | [INFO] [stderr] 81 | | return hd; [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return hd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return hd; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `hd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/bus/eightbit.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn from_pins( [INFO] [stderr] 44 | | rs: RS, [INFO] [stderr] 45 | | en: EN, [INFO] [stderr] 46 | | d0: D0, [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/display_mode.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | let cursor_blink_bits = match self.cursor_blink { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 20 | | true => 0b0000_0001, [INFO] [stderr] 21 | | false => 0, [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.cursor_blink { 0b0000_0001 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/display_mode.rs:24:35 [INFO] [stderr] | [INFO] [stderr] 24 | let cursor_visible_bits = match self.cursor_visible { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 25 | | true => 0b0000_0010, [INFO] [stderr] 26 | | false => 0, [INFO] [stderr] 27 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.cursor_visible { 0b0000_0010 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/display_mode.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | let display_visible_bits = match self.display_visible { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 30 | | true => 0b0000_0100, [INFO] [stderr] 31 | | false => 0, [INFO] [stderr] 32 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.display_visible { 0b0000_0100 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:71:10 [INFO] [stderr] | [INFO] [stderr] 71 | ) -> HD44780> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/lib.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new_8bit( [INFO] [stderr] 60 | | rs: RS, [INFO] [stderr] 61 | | en: EN, [INFO] [stderr] 62 | | d0: D0, [INFO] [stderr] ... | [INFO] [stderr] 81 | | return hd; [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "afa7dfafdffd0f41831213e6609e661b5ef8a204d36f84ac6be360f840b642c2"` [INFO] running `"docker" "rm" "-f" "afa7dfafdffd0f41831213e6609e661b5ef8a204d36f84ac6be360f840b642c2"` [INFO] [stdout] afa7dfafdffd0f41831213e6609e661b5ef8a204d36f84ac6be360f840b642c2