[INFO] crate hbs 0.2.0 is already in cache [INFO] extracting crate hbs 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/hbs/0.2.0 [INFO] extracting crate hbs 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hbs/0.2.0 [INFO] validating manifest of hbs-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hbs-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hbs-0.2.0 [INFO] finished frobbing hbs-0.2.0 [INFO] frobbed toml for hbs-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/hbs/0.2.0/Cargo.toml [INFO] started frobbing hbs-0.2.0 [INFO] finished frobbing hbs-0.2.0 [INFO] frobbed toml for hbs-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hbs/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hbs-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hbs/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb64c850048bb8ce4dc45a8e4cb1a4cf99f58b5ad89d9fefcd7281b00644e1e3 [INFO] running `"docker" "start" "-a" "bb64c850048bb8ce4dc45a8e4cb1a4cf99f58b5ad89d9fefcd7281b00644e1e3"` [INFO] [stderr] Compiling hbs-builder v0.2.1 [INFO] [stderr] Checking hbs-common-sys v0.2.1 [INFO] [stderr] Compiling hbs-sys v0.2.1 [INFO] [stderr] Checking hbs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Heartbeat { hb: hb, hbr: hbr, log: log, }) [INFO] [stderr] | ^^^^^^ help: replace it with: `hb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:51:32 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Heartbeat { hb: hb, hbr: hbr, log: log, }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `hbr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Heartbeat { hb: hb, hbr: hbr, log: log, }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Heartbeat { hb: hb, hbr: hbr, log: log, }) [INFO] [stderr] | ^^^^^^ help: replace it with: `hb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:51:32 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Heartbeat { hb: hb, hbr: hbr, log: log, }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `hbr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(Heartbeat { hb: hb, hbr: hbr, log: log, }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | const TIME_INC: u64 = 1000000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> lib.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | match Heartbeat::write_log(self.hbr.get(i as usize).unwrap(), l) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.hbr[i as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> lib.rs:81:48 [INFO] [stderr] | [INFO] [stderr] 81 | match Heartbeat::write_log(self.hbr.get(i as usize).unwrap(), l) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.hbr[i as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: static variable `received_cb` should have an upper case name such as `RECEIVED_CB` [INFO] [stderr] --> lib.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | static mut received_cb: bool = false; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.30s [INFO] running `"docker" "inspect" "bb64c850048bb8ce4dc45a8e4cb1a4cf99f58b5ad89d9fefcd7281b00644e1e3"` [INFO] running `"docker" "rm" "-f" "bb64c850048bb8ce4dc45a8e4cb1a4cf99f58b5ad89d9fefcd7281b00644e1e3"` [INFO] [stdout] bb64c850048bb8ce4dc45a8e4cb1a4cf99f58b5ad89d9fefcd7281b00644e1e3