[INFO] crate haudit 0.1.0 is already in cache [INFO] extracting crate haudit 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/haudit/0.1.0 [INFO] extracting crate haudit 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/haudit/0.1.0 [INFO] validating manifest of haudit-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of haudit-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing haudit-0.1.0 [INFO] finished frobbing haudit-0.1.0 [INFO] frobbed toml for haudit-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/haudit/0.1.0/Cargo.toml [INFO] started frobbing haudit-0.1.0 [INFO] finished frobbing haudit-0.1.0 [INFO] frobbed toml for haudit-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/haudit/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting haudit-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/haudit/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4346123ae43033aa080482f940100a376d6e1a5389bdf9dccc4a29c7d34304ce [INFO] running `"docker" "start" "-a" "4346123ae43033aa080482f940100a376d6e1a5389bdf9dccc4a29c7d34304ce"` [INFO] [stderr] Checking globset v0.2.1 [INFO] [stderr] Checking pem v0.4.1 [INFO] [stderr] Checking hackeraudit-api-common v0.1.0 [INFO] [stderr] Checking ignore v0.3.1 [INFO] [stderr] Checking haudit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:193:46 [INFO] [stderr] | [INFO] [stderr] 193 | println!("{} {:32}{:16} {}", "ERR", pkg.name, pkg.version, e); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:193:46 [INFO] [stderr] | [INFO] [stderr] 193 | println!("{} {:32}{:16} {}", "ERR", pkg.name, pkg.version, e); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / return Risk { [INFO] [stderr] 147 | | level: RiskLevel::None, [INFO] [stderr] 148 | | reason: "Positive review by self".into(), [INFO] [stderr] 149 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 146 | Risk { [INFO] [stderr] 147 | level: RiskLevel::None, [INFO] [stderr] 148 | reason: "Positive review by self".into(), [INFO] [stderr] 149 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:216:28 [INFO] [stderr] | [INFO] [stderr] 216 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 217 | | if res.is_err() { [INFO] [stderr] 218 | | eprintln!("Ignoring error for: {}", path.path().display()); [INFO] [stderr] 219 | | } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 216 | } else if res.is_err() { [INFO] [stderr] 217 | eprintln!("Ignoring error for: {}", path.path().display()); [INFO] [stderr] 218 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / return Risk { [INFO] [stderr] 147 | | level: RiskLevel::None, [INFO] [stderr] 148 | | reason: "Positive review by self".into(), [INFO] [stderr] 149 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 146 | Risk { [INFO] [stderr] 147 | level: RiskLevel::None, [INFO] [stderr] 148 | reason: "Positive review by self".into(), [INFO] [stderr] 149 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:216:28 [INFO] [stderr] | [INFO] [stderr] 216 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 217 | | if res.is_err() { [INFO] [stderr] 218 | | eprintln!("Ignoring error for: {}", path.path().display()); [INFO] [stderr] 219 | | } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 216 | } else if res.is_err() { [INFO] [stderr] 217 | eprintln!("Ignoring error for: {}", path.path().display()); [INFO] [stderr] 218 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:210:25 [INFO] [stderr] | [INFO] [stderr] 210 | Ok(path) => match path.file_name().to_str() { [INFO] [stderr] | _________________________^ [INFO] [stderr] 211 | | Some("Cargo.toml") => { [INFO] [stderr] 212 | | let res = [INFO] [stderr] 213 | | handle_cargo_lock(path.path().with_file_name("Cargo.lock"), &mut packages); [INFO] [stderr] ... | [INFO] [stderr] 222 | | _ => {} [INFO] [stderr] 223 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 210 | Ok(path) => if let Some("Cargo.toml") = path.file_name().to_str() { [INFO] [stderr] 211 | let res = [INFO] [stderr] 212 | handle_cargo_lock(path.path().with_file_name("Cargo.lock"), &mut packages); [INFO] [stderr] 213 | if !settings.ignore_err { [INFO] [stderr] 214 | res? [INFO] [stderr] 215 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:262:10 [INFO] [stderr] | [INFO] [stderr] 262 | .ok_or(toml::de::Error::custom("package section not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| toml::de::Error::custom("package section not found"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:260:10 [INFO] [stderr] | [INFO] [stderr] 260 | .ok_or(toml::de::Error::custom("package section not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| toml::de::Error::custom("package section not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:266:14 [INFO] [stderr] | [INFO] [stderr] 266 | .ok_or(toml::de::Error::custom("no name for package"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| toml::de::Error::custom("no name for package"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:269:14 [INFO] [stderr] | [INFO] [stderr] 269 | .ok_or(toml::de::Error::custom("no version for package"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| toml::de::Error::custom("no version for package"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:210:25 [INFO] [stderr] | [INFO] [stderr] 210 | Ok(path) => match path.file_name().to_str() { [INFO] [stderr] | _________________________^ [INFO] [stderr] 211 | | Some("Cargo.toml") => { [INFO] [stderr] 212 | | let res = [INFO] [stderr] 213 | | handle_cargo_lock(path.path().with_file_name("Cargo.lock"), &mut packages); [INFO] [stderr] ... | [INFO] [stderr] 222 | | _ => {} [INFO] [stderr] 223 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 210 | Ok(path) => if let Some("Cargo.toml") = path.file_name().to_str() { [INFO] [stderr] 211 | let res = [INFO] [stderr] 212 | handle_cargo_lock(path.path().with_file_name("Cargo.lock"), &mut packages); [INFO] [stderr] 213 | if !settings.ignore_err { [INFO] [stderr] 214 | res? [INFO] [stderr] 215 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:262:10 [INFO] [stderr] | [INFO] [stderr] 262 | .ok_or(toml::de::Error::custom("package section not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| toml::de::Error::custom("package section not found"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:260:10 [INFO] [stderr] | [INFO] [stderr] 260 | .ok_or(toml::de::Error::custom("package section not found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| toml::de::Error::custom("package section not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:266:14 [INFO] [stderr] | [INFO] [stderr] 266 | .ok_or(toml::de::Error::custom("no name for package"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| toml::de::Error::custom("no name for package"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:269:14 [INFO] [stderr] | [INFO] [stderr] 269 | .ok_or(toml::de::Error::custom("no version for package"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| toml::de::Error::custom("no version for package"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.61s [INFO] running `"docker" "inspect" "4346123ae43033aa080482f940100a376d6e1a5389bdf9dccc4a29c7d34304ce"` [INFO] running `"docker" "rm" "-f" "4346123ae43033aa080482f940100a376d6e1a5389bdf9dccc4a29c7d34304ce"` [INFO] [stdout] 4346123ae43033aa080482f940100a376d6e1a5389bdf9dccc4a29c7d34304ce