[INFO] crate hate 0.1.0 is already in cache [INFO] extracting crate hate 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/hate/0.1.0 [INFO] extracting crate hate 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hate/0.1.0 [INFO] validating manifest of hate-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hate-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hate-0.1.0 [INFO] finished frobbing hate-0.1.0 [INFO] frobbed toml for hate-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/hate/0.1.0/Cargo.toml [INFO] started frobbing hate-0.1.0 [INFO] finished frobbing hate-0.1.0 [INFO] frobbed toml for hate-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hate/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hate-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hate/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cda3085a0e5a61c64ef62f517b0f2c388b9b1f355f2647d21f821f7f944236d4 [INFO] running `"docker" "start" "-a" "cda3085a0e5a61c64ef62f517b0f2c388b9b1f355f2647d21f821f7f944236d4"` [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Compiling glutin v0.8.1 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking wayland-client v0.8.7 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_window_glutin v0.16.0 [INFO] [stderr] Checking hate v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:389:25 [INFO] [stderr] | [INFO] [stderr] 389 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:389:25 [INFO] [stderr] | [INFO] [stderr] 389 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:68:52 [INFO] [stderr] | [INFO] [stderr] 68 | #[cfg_attr(feature = "cargo-clippy", allow(new_without_default))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:68:52 [INFO] [stderr] | [INFO] [stderr] 68 | #[cfg_attr(feature = "cargo-clippy", allow(new_without_default))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/gui.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | self.backgrounds.get_mut(id).map(|bg| bg.set_pos(cursor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(bg) = self.backgrounds.get_mut(id) { bg.set_pos(cursor) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/gui.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | self.backgrounds.get_mut(id).map(|bg| bg.set_pos(cursor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(bg) = self.backgrounds.get_mut(id) { bg.set_pos(cursor) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn is_pos_inside(&self, pos: Point) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scene::Layer` [INFO] [stderr] --> src/lib.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> Self { [INFO] [stderr] 70 | | let data = LayerData { [INFO] [stderr] 71 | | sprites: Vec::new(), [INFO] [stderr] 72 | | }; [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | impl Default for scene::Layer { [INFO] [stderr] 68 | fn default() -> Self { [INFO] [stderr] 69 | Self::new() [INFO] [stderr] 70 | } [INFO] [stderr] 71 | } [INFO] [stderr] 72 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/gui.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | self.backgrounds.get_mut(id).map(|bg| bg.set_pos(cursor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(bg) = self.backgrounds.get_mut(id) { bg.set_pos(cursor) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/gui.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | self.backgrounds.get_mut(id).map(|bg| bg.set_pos(cursor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(bg) = self.backgrounds.get_mut(id) { bg.set_pos(cursor) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geom.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn is_pos_inside(&self, pos: Point) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `scene::Layer` [INFO] [stderr] --> src/lib.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / pub fn new() -> Self { [INFO] [stderr] 70 | | let data = LayerData { [INFO] [stderr] 71 | | sprites: Vec::new(), [INFO] [stderr] 72 | | }; [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | impl Default for scene::Layer { [INFO] [stderr] 68 | fn default() -> Self { [INFO] [stderr] 69 | Self::new() [INFO] [stderr] 70 | } [INFO] [stderr] 71 | } [INFO] [stderr] 72 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 04s [INFO] running `"docker" "inspect" "cda3085a0e5a61c64ef62f517b0f2c388b9b1f355f2647d21f821f7f944236d4"` [INFO] running `"docker" "rm" "-f" "cda3085a0e5a61c64ef62f517b0f2c388b9b1f355f2647d21f821f7f944236d4"` [INFO] [stdout] cda3085a0e5a61c64ef62f517b0f2c388b9b1f355f2647d21f821f7f944236d4