[INFO] crate hashmap_to_hashmap 0.9.0 is already in cache [INFO] extracting crate hashmap_to_hashmap 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/hashmap_to_hashmap/0.9.0 [INFO] extracting crate hashmap_to_hashmap 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hashmap_to_hashmap/0.9.0 [INFO] validating manifest of hashmap_to_hashmap-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hashmap_to_hashmap-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hashmap_to_hashmap-0.9.0 [INFO] finished frobbing hashmap_to_hashmap-0.9.0 [INFO] frobbed toml for hashmap_to_hashmap-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/hashmap_to_hashmap/0.9.0/Cargo.toml [INFO] started frobbing hashmap_to_hashmap-0.9.0 [INFO] finished frobbing hashmap_to_hashmap-0.9.0 [INFO] frobbed toml for hashmap_to_hashmap-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hashmap_to_hashmap/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hashmap_to_hashmap-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hashmap_to_hashmap/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3591084bf3afb9f24cfcbc1031320aa7066a93d1f1c6f8157804b7ba26e373f [INFO] running `"docker" "start" "-a" "a3591084bf3afb9f24cfcbc1031320aa7066a93d1f1c6f8157804b7ba26e373f"` [INFO] [stderr] Checking hashmap_to_hashmap v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:8:117 [INFO] [stderr] | [INFO] [stderr] 8 | impl NK, FV: Fn(&PK, &PV)->NV> Map for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 8 | impl NK, FV: Fn(&PK, &PV)->NV, S: ::std::hash::BuildHasher> Map for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:8:117 [INFO] [stderr] | [INFO] [stderr] 8 | impl NK, FV: Fn(&PK, &PV)->NV> Map for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 8 | impl NK, FV: Fn(&PK, &PV)->NV, S: ::std::hash::BuildHasher> Map for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | |k, v| k.to_string() + &"-" + &v.first_name + &" " + &v.last_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `v.last_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | |k, v| k.to_string() + &"-" + &v.first_name + &" " + &v.last_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `" "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | |k, v| k.to_string() + &"-" + &v.first_name + &" " + &v.last_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `v.first_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | |k, v| k.to_string() + &"-" + &v.first_name + &" " + &v.last_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"-"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | assert_eq!(new_map.get(&1).unwrap(), expected.get(&1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&new_map[&1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | assert_eq!(new_map.get(&1).unwrap(), expected.get(&1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&expected[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(new_map.get(&2).unwrap(), expected.get(&2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&new_map[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(new_map.get(&2).unwrap(), expected.get(&2).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&expected[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "a3591084bf3afb9f24cfcbc1031320aa7066a93d1f1c6f8157804b7ba26e373f"` [INFO] running `"docker" "rm" "-f" "a3591084bf3afb9f24cfcbc1031320aa7066a93d1f1c6f8157804b7ba26e373f"` [INFO] [stdout] a3591084bf3afb9f24cfcbc1031320aa7066a93d1f1c6f8157804b7ba26e373f