[INFO] crate hashconsing 0.10.1 is already in cache [INFO] extracting crate hashconsing 0.10.1 into work/ex/clippy-test-run/sources/stable/reg/hashconsing/0.10.1 [INFO] extracting crate hashconsing 0.10.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hashconsing/0.10.1 [INFO] validating manifest of hashconsing-0.10.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hashconsing-0.10.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hashconsing-0.10.1 [INFO] finished frobbing hashconsing-0.10.1 [INFO] frobbed toml for hashconsing-0.10.1 written to work/ex/clippy-test-run/sources/stable/reg/hashconsing/0.10.1/Cargo.toml [INFO] started frobbing hashconsing-0.10.1 [INFO] finished frobbing hashconsing-0.10.1 [INFO] frobbed toml for hashconsing-0.10.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hashconsing/0.10.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hashconsing-0.10.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hashconsing/0.10.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 39017877e2505873bf4a484dd904b716bb42278c808d9c838fd17097f504a43c [INFO] running `"docker" "start" "-a" "39017877e2505873bf4a484dd904b716bb42278c808d9c838fd17097f504a43c"` [INFO] [stderr] Checking hashconsing v0.10.1 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashSet [INFO] [stderr] --> src/coll.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | (& self.set).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/coll.rs:295:18 [INFO] [stderr] | [INFO] [stderr] 295 | (& self.map).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the HashMap [INFO] [stderr] --> src/coll.rs:305:22 [INFO] [stderr] | [INFO] [stderr] 305 | (& mut self.map).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashSet [INFO] [stderr] --> src/coll.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | (& self.set).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/coll.rs:295:18 [INFO] [stderr] | [INFO] [stderr] 295 | (& self.map).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the HashMap [INFO] [stderr] --> src/coll.rs:305:22 [INFO] [stderr] | [INFO] [stderr] 305 | (& mut self.map).into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:626:7 [INFO] [stderr] | [INFO] [stderr] 626 | / match self { [INFO] [stderr] 627 | | & Var(i) => write!(fmt, "v{}", i), [INFO] [stderr] 628 | | & Lam(ref t) => write!(fmt, "({})", t.get()), [INFO] [stderr] 629 | | & App(ref u, ref v) => write!(fmt, "{}.{}", u.get(), v.get()), [INFO] [stderr] 630 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 626 | match *self { [INFO] [stderr] 627 | Var(i) => write!(fmt, "v{}", i), [INFO] [stderr] 628 | Lam(ref t) => write!(fmt, "({})", t.get()), [INFO] [stderr] 629 | App(ref u, ref v) => write!(fmt, "{}.{}", u.get(), v.get()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lib.rs:650:3 [INFO] [stderr] | [INFO] [stderr] 650 | / fn run() { [INFO] [stderr] 651 | | let mut consign = HConsign::empty() ; [INFO] [stderr] 652 | | assert_eq!(consign.len(), 0) ; [INFO] [stderr] 653 | | [INFO] [stderr] ... | [INFO] [stderr] 728 | | } [INFO] [stderr] 729 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "39017877e2505873bf4a484dd904b716bb42278c808d9c838fd17097f504a43c"` [INFO] running `"docker" "rm" "-f" "39017877e2505873bf4a484dd904b716bb42278c808d9c838fd17097f504a43c"` [INFO] [stdout] 39017877e2505873bf4a484dd904b716bb42278c808d9c838fd17097f504a43c