[INFO] crate hash-roll 0.2.0 is already in cache
[INFO] extracting crate hash-roll 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/hash-roll/0.2.0
[INFO] extracting crate hash-roll 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hash-roll/0.2.0
[INFO] validating manifest of hash-roll-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of hash-roll-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing hash-roll-0.2.0
[INFO] finished frobbing hash-roll-0.2.0
[INFO] frobbed toml for hash-roll-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/hash-roll/0.2.0/Cargo.toml
[INFO] started frobbing hash-roll-0.2.0
[INFO] finished frobbing hash-roll-0.2.0
[INFO] frobbed toml for hash-roll-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hash-roll/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting hash-roll-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hash-roll/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b749a6cc7435bf92b7598c18de59456ff72d3a03124e878e91a4cf92b9fa120a
[INFO] running `"docker" "start" "-a" "b749a6cc7435bf92b7598c18de59456ff72d3a03124e878e91a4cf92b9fa120a"`
[INFO] [stderr]     Checking fmt-extra v0.1.2
[INFO] [stderr]     Checking rollsum v0.2.1
[INFO] [stderr]     Checking hash-roll v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/zpaq.rs:147:13
[INFO] [stderr]     |
[INFO] [stderr] 147 |             range: range,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/rsyncable.rs:125:41
[INFO] [stderr]     |
[INFO] [stderr] 125 |         Rsyncable { window_len: window, modulus: modulus }
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^ help: replace it with: `modulus`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/zpaq.rs:147:13
[INFO] [stderr]     |
[INFO] [stderr] 147 |             range: range,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:229:13
[INFO] [stderr]     |
[INFO] [stderr] 229 |             d: d,
[INFO] [stderr]     |             ^^^^ help: replace it with: `d`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:278:13
[INFO] [stderr]     |
[INFO] [stderr] 278 |             d: d,
[INFO] [stderr]     |             ^^^^ help: replace it with: `d`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/rsyncable.rs:125:41
[INFO] [stderr]     |
[INFO] [stderr] 125 |         Rsyncable { window_len: window, modulus: modulus }
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^ help: replace it with: `modulus`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:229:13
[INFO] [stderr]     |
[INFO] [stderr] 229 |             d: d,
[INFO] [stderr]     |             ^^^^ help: replace it with: `d`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:278:13
[INFO] [stderr]     |
[INFO] [stderr] 278 |             d: d,
[INFO] [stderr]     |             ^^^^ help: replace it with: `d`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bup.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/zpaq.rs:278:71
[INFO] [stderr]     |
[INFO] [stderr] 278 |             (self.hash + Wrapping(c as u32) + Wrapping(1)) * Wrapping(314159265)
[INFO] [stderr]     |                                                                       ^^^^^^^^^ help: consider: `314_159_265`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/zpaq.rs:280:71
[INFO] [stderr]     |
[INFO] [stderr] 280 |             (self.hash + Wrapping(c as u32) + Wrapping(1)) * Wrapping(271828182)
[INFO] [stderr]     |                                                                       ^^^^^^^^^ help: consider: `271_828_182`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bup.rs:142:9
[INFO] [stderr]     |
[INFO] [stderr] 142 |         return 0;
[INFO] [stderr]     |         ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/bup.rs:199:32
[INFO] [stderr]     |
[INFO] [stderr] 199 |         assert_eq!(m.digest(), 130279491);
[INFO] [stderr]     |                                ^^^^^^^^^ help: consider: `130_279_491`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/zpaq.rs:278:71
[INFO] [stderr]     |
[INFO] [stderr] 278 |             (self.hash + Wrapping(c as u32) + Wrapping(1)) * Wrapping(314159265)
[INFO] [stderr]     |                                                                       ^^^^^^^^^ help: consider: `314_159_265`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/zpaq.rs:280:71
[INFO] [stderr]     |
[INFO] [stderr] 280 |             (self.hash + Wrapping(c as u32) + Wrapping(1)) * Wrapping(271828182)
[INFO] [stderr]     |                                                                       ^^^^^^^^^ help: consider: `271_828_182`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bup.rs:77:26
[INFO] [stderr]    |
[INFO] [stderr] 77 |         let d = Wrapping(drop as u32);
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: try: `u32::from(drop)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bup.rs:78:29
[INFO] [stderr]    |
[INFO] [stderr] 78 |         self.s1 += Wrapping(add as u32);
[INFO] [stderr]    |                             ^^^^^^^^^^ help: try: `u32::from(add)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/bup.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     fn next_iter<'a, T: Iterator<Item=u8>>(&'a self, iter: T) -> Option<Vec<u8>>
[INFO] [stderr] 146 | |     {
[INFO] [stderr] 147 | |         let mut r = RollSum::default();
[INFO] [stderr] 148 | |         let a = r.window.len() + r.window.len() / 2;
[INFO] [stderr] ...   |
[INFO] [stderr] 162 | |         }
[INFO] [stderr] 163 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zpaq.rs:278:35
[INFO] [stderr]     |
[INFO] [stderr] 278 |             (self.hash + Wrapping(c as u32) + Wrapping(1)) * Wrapping(314159265)
[INFO] [stderr]     |                                   ^^^^^^^^ help: try: `u32::from(c)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zpaq.rs:280:35
[INFO] [stderr]     |
[INFO] [stderr] 280 |             (self.hash + Wrapping(c as u32) + Wrapping(1)) * Wrapping(271828182)
[INFO] [stderr]     |                                   ^^^^^^^^ help: try: `u32::from(c)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/rsyncable.rs:77:36
[INFO] [stderr]    |
[INFO] [stderr] 77 |             self.accum -= Wrapping(data[i - base.window_len] as u64);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data[i - base.window_len])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/rsyncable.rs:79:32
[INFO] [stderr]    |
[INFO] [stderr] 79 |         self.accum += Wrapping(v as u64);
[INFO] [stderr]    |                                ^^^^^^^^ help: try: `u64::from(v)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/rsyncable.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 | /     fn find_chunk_edge<'a, 'b>(&'a self, data: &'b [u8]) -> usize
[INFO] [stderr] 86 | |     {
[INFO] [stderr] 87 | |         let mut hs = HashState::default();
[INFO] [stderr] 88 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |         l
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/rsyncable.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 | /     fn next_iter<'a, T: Iterator<Item=u8>>(&'a self, iter: T) -> Option<Vec<u8>>
[INFO] [stderr] 101 | |     {
[INFO] [stderr] 102 | |         let mut hs = HashState::default();
[INFO] [stderr] 103 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 118 | |         }
[INFO] [stderr] 119 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 | /     fn into_slices<'a>(self, data: &'a [u8]) -> SplitterSlices<'a, Self>
[INFO] [stderr] 105 | |         where Self: Sized
[INFO] [stderr] 106 | |     {
[INFO] [stderr] 107 | |         SplitterSlices::from(self, data)
[INFO] [stderr] 108 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/lib.rs:120:18
[INFO] [stderr]     |
[INFO] [stderr] 120 |     fn into_vecs<'a, T: Iterator<Item=u8>>(self, data: T) -> SplitterVecs<T, Self>
[INFO] [stderr]     |                  ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 | /     fn as_vecs<'a, T: Iterator<Item=u8>>(&'a self, data: T) -> SplitterVecs<T, &Self>
[INFO] [stderr] 127 | |         where Self: Sized
[INFO] [stderr] 128 | |     {
[INFO] [stderr] 129 | |         SplitterVecs::from(self, data)
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bup.rs:77:26
[INFO] [stderr]    |
[INFO] [stderr] 77 |         let d = Wrapping(drop as u32);
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: try: `u32::from(drop)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/bup.rs:78:29
[INFO] [stderr]    |
[INFO] [stderr] 78 |         self.s1 += Wrapping(add as u32);
[INFO] [stderr]    |                             ^^^^^^^^^^ help: try: `u32::from(add)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/bup.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     fn next_iter<'a, T: Iterator<Item=u8>>(&'a self, iter: T) -> Option<Vec<u8>>
[INFO] [stderr] 146 | |     {
[INFO] [stderr] 147 | |         let mut r = RollSum::default();
[INFO] [stderr] 148 | |         let a = r.window.len() + r.window.len() / 2;
[INFO] [stderr] ...   |
[INFO] [stderr] 162 | |         }
[INFO] [stderr] 163 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zpaq.rs:278:35
[INFO] [stderr]     |
[INFO] [stderr] 278 |             (self.hash + Wrapping(c as u32) + Wrapping(1)) * Wrapping(314159265)
[INFO] [stderr]     |                                   ^^^^^^^^ help: try: `u32::from(c)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/zpaq.rs:280:35
[INFO] [stderr]     |
[INFO] [stderr] 280 |             (self.hash + Wrapping(c as u32) + Wrapping(1)) * Wrapping(271828182)
[INFO] [stderr]     |                                   ^^^^^^^^ help: try: `u32::from(c)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/rsyncable.rs:77:36
[INFO] [stderr]    |
[INFO] [stderr] 77 |             self.accum -= Wrapping(data[i - base.window_len] as u64);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data[i - base.window_len])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/rsyncable.rs:79:32
[INFO] [stderr]    |
[INFO] [stderr] 79 |         self.accum += Wrapping(v as u64);
[INFO] [stderr]    |                                ^^^^^^^^ help: try: `u64::from(v)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/rsyncable.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 | /     fn find_chunk_edge<'a, 'b>(&'a self, data: &'b [u8]) -> usize
[INFO] [stderr] 86 | |     {
[INFO] [stderr] 87 | |         let mut hs = HashState::default();
[INFO] [stderr] 88 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |         l
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/rsyncable.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 | /     fn next_iter<'a, T: Iterator<Item=u8>>(&'a self, iter: T) -> Option<Vec<u8>>
[INFO] [stderr] 101 | |     {
[INFO] [stderr] 102 | |         let mut hs = HashState::default();
[INFO] [stderr] 103 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 118 | |         }
[INFO] [stderr] 119 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 | /     fn into_slices<'a>(self, data: &'a [u8]) -> SplitterSlices<'a, Self>
[INFO] [stderr] 105 | |         where Self: Sized
[INFO] [stderr] 106 | |     {
[INFO] [stderr] 107 | |         SplitterSlices::from(self, data)
[INFO] [stderr] 108 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/lib.rs:120:18
[INFO] [stderr]     |
[INFO] [stderr] 120 |     fn into_vecs<'a, T: Iterator<Item=u8>>(self, data: T) -> SplitterVecs<T, Self>
[INFO] [stderr]     |                  ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 | /     fn as_vecs<'a, T: Iterator<Item=u8>>(&'a self, data: T) -> SplitterVecs<T, &Self>
[INFO] [stderr] 127 | |         where Self: Sized
[INFO] [stderr] 128 | |     {
[INFO] [stderr] 129 | |         SplitterVecs::from(self, data)
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:305:18
[INFO] [stderr]     |
[INFO] [stderr] 305 |     let mut d2 = d1.clone();
[INFO] [stderr]     |                  ^^^^^^^^^^ help: try dereferencing it: `*d1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/lib.rs:306:13
[INFO] [stderr]     |
[INFO] [stderr] 306 |     d2[4] = ':' as u8;
[INFO] [stderr]     |             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b':'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> tests/qc_bup.rs:37:16
[INFO] [stderr]    |
[INFO] [stderr] 37 |             if x.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.68s
[INFO] running `"docker" "inspect" "b749a6cc7435bf92b7598c18de59456ff72d3a03124e878e91a4cf92b9fa120a"`
[INFO] running `"docker" "rm" "-f" "b749a6cc7435bf92b7598c18de59456ff72d3a03124e878e91a4cf92b9fa120a"`
[INFO] [stdout] b749a6cc7435bf92b7598c18de59456ff72d3a03124e878e91a4cf92b9fa120a