[INFO] crate hash-rings 1.0.0 is already in cache [INFO] extracting crate hash-rings 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/hash-rings/1.0.0 [INFO] extracting crate hash-rings 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hash-rings/1.0.0 [INFO] validating manifest of hash-rings-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of hash-rings-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing hash-rings-1.0.0 [INFO] finished frobbing hash-rings-1.0.0 [INFO] frobbed toml for hash-rings-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/hash-rings/1.0.0/Cargo.toml [INFO] started frobbing hash-rings-1.0.0 [INFO] finished frobbing hash-rings-1.0.0 [INFO] frobbed toml for hash-rings-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/hash-rings/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting hash-rings-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/hash-rings/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e1d567ce62c70b9db4f5a3db6978a5094d417e0d2364169aab64333a08ad48e5 [INFO] running `"docker" "start" "-a" "e1d567ce62c70b9db4f5a3db6978a5094d417e0d2364169aab64333a08ad48e5"` [INFO] [stderr] Checking hash-rings v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/consistent.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | / if !self.data.contains_key(&new_hash) { [INFO] [stderr] 327 | | if let Some((hash, points)) = self.get_next_node(new_hash) { [INFO] [stderr] 328 | | let (old_set, new_set) = points.drain().partition(|point| { [INFO] [stderr] 329 | | let point_hash = util::gen_hash(point); [INFO] [stderr] ... | [INFO] [stderr] 340 | | self.data.insert(new_hash, new_points); [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____________^ help: consider using: `self.data.entry(new_hash)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/maglev.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | self.nodes.iter().map(|node| *node) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.nodes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rendezvous.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | self.nodes[id].iter().map(|point| *point).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.nodes[id].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rendezvous.rs:507:26 [INFO] [stderr] | [INFO] [stderr] 507 | (&**node_id, points.iter().map(|point| *point).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `points.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/weighted_rendezvous.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | self.nodes[id].iter().map(|point| *point).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.nodes[id].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/weighted_rendezvous.rs:492:26 [INFO] [stderr] | [INFO] [stderr] 492 | (&**node_id, points.iter().map(|point| *point).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `points.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/consistent.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | / if !self.data.contains_key(&new_hash) { [INFO] [stderr] 327 | | if let Some((hash, points)) = self.get_next_node(new_hash) { [INFO] [stderr] 328 | | let (old_set, new_set) = points.drain().partition(|point| { [INFO] [stderr] 329 | | let point_hash = util::gen_hash(point); [INFO] [stderr] ... | [INFO] [stderr] 340 | | self.data.insert(new_hash, new_points); [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____________^ help: consider using: `self.data.entry(new_hash)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/maglev.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | self.nodes.iter().map(|node| *node) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.nodes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rendezvous.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | self.nodes[id].iter().map(|point| *point).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.nodes[id].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rendezvous.rs:507:26 [INFO] [stderr] | [INFO] [stderr] 507 | (&**node_id, points.iter().map(|point| *point).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `points.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/weighted_rendezvous.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | self.nodes[id].iter().map(|point| *point).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.nodes[id].iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/weighted_rendezvous.rs:492:26 [INFO] [stderr] | [INFO] [stderr] 492 | (&**node_id, points.iter().map(|point| *point).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `points.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.71s [INFO] running `"docker" "inspect" "e1d567ce62c70b9db4f5a3db6978a5094d417e0d2364169aab64333a08ad48e5"` [INFO] running `"docker" "rm" "-f" "e1d567ce62c70b9db4f5a3db6978a5094d417e0d2364169aab64333a08ad48e5"` [INFO] [stdout] e1d567ce62c70b9db4f5a3db6978a5094d417e0d2364169aab64333a08ad48e5